Fixed infinite loop / stack overflow when reservedNames patterns match all generated identifier names (#1390)

test/unit-tests/generators/identifier-names-generators/HexadecimalIdentifierNamesGenerator.spec.ts

@@ -121,4 +121,26 @@ describe('HexadecimalIdentifierNamesGenerator', () => {
             assert.notEqual(hexadecimalIdentifierName1, hexadecimalIdentifierName2);
         });
     });
+
+    describe('`reservedNames` that match all generated names', () => {
+        let testFunc: () => void;
+
+        before(() => {
+            const inversifyContainerFacade: IInversifyContainerFacade = new InversifyContainerFacade();
+
+            inversifyContainerFacade.load('', '', {
+                reservedNames: ['^(?!renameMeOnly$)']
+            });
+            const identifierNamesGenerator = inversifyContainerFacade.getNamed<IIdentifierNamesGenerator>(
+                ServiceIdentifiers.IIdentifierNamesGenerator,
+                IdentifierNamesGenerator.HexadecimalIdentifierNamesGenerator
+            );
+
+            testFunc = () => identifierNamesGenerator.generateNext();
+        });
+
+        it('should throw an error when all generated names match reservedNames', () => {
+            assert.throws(testFunc, 'Unable to generate a valid identifier name');
+        });
+    });
 });

test/unit-tests/generators/identifier-names-generators/MangledShuffledlIdentifierNamesGenerator.spec.ts

@@ -217,4 +217,26 @@ describe('MangledShuffledIdentifierNamesGenerator', () => {
             });
         });
     });
+
+    describe('`reservedNames` that match all generated names', () => {
+        let testFunc: () => void;
+
+        beforeEach(() => {
+            const inversifyContainerFacade: IInversifyContainerFacade = new InversifyContainerFacade();
+
+            inversifyContainerFacade.load('', '', {
+                reservedNames: ['^(?!renameMeOnly$)']
+            });
+            const identifierNamesGenerator = inversifyContainerFacade.getNamed<IIdentifierNamesGenerator>(
+                ServiceIdentifiers.IIdentifierNamesGenerator,
+                IdentifierNamesGenerator.MangledShuffledIdentifierNamesGenerator
+            );
+
+            testFunc = () => identifierNamesGenerator.generateNext();
+        });
+
+        it('should throw an error when all generated names match reservedNames', () => {
+            assert.throws(testFunc, 'Unable to generate a valid identifier name');
+        });
+    });
 });

test/unit-tests/generators/identifier-names-generators/MangledlIdentifierNamesGenerator.spec.ts

@@ -342,4 +342,26 @@ describe('MangledIdentifierNamesGenerator', () => {
             });
         });
     });
+
+    describe('`reservedNames` that match all generated names', () => {
+        let testFunc: () => void;
+
+        beforeEach(() => {
+            const inversifyContainerFacade: IInversifyContainerFacade = new InversifyContainerFacade();
+
+            inversifyContainerFacade.load('', '', {
+                reservedNames: ['^(?!renameMeOnly$)']
+            });
+            const identifierNamesGenerator = inversifyContainerFacade.getNamed<IIdentifierNamesGenerator>(
+                ServiceIdentifiers.IIdentifierNamesGenerator,
+                IdentifierNamesGenerator.MangledIdentifierNamesGenerator
+            );
+
+            testFunc = () => identifierNamesGenerator.generateNext();
+        });
+
+        it('should throw an error when all generated names match reservedNames', () => {
+            assert.throws(testFunc, 'Unable to generate a valid identifier name');
+        });
+    });
 });