From 2c197599aae7a22d99e4ac58b25cf5aa60a92d4c Mon Sep 17 00:00:00 2001 From: Eric Kilmer Date: Mon, 19 Dec 2022 11:05:48 -0500 Subject: [PATCH] Fix update_ghidra_head script git output parsing Python string split behaves differently than I assumed: >>> "".split("\n") [''] returns a list of size 1 but >>> "".split() [] returns size 0 and >>> "".splitlines() [] also returns size 0 --- scripts/update_ghidra_head.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/update_ghidra_head.py b/scripts/update_ghidra_head.py index e2b28b1..d50e884 100644 --- a/scripts/update_ghidra_head.py +++ b/scripts/update_ghidra_head.py @@ -69,7 +69,7 @@ def git_get_changed_files( ) .stdout.decode() .strip() - .split("\n") + .splitlines() ) num_changed = len(changed_files) if num_changed > 0: