From 00e2c2fb29d712e4014e24a70489545fc1965898 Mon Sep 17 00:00:00 2001 From: "Yukihiro \"Matz\" Matsumoto" Date: Fri, 24 Apr 2026 08:19:15 +0900 Subject: [PATCH] Revert "gha: start DNS Client service and probe Windows localhost resolution" This reverts commit 7ae25febbbc06a23f5d7094071a8ecf370d6ddd8. CI runs with this change showed Dnscache was already Running on all Windows jobs and Resolve-DnsName resolved "localhost" successfully, yet Winsock getaddrinfo still failed. The service start and probe had no effect on the failing tests, so they add noise without value. Co-authored-by: Claude --- .github/workflows/build.yml | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 357640261..74ba156bf 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -42,18 +42,8 @@ jobs: if: runner.os == 'Windows' shell: pwsh run: | - Write-Host "=== Dnscache service state (before) ===" - Get-Service Dnscache | Format-List Name, Status, StartType - if ((Get-Service Dnscache).Status -ne 'Running') { - Set-Service -Name Dnscache -StartupType Automatic - Start-Service -Name Dnscache - } - Write-Host "=== Dnscache service state (after) ===" - Get-Service Dnscache | Format-List Name, Status, StartType Add-Content -Path $env:WINDIR\System32\drivers\etc\hosts -Value "127.0.0.1 localhost" Add-Content -Path $env:WINDIR\System32\drivers\etc\hosts -Value "::1 localhost" - Write-Host "=== Resolve-DnsName localhost ===" - Resolve-DnsName localhost -ErrorAction Continue | Format-List - name: Build and test run: rake -m test:run:serial @@ -98,18 +88,8 @@ jobs: - name: Ensure localhost resolves shell: pwsh run: | - Write-Host "=== Dnscache service state (before) ===" - Get-Service Dnscache | Format-List Name, Status, StartType - if ((Get-Service Dnscache).Status -ne 'Running') { - Set-Service -Name Dnscache -StartupType Automatic - Start-Service -Name Dnscache - } - Write-Host "=== Dnscache service state (after) ===" - Get-Service Dnscache | Format-List Name, Status, StartType Add-Content -Path $env:WINDIR\System32\drivers\etc\hosts -Value "127.0.0.1 localhost" Add-Content -Path $env:WINDIR\System32\drivers\etc\hosts -Value "::1 localhost" - Write-Host "=== Resolve-DnsName localhost ===" - Resolve-DnsName localhost -ErrorAction Continue | Format-List - name: Build and test shell: cmd run: |