From 0293037b218e178ac10e2e5b96e67102423474f9 Mon Sep 17 00:00:00 2001
From: "Yukihiro \"Matz\" Matsumoto" <matz@ruby.or.jp>
Date: Thu, 10 Mar 2022 10:43:22 +0900
Subject: [PATCH] proc.c: refactor proc type checking.

---
 src/proc.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/src/proc.c b/src/proc.c
index abace39de..769323950 100644
--- a/src/proc.c
+++ b/src/proc.c
@@ -237,14 +237,20 @@ mrb_proc_s_new(mrb_state *mrb, mrb_value proc_class)
   return proc;
 }
 
+static void
+check_proc(mrb_state *mrb, mrb_value proc)
+{
+  if (!mrb_proc_p(proc)) {
+    mrb_raise(mrb, E_ARGUMENT_ERROR, "not a proc");
+  }
+}
+
 static mrb_value
 mrb_proc_init_copy(mrb_state *mrb, mrb_value self)
 {
   mrb_value proc = mrb_get_arg1(mrb);
 
-  if (!mrb_proc_p(proc)) {
-    mrb_raise(mrb, E_ARGUMENT_ERROR, "not a proc");
-  }
+  check_proc(mrb, proc);
   mrb_proc_copy(mrb, mrb_proc_ptr(self), mrb_proc_ptr(proc));
   return self;
 }
@@ -275,9 +281,7 @@ proc_lambda(mrb_state *mrb, mrb_value self)
   if (mrb_nil_p(blk)) {
     mrb_raise(mrb, E_ARGUMENT_ERROR, "tried to create Proc object without a block");
   }
-  if (!mrb_proc_p(blk)) {
-    mrb_raise(mrb, E_ARGUMENT_ERROR, "not a proc");
-  }
+  check_proc(mrb, blk);
   p = mrb_proc_ptr(blk);
   if (!MRB_PROC_STRICT_P(p)) {
     struct RProc *p2 = MRB_OBJ_ALLOC(mrb, MRB_TT_PROC, p->c);