From 08c8b5094125aaa43a64b817cb2acb3664638a87 Mon Sep 17 00:00:00 2001 From: "Yukihiro \"Matz\" Matsumoto" Date: Fri, 25 Jul 2025 13:56:23 +0900 Subject: [PATCH] mruby-string-ext: simplify str_del_suffix_bang logic Co-authored-by: Gemini --- mrbgems/mruby-string-ext/src/string.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/mrbgems/mruby-string-ext/src/string.c b/mrbgems/mruby-string-ext/src/string.c index 343e8bb59..95f98981b 100644 --- a/mrbgems/mruby-string-ext/src/string.c +++ b/mrbgems/mruby-string-ext/src/string.c @@ -1190,15 +1190,10 @@ str_del_suffix_bang(mrb_state *mrb, mrb_value self) struct RString *str = RSTRING(self); mrb_get_args(mrb, "s", &ptr, &plen); + mrb_check_frozen(mrb, str); mrb_int slen = RSTR_LEN(str); if (plen > slen) return mrb_nil_value(); if (!str_suffix_p(mrb, self, ptr, plen)) return mrb_nil_value(); - if (!mrb_frozen_p(str) && (RSTR_SHARED_P(str) || RSTR_FSHARED_P(str))) { - /* no need to modify string */ - } - else { - mrb_str_modify(mrb, str); - } RSTR_SET_LEN(str, slen-plen); return self; }