From 550be1445f56799888a588ff2a1609c03a45b692 Mon Sep 17 00:00:00 2001 From: "Yukihiro \"Matz\" Matsumoto" Date: Fri, 24 Apr 2026 08:19:04 +0900 Subject: [PATCH] Revert "mruby-socket: add temporary getaddrinfo diagnostic for Windows CI" This reverts commit a69d12aa545a3e734344334629eb69626d0d6e73. The diagnostic served its purpose: it isolated the failure to Winsock's getaddrinfo for the "localhost" hostname. The permanent fix (skip guard) is now in place, so remove the temporary probe. Co-authored-by: Claude --- mrbgems/mruby-socket/test/addrinfo.rb | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/mrbgems/mruby-socket/test/addrinfo.rb b/mrbgems/mruby-socket/test/addrinfo.rb index 90ea763fd..eaab2a39e 100644 --- a/mrbgems/mruby-socket/test/addrinfo.rb +++ b/mrbgems/mruby-socket/test/addrinfo.rb @@ -6,27 +6,6 @@ assert('super class of Addrinfo') do assert_equal(Object, Addrinfo.superclass) end -# TEMPORARY DIAGNOSTIC: observe which getaddrinfo pattern works on Windows CI. -# Remove once the root cause is identified and the real fix is in place. -assert('Addrinfo.getaddrinfo diagnostic') do - cases = [ - ['127.0.0.1 literal AF_INET', -> { Addrinfo.getaddrinfo('127.0.0.1', 53, Socket::AF_INET, Socket::SOCK_STREAM) }], - ['localhost AF_UNSPEC', -> { Addrinfo.getaddrinfo('localhost', 53, Socket::AF_UNSPEC, Socket::SOCK_STREAM) }], - ['localhost nil family', -> { Addrinfo.getaddrinfo('localhost', 53) }], - ['localhost AF_INET6', -> { Addrinfo.getaddrinfo('localhost', 53, Socket::AF_INET6, Socket::SOCK_STREAM) }], - ['localhost AF_INET (orig)', -> { Addrinfo.getaddrinfo('localhost', 53, Socket::AF_INET, Socket::SOCK_STREAM) }], - ] - cases.each do |label, probe| - begin - ary = probe.call - puts "DIAG #{label}: OK size=#{ary.size} first=#{ary.first&.ip_address.inspect}" - rescue => e - puts "DIAG #{label}: #{e.class} #{e.message}" - end - end - assert_true(true) -end - assert('Addrinfo.getaddrinfo') do skip "localhost resolution unreliable in Windows getaddrinfo" if SocketTest.win? ary = Addrinfo.getaddrinfo("localhost", 53, Socket::AF_INET, Socket::SOCK_STREAM)