From 8d61b67dc1f5afb7ad9d7f0f738fe5fa3b0fa939 Mon Sep 17 00:00:00 2001 From: "Yukihiro \"Matz\" Matsumoto" Date: Sat, 11 Oct 2025 10:29:41 +0900 Subject: [PATCH] mruby-task: fix c++ compatibility warnings - remove redundant MRB_TASK_CREATED/STOPPED macros from task.h since they are now properly defined in mrb_fiber_state enum in mruby.h - declare kw_names array separately to avoid taking address of temporary array in c++ compilation Co-authored-by: Claude --- mrbgems/mruby-task/include/task.h | 5 ++--- mrbgems/mruby-task/src/task.c | 3 ++- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/mrbgems/mruby-task/include/task.h b/mrbgems/mruby-task/include/task.h index f528f0870..6004821a4 100644 --- a/mrbgems/mruby-task/include/task.h +++ b/mrbgems/mruby-task/include/task.h @@ -99,10 +99,9 @@ mrb_value mrb_tasks_run(mrb_state *mrb); void mrb_task_mark_all(mrb_state *mrb); /* - * Task context status values (extends mrb_fiber_state) + * Task context status values + * (MRB_TASK_CREATED and MRB_TASK_STOPPED are defined in mrb_fiber_state enum) */ -#define MRB_TASK_CREATED (MRB_FIBER_TERMINATED + 1) -#define MRB_TASK_STOPPED (MRB_FIBER_TERMINATED + 2) #endif /* MRB_USE_TASK_SCHEDULER */ diff --git a/mrbgems/mruby-task/src/task.c b/mrbgems/mruby-task/src/task.c index 2ebbe63d3..afe56ba34 100644 --- a/mrbgems/mruby-task/src/task.c +++ b/mrbgems/mruby-task/src/task.c @@ -988,8 +988,9 @@ mrb_task_s_new(mrb_state *mrb, mrb_value self) mrb_task *t; mrb_value task_obj; mrb_value kw_values[2] = {mrb_undef_value(), mrb_undef_value()}; + mrb_sym kw_names[2] = {mrb_intern_lit(mrb, "name"), mrb_intern_lit(mrb, "priority")}; const mrb_kwargs kwargs = { - 2, 0, (mrb_sym[]){mrb_intern_lit(mrb, "name"), mrb_intern_lit(mrb, "priority")}, kw_values, NULL + 2, 0, kw_names, kw_values, NULL }; /* Get block and optional keyword arguments */