From d86f4d220f340b093ac0f6edc6da89fa178cc8bb Mon Sep 17 00:00:00 2001 From: John Bampton Date: Sat, 25 Feb 2023 15:22:17 +1000 Subject: [PATCH] benchmark: remove duplicate method calls DuplicateMethodCall: Scene#render calls 'nsf * nsf' 3 times --- benchmark/bm_ao_render.rb | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/benchmark/bm_ao_render.rb b/benchmark/bm_ao_render.rb index 91e2d3419..ddb42d5c6 100644 --- a/benchmark/bm_ao_render.rb +++ b/benchmark/bm_ao_render.rb @@ -253,6 +253,7 @@ class Scene def render(w, h, nsubsamples) nsf = nsubsamples.to_f + nsfs = nsf * nsf h.times do |y| w.times do |x| rad = Vec.new(0.0, 0.0, 0.0) @@ -288,9 +289,9 @@ class Scene end end - r = rad.x / (nsf * nsf) - g = rad.y / (nsf * nsf) - b = rad.z / (nsf * nsf) + r = rad.x / nsfs + g = rad.y / nsfs + b = rad.z / nsfs printf("%c", clamp(r)) printf("%c", clamp(g)) printf("%c", clamp(b))