admin/mruby-mruby
1
0
Fork 0
mirror of https://github.com/mruby/mruby synced 2026-06-08 16:11:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

variable.c (mrb_exc_const_get): E_XXX_ERROR should not call const_missing

Browse Source 
As #6359 pointed out, calling const_missing hook from E_XXX_ERROR (that
calls mrb_exc_get_id()) can be an attack vector.  Since E_XXX_ERROR is
supposed to be a defined error class, we think that the situation where
it is undefined and the const_missing hook is called should be detected
as an error; fix #6359
This commit is contained in:
Yukihiro "Matz" Matsumoto
2024-10-11 08:16:24 +09:00
parent b5801cd730
commit fa68e634a7
3 changed files with 29 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/class.c
+4 -2
View File
@@ -659,7 +659,7 @@ mrb_class_get_id(mrb_state *mrb, mrb_sym name)
MRB_API struct RClass*
mrb_exc_get_id(mrb_state *mrb, mrb_sym name)
{
mrb_value c = mrb_const_get(mrb, mrb_obj_value(mrb->object_class), name);
mrb_value c = mrb_exc_const_get(mrb, name);
if (!mrb_class_p(c)) {
mrb_raise(mrb, E_EXCEPTION, "exception corrupted");
@@ -670,7 +670,9 @@ mrb_exc_get_id(mrb_state *mrb, mrb_sym name)
if (e == E_EXCEPTION)
return exc;
}
return E_EXCEPTION;
mrb_raise(mrb, E_EXCEPTION, "non-exception raised");
/* not reached */
return NULL;
}
MRB_API struct RClass*