mirror of
https://github.com/mruby/mruby
synced 2026-06-08 16:11:16 +00:00
Yukihiro "Matz" Matsumoto
478ada3bf4
When sprintf is called with a precision larger than the double's significand width (e.g. "%.51g"), fixed_width() indexed pow10 tables out of bounds and produced a negative shift exponent. Cap the internal digit count to 18 in the %g branch, matching the existing %e and %f branches; downstream loops already zero-pad to the caller's precision so visible output is unchanged. Co-authored-by: Claude <noreply@anthropic.com>
119 lines
3.6 KiB
Ruby
119 lines
3.6 KiB
Ruby
assert('sprintf invalid') do
|
|
assert_raise(ArgumentError) { sprintf('%1$*d', 3) }
|
|
assert_raise(ArgumentError) { sprintf('%1$.*d', 3) }
|
|
end
|
|
|
|
assert('String#%') do
|
|
assert_equal "one=1", "one=%d" % 1
|
|
assert_equal "1 one", "%d %s" % [ 1, "one" ]
|
|
assert_equal "123 < 456", "%{num} < %<str>s" % { num: 123, str: "456" }
|
|
assert_equal 15, ("%b" % (1<<14)).size
|
|
skip unless Object.const_defined?(:Float)
|
|
assert_equal "1.0", "%3.1f" % 1.01
|
|
assert_equal " 12345.12", "% 4.2f" % 12345.1234
|
|
assert_equal "12345.12", "%-4.2f" % 12345.12345
|
|
assert_equal "+12345.12", "%+4.2f" % 12345.1234
|
|
assert_equal "12345.12", "%04.2f" % 12345.12345
|
|
assert_equal "0012345.12", "%010.2f" % 12345.1234
|
|
end
|
|
|
|
assert('String#% with inf') do
|
|
skip unless Object.const_defined?(:Float)
|
|
inf = Float::INFINITY
|
|
|
|
assert_equal "Inf", "%f" % inf
|
|
assert_equal "Inf", "%2f" % inf
|
|
assert_equal "Inf", "%3f" % inf
|
|
assert_equal " Inf", "%4f" % inf
|
|
assert_equal " Inf", "%5f" % inf
|
|
|
|
assert_equal "+Inf", "%+f" % inf
|
|
assert_equal "+Inf", "%+2f" % inf
|
|
assert_equal "+Inf", "%+3f" % inf
|
|
assert_equal "+Inf", "%+4f" % inf
|
|
assert_equal " +Inf", "%+5f" % inf
|
|
|
|
assert_equal "Inf", "%-f" % inf
|
|
assert_equal "Inf", "%-2f" % inf
|
|
assert_equal "Inf", "%-3f" % inf
|
|
assert_equal "Inf ", "%-4f" % inf
|
|
assert_equal "Inf ", "%-5f" % inf
|
|
|
|
assert_equal " Inf", "% f" % inf
|
|
assert_equal " Inf", "% 2f" % inf
|
|
assert_equal " Inf", "% 3f" % inf
|
|
assert_equal " Inf", "% 4f" % inf
|
|
assert_equal " Inf", "% 5f" % inf
|
|
end
|
|
|
|
assert('String#% with nan') do
|
|
skip unless Object.const_defined?(:Float)
|
|
nan = Float::NAN
|
|
|
|
assert_equal "NaN", "%f" % nan
|
|
assert_equal "NaN", "%2f" % nan
|
|
assert_equal "NaN", "%3f" % nan
|
|
assert_equal " NaN", "%4f" % nan
|
|
assert_equal " NaN", "%5f" % nan
|
|
|
|
assert_equal "+NaN", "%+f" % nan
|
|
assert_equal "+NaN", "%+2f" % nan
|
|
assert_equal "+NaN", "%+3f" % nan
|
|
assert_equal "+NaN", "%+4f" % nan
|
|
assert_equal " +NaN", "%+5f" % nan
|
|
|
|
assert_equal "NaN", "%-f" % nan
|
|
assert_equal "NaN", "%-2f" % nan
|
|
assert_equal "NaN", "%-3f" % nan
|
|
assert_equal "NaN ", "%-4f" % nan
|
|
assert_equal "NaN ", "%-5f" % nan
|
|
|
|
assert_equal " NaN", "% f" % nan
|
|
assert_equal " NaN", "% 2f" % nan
|
|
assert_equal " NaN", "% 3f" % nan
|
|
assert_equal " NaN", "% 4f" % nan
|
|
assert_equal " NaN", "% 5f" % nan
|
|
end
|
|
|
|
assert("String#% %b") do
|
|
assert_equal("..10115", "%0b5" % -5)
|
|
end
|
|
|
|
assert("String#% %d") do
|
|
assert_equal(" 10", "%4d" % 10)
|
|
assert_equal("1000", "%4d" % 1000)
|
|
assert_equal("10000", "%4d" % 10000)
|
|
end
|
|
|
|
assert("String#% invalid format") do
|
|
assert_raise ArgumentError do
|
|
"%?" % ""
|
|
end
|
|
end
|
|
|
|
assert("sprintf %g with high precision") do
|
|
# Regression test: precision values larger than double's significand
|
|
# used to cause out-of-bounds reads in fp_uscale's fixed_width().
|
|
assert_equal "7", "%.*g" % [51, 7]
|
|
assert_equal "7.5", "%.*g" % [51, 7.5]
|
|
assert_equal "7", "%.51g" % 7.0
|
|
assert_equal "7." + "0" * 50, "%#.51g" % 7.0
|
|
assert_equal "7", "%.*g" % [1000, 7.0]
|
|
end
|
|
|
|
assert("sprintf with to_s mutating format string") do
|
|
# The to_s callback must not be able to invalidate sprintf's internal
|
|
# iteration pointers by mutating the format string.
|
|
fmt = "%s" + "B" * 200
|
|
mutator = Object.new
|
|
$sprintf_test_fmt = fmt
|
|
def mutator.to_s
|
|
$sprintf_test_fmt.replace("Z")
|
|
"ok"
|
|
end
|
|
result = sprintf(fmt, mutator)
|
|
assert_equal 202, result.length
|
|
assert_equal "ok", result[0, 2]
|
|
assert_equal "B" * 200, result[2..]
|
|
end
|