From bdc394abea44a97ac02ccfa993fdf0409f391926 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADctor=20Zamanillo?= Date: Fri, 25 Sep 2020 17:54:10 +0200 Subject: [PATCH] Fixed govet issues --- common/httputilz/httputilz.go | 4 ++-- common/httpx/httpx.go | 6 +++--- common/stringz/stringz.go | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/common/httputilz/httputilz.go b/common/httputilz/httputilz.go index a191446..a1db8de 100644 --- a/common/httputilz/httputilz.go +++ b/common/httputilz/httputilz.go @@ -51,10 +51,10 @@ func ParseRequest(req string) (method string, path string, headers map[string]st method = parts[0] for { - line, err := reader.ReadString('\n') + line, readErr := reader.ReadString('\n') line = strings.TrimSpace(line) - if err != nil || line == "" { + if readErr != nil || line == "" { break } diff --git a/common/httpx/httpx.go b/common/httpx/httpx.go index ad31cd5..f8de90f 100644 --- a/common/httpx/httpx.go +++ b/common/httpx/httpx.go @@ -77,9 +77,9 @@ func New(options *Options) (*HTTPX, error) { } if httpx.Options.HttpProxy != "" { - proxyURL, err := url.Parse(httpx.Options.HttpProxy) - if err != nil { - return nil, err + proxyURL, parseErr := url.Parse(httpx.Options.HttpProxy) + if parseErr != nil { + return nil, parseErr } transport.Proxy = http.ProxyURL(proxyURL) } diff --git a/common/stringz/stringz.go b/common/stringz/stringz.go index 5199fa8..adaa0a3 100644 --- a/common/stringz/stringz.go +++ b/common/stringz/stringz.go @@ -21,8 +21,8 @@ func StringToSliceInt(s string) ([]int, error) { return r, nil } for _, v := range strings.Split(s, ",") { - v := strings.TrimSpace(v) - if i, err := strconv.Atoi(v); err == nil { + vTrim := strings.TrimSpace(v) + if i, err := strconv.Atoi(vTrim); err == nil { r = append(r, i) } else { return r, err