Chore - Code cleanup in workflows (#1768)

* Change file extension to .yml for consistency

* Move permissions for clarity and consistency

* Change compat-checks action from @master to @v1

The action should be pinned to a stable ref such as @v1, consistent with
the documentation and how other PD projects reference it.

* Fix indentations and whitespaces in workflows

.github/release.yml

@@ -8,10 +8,10 @@ changelog:
         - "Type: Enhancement"
     - title: 🐞 Bug Fixes
       labels:
-        - "Type: Bug" 
+        - "Type: Bug"
     - title: 🔨 Maintenance
       labels:
-        - "Type: Maintenance" 
+        - "Type: Maintenance"
     - title: Other Changes
       labels:
         - "*"

.github/workflows/codeql-analysis.yml

@@ -7,14 +7,15 @@ on:
       - '**.go'
       - '**.mod'
 
+permissions:
+  actions: read
+  contents: read
+  security-events: write
+
 jobs:
   analyze:
     name: Analyze
     runs-on: ubuntu-latest
-    permissions:
-      actions: read
-      contents: read
-      security-events: write
 
     strategy:
       fail-fast: false
@@ -23,17 +24,17 @@ jobs:
         # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ]
 
     steps:
-    - name: Checkout repository
+      - name: Checkout repository
-      uses: actions/checkout@v6
+        uses: actions/checkout@v6
 
-    # Initializes the CodeQL tools for scanning.
+      # Initializes the CodeQL tools for scanning.
-    - name: Initialize CodeQL
+      - name: Initialize CodeQL
-      uses: github/codeql-action/init@v4
+        uses: github/codeql-action/init@v4
-      with:
+        with:
-        languages: ${{ matrix.language }}
+          languages: ${{ matrix.language }}
 
-    - name: Autobuild
+      - name: Autobuild
-      uses: github/codeql-action/autobuild@v4
+        uses: github/codeql-action/autobuild@v4
 
-    - name: Perform CodeQL Analysis
+      - name: Perform CodeQL Analysis
-      uses: github/codeql-action/analyze@v4
+        uses: github/codeql-action/analyze@v4

.github/workflows/compat-checks.yml

@@ -6,14 +6,15 @@ on:
     branches:
       - dev
 
+permissions:
+  contents: write
+
 jobs:
   check:
     if: github.actor == 'dependabot[bot]'
     runs-on: ubuntu-latest
-    permissions:
-      contents: write
     steps:
       - uses: actions/checkout@v6
-      - uses: projectdiscovery/actions/setup/go/compat-checks@master
+      - uses: projectdiscovery/actions/setup/go/compat-checks@v1
         with:
           go-version-file: go.mod

.github/workflows/release-binary.yml

@@ -12,7 +12,7 @@ jobs:
     steps:
       - name: "Check out code"
         uses: actions/checkout@v6
-        with: 
+        with:
           fetch-depth: 0
 
       - uses: projectdiscovery/actions/setup/go@v1

.github/workflows/release-test.yml

@@ -13,7 +13,7 @@ jobs:
     steps:
       - name: "Check out code"
         uses: actions/checkout@v6
-        with: 
+        with:
           fetch-depth: 0
 
       - uses: projectdiscovery/actions/setup/go@v1

.goreleaser.yml

@@ -5,31 +5,31 @@ before:
     - go mod tidy
 
 builds:
-- env:
+  - env:
-  - CGO_ENABLED=0
+      - CGO_ENABLED=0
-  goos:
+    goos:
-    - windows
+      - windows
-    - linux
+      - linux
-    - darwin
+      - darwin
-  goarch:
+    goarch:
-    - amd64
+      - amd64
-    - '386'
+      - '386'
-    - arm
+      - arm
-    - arm64
+      - arm64
 
-  ignore:
+    ignore:
-    - goos: darwin
+      - goos: darwin
-      goarch: '386'
+        goarch: '386'
-    - goos: windows
+      - goos: windows
-      goarch: 'arm'
+        goarch: 'arm'
 
-  binary: '{{ .ProjectName }}'
+    binary: '{{ .ProjectName }}'
-  main: cmd/subfinder/main.go
+    main: cmd/subfinder/main.go
 
 archives:
-- formats:
+  - formats:
-    - zip
+      - zip
-  name_template: '{{ .ProjectName }}_{{ .Version }}_{{ if eq .Os "darwin" }}macOS{{ else }}{{ .Os }}{{ end }}_{{ .Arch }}'
+    name_template: '{{ .ProjectName }}_{{ .Version }}_{{ if eq .Os "darwin" }}macOS{{ else }}{{ .Os }}{{ end }}_{{ .Arch }}'
 
 checksum:
   algorithm: sha256