diff --git a/include/revng/DataLayoutAnalysis/DLATypeSystem.h b/include/revng/DataLayoutAnalysis/DLATypeSystem.h index e221688af..2957e45d6 100644 --- a/include/revng/DataLayoutAnalysis/DLATypeSystem.h +++ b/include/revng/DataLayoutAnalysis/DLATypeSystem.h @@ -152,7 +152,7 @@ public: std::strong_ordering operator<=>(const TypeLinkTag &Other) const = default; friend void - writeToLog(Logger &L, const dla::TypeLinkTag &T, int /* Ignore */); + writeToLog(Logger &L, const dla::TypeLinkTag &T, int /* Ignore */); }; // end class TypeLinkTag diff --git a/include/revng/EarlyFunctionAnalysis/AnalyzeRegisterUsage.h b/include/revng/EarlyFunctionAnalysis/AnalyzeRegisterUsage.h index e458d2416..b01601d71 100644 --- a/include/revng/EarlyFunctionAnalysis/AnalyzeRegisterUsage.h +++ b/include/revng/EarlyFunctionAnalysis/AnalyzeRegisterUsage.h @@ -68,8 +68,7 @@ public: void dump(T &Output, const char *Prefix = "") const; }; -extern template void RUAResults::dump>(Logger &, - const char *) const; +extern template void RUAResults::dump(Logger &, const char *) const; RUAResults analyzeRegisterUsage(llvm::Function *F, const GeneratedCodeBasicInfo &, diff --git a/include/revng/Lift/CSVOffsets.h b/include/revng/Lift/CSVOffsets.h index c84fbd8bf..95e76dd31 100644 --- a/include/revng/Lift/CSVOffsets.h +++ b/include/revng/Lift/CSVOffsets.h @@ -8,7 +8,6 @@ #include "revng/Support/Assert.h" -template class Logger; /// Different types of accesses to the CPU State Variables (CSVs), with a set of @@ -72,7 +71,7 @@ public: } public: - friend void writeToLog(Logger &L, const CSVOffsets &O, int /*Ignore*/); + friend void writeToLog(Logger &L, const CSVOffsets &O, int /*Ignore*/); private: explicit operator Kind() const { return OffsetKind; } diff --git a/include/revng/MFP/MFP.h b/include/revng/MFP/MFP.h index 589cc64c4..fdaf5e2be 100644 --- a/include/revng/MFP/MFP.h +++ b/include/revng/MFP/MFP.h @@ -22,7 +22,7 @@ namespace MFP { -inline Logger<> NullLogger(""); +inline Logger NullLogger(""); template void dump(llvm::raw_ostream &Stream, unsigned Indent, const T &Element) { @@ -87,7 +87,7 @@ getMaximalFixedPoint(const MFIType &MFI, typename MFIType::LatticeElement ExtremalValue, const std::vector &ExtremalLabels, const std::vector &InitialNodes, - Logger<> &Logger = NullLogger) { + Logger &Logger = NullLogger) { using Label = typename MFIType::Label; using LatticeElement = typename MFIType::LatticeElement; @@ -111,13 +111,13 @@ getMaximalFixedPoint(const MFIType &MFI, if (Logger.isEnabled()) { revng_log(Logger, "Initializing extremal labels"); - LoggerIndent<> Indent(Logger); + LoggerIndent Indent(Logger); Logger << "Extremal value:\n"; MFP::dump(*Logger.getAsLLVMStream(), 1, ExtremalValue); Logger << DoLog; Logger << "Extremal labels:" << DoLog; - LoggerIndent<> Indent2(Logger); + LoggerIndent Indent2(Logger); for (Label ExtremalLabel : ExtremalLabels) { MFP::dumpLabel(*Logger.getAsLLVMStream(), ExtremalLabel); Logger << DoLog; @@ -129,13 +129,13 @@ getMaximalFixedPoint(const MFIType &MFI, if (Logger.isEnabled()) { revng_log(Logger, "Initializing initial nodes"); - LoggerIndent<> Indent(Logger); + LoggerIndent Indent(Logger); Logger << "Initial value:\n"; MFP::dump(*Logger.getAsLLVMStream(), 1, InitialValue); Logger << DoLog; Logger << "Initial labels:" << DoLog; - LoggerIndent<> Indent2(Logger); + LoggerIndent Indent2(Logger); for (Label InitialNode : InitialNodes) { MFP::dumpLabel(*Logger.getAsLLVMStream(), InitialNode); Logger << DoLog; @@ -163,7 +163,7 @@ getMaximalFixedPoint(const MFIType &MFI, // Step 2 iterations revng_log(Logger, "Starting the iterations"); - LoggerIndent<> Indent(Logger); + LoggerIndent Indent(Logger); unsigned IterationIndex = 0; while (not Worklist.empty()) { @@ -180,7 +180,7 @@ getMaximalFixedPoint(const MFIType &MFI, Logger << DoLog; } - LoggerIndent<> Indent(Logger); + LoggerIndent Indent(Logger); if (Logger.isEnabled()) { Logger << "Initial value:\n"; @@ -199,7 +199,7 @@ getMaximalFixedPoint(const MFIType &MFI, Logger.unindent(); if (Logger.isEnabled()) { - LoggerIndent<> Indent(Logger); + LoggerIndent Indent(Logger); Logger << "New final value:\n"; MFP::dump(*Logger.getAsLLVMStream(), 1, New); Logger << DoLog; @@ -212,7 +212,7 @@ getMaximalFixedPoint(const MFIType &MFI, // Enqueue successors that need to be recomputed revng_log(Logger, "Processing successors:"); - LoggerIndent<> Indent2(Logger); + LoggerIndent Indent2(Logger); for (Label Successor : successors(Start)) { auto &SuccessorResults = AnalysisResult.at(Successor); @@ -222,12 +222,12 @@ getMaximalFixedPoint(const MFIType &MFI, Logger << DoLog; Logger << "Initial value:\n"; - LoggerIndent<> Indent(Logger); + LoggerIndent Indent(Logger); Logger << DoLog; MFP::dump(*Logger.getAsLLVMStream(), 1, SuccessorResults.InValue); Logger << DoLog; } - LoggerIndent<> Indent(Logger); + LoggerIndent Indent(Logger); if (not MFI.isLessOrEqual(LabelAnalysis.OutValue, SuccessorResults.InValue)) { @@ -265,7 +265,7 @@ getMaximalFixedPoint(const MFI &Instance, typename MFI::LatticeElement InitialValue, typename MFI::LatticeElement ExtremalValue, const std::vector &ExtremalLabels, - Logger<> &Logger = NullLogger) { + Logger &Logger = NullLogger) { using Label = typename MFI::Label; std::vector