// // Copyright (c) rev.ng Labs Srl. See LICENSE.md for details. // #include #include "llvm/ADT/EquivalenceClasses.h" #include "llvm/ADT/GraphTraits.h" #include "llvm/ADT/STLExtras.h" #include "llvm/ADT/SetVector.h" #include "llvm/ADT/SmallPtrSet.h" #include "llvm/ADT/SmallVector.h" #include "llvm/IR/CFG.h" #include "revng/ADT/GenericGraph.h" #include "revng/ADT/RecursiveCoroutine.h" #include "revng-c/DataLayoutAnalysis/DLATypeSystem.h" #include "DLAStep.h" using namespace llvm; static Logger<> Log("dla-merge-pointees-of-ptr-union"); namespace dla { using LTSN = LayoutTypeSystemNode; using NeighborsConstIterator = LTSN::NeighborsSet::const_iterator; static bool hasOutgoingPointerEdge(const LayoutTypeSystemNode *N) { using CPointerT = EdgeFilteredGraph; using PointerGraph = llvm::GraphTraits; auto It = PointerGraph::child_begin(N); auto End = PointerGraph::child_end(N); return It != End; }; static bool isWellFormedPointer(const LTSN *Pointer) { return Pointer->Successors.size() == 1 and hasOutgoingPointerEdge(Pointer); } static LTSN *getPointee(LTSN *Pointer) { revng_assert(isWellFormedPointer(Pointer)); return Pointer->Successors.begin()->first; } bool MergePointeesOfPointerUnion::runOnTypeSystem(LayoutTypeSystem &TS) { bool Changed = false; revng_log(Log, "MergePointeesOfPointerUnion"); LoggerIndent StepIndent{ Log }; if (VerifyLog.isEnabled()) revng_assert(TS.verifyDAG() and TS.verifyLeafs()); // Initialize a vector of nodes before iterating. // The algorithm iterates over all nodes in the graph, but it can end merging // the current node (and a bunch of others) with another one, and that would // invalidate the iterators if we iterate on llvm::nodes(&TS) directly. std::vector Nodes{ llvm::nodes(&TS).begin(), llvm::nodes(&TS).end() }; std::unordered_set Erased; // Index based iteration, since we can add more nodes and they are enqueued // for analysis at the end of Nodes. for (size_t Index = 0; Index < Nodes.size(); ++Index) { LTSN *Node = Nodes.at(Index); revng_log(Log, "Analyzing Node: " << Node->ID); LoggerIndent Indent{ Log }; if (Erased.contains(Node)) { revng_log(Log, "merged by a previous iteration"); continue; } if (isInstanceLeaf(Node)) { revng_log(Log, "no instance children"); continue; } llvm::EquivalenceClasses ToMerge; auto ChildEnd = Node->Successors.end(); for (auto AChildIt = Node->Successors.begin(); AChildIt != ChildEnd; ++AChildIt) { const auto &AEdge = *AChildIt; if (not isInstanceEdge(AEdge)) continue; const auto &[APointer, ATag] = AEdge; if (not hasOutgoingPointerEdge(APointer)) continue; revng_assert(isWellFormedPointer(APointer)); for (auto BChildIt = std::next(AChildIt); BChildIt != ChildEnd; ++BChildIt) { const auto &BEdge = *BChildIt; const auto &[BPointer, BTag] = BEdge; if (ATag != BTag) continue; if (not hasOutgoingPointerEdge(BPointer)) continue; revng_assert(isWellFormedPointer(BPointer)); // Here we're sure that A and B are connected to Node with the same kind // of instance edge. And that they are both pointer nodes. revng_log(Log, "has a pair of instance children at the same offset that are " "pointer nodes:"); revng_log(Log, "A: " << APointer->ID << ", B:" << BPointer->ID); revng_assert(APointer->Successors.size() == 1, std::to_string(APointer->ID).c_str()); revng_assert(BPointer->Successors.size() == 1, std::to_string(BPointer->ID).c_str()); ToMerge.unionSets(APointer, BPointer); } } if (not ToMerge.empty()) { revng_log(Log, "Merging children"); LoggerIndent MoreIndent{ Log }; // Iterate over all of the equivalence sets. for (auto I = ToMerge.begin(), E = ToMerge.end(); I != E; ++I) { // Ignore non-leader sets. if (not I->isLeader()) continue; // Loop over members in this set to select the node that we want to // merge the others into. auto Pointers = llvm::make_range(ToMerge.member_begin(I), ToMerge.member_end()); if (Log.isEnabled()) { revng_log(Log, "Preparing to merge pointees:"); LoggerIndent EvenMoreIndent{ Log }; for (LayoutTypeSystemNode *N : Pointers) revng_log(Log, N->ID << " with pointee " << getPointee(N)->ID << " (size: " << getPointee(N)->Size << ")"); } llvm::SmallSetVector UniquedScalars; llvm::SmallPtrSet PointersToScalars; llvm::SmallSetVector UniquedAggregates; llvm::SmallPtrSet PointersToAggregates; for (LayoutTypeSystemNode *Pointer : Pointers) { if (getPointee(Pointer)->NonScalar) continue; LTSN *Pointee = getPointee(Pointer); if (Pointee->Successors.empty() or hasOutgoingPointerEdge(Pointee)) { revng_assert(not hasOutgoingPointerEdge(Pointee) or isWellFormedPointer(Pointee)); PointersToScalars.insert(Pointer); UniquedScalars.insert(Pointee); } else { PointersToAggregates.insert(Pointer); UniquedAggregates.insert(Pointee); } } // Sort scalars and aggregates so that the first is the node with the // lowerst ID among the nodes with largest size. llvm::SmallVector Scalars = UniquedScalars.takeVector(); llvm::SmallVector Aggregates = UniquedAggregates.takeVector(); const auto Ordering = [](const LTSN *LHS, const LTSN *RHS) { auto LSize = LHS->Size; auto RSize = RHS->Size; if (LSize > RSize) return true; if (LSize == RSize) return LHS->ID < RHS->ID; return false; }; llvm::sort(Scalars, Ordering); llvm::sort(Aggregates, Ordering); // Merge all the scalars together. LTSN *MergedScalar = nullptr; if (not Scalars.empty()) { if (Log.isEnabled()) { revng_log(Log, "merging Scalars:"); LoggerIndent MoreMoreIndent{ Log }; for (const LTSN *N : Scalars) revng_log(Log, N->ID); } TS.mergeNodes(Scalars); Erased.insert(std::next(Scalars.begin()), Scalars.end()); MergedScalar = Scalars.front(); // Check if we merged more than one scalar that also was a pointer. // In that case we have to create a new union of their pointees, // enqueue it for further analysis llvm::SmallVector PointerEdges; { LTSN::NeighborIterator ChildIt = MergedScalar->Successors.begin(); LTSN::NeighborIterator ChildEnd = MergedScalar->Successors.end(); for (; ChildIt != ChildEnd; ++ChildIt) if (isPointerEdge(*ChildIt)) PointerEdges.push_back(ChildIt); revng_assert(PointerEdges.empty() or MergedScalar->Size == PointerSize); } if (PointerEdges.size() > 1) { revng_log(Log, "Merged scalar is a union of pointers: " << MergedScalar->ID); for (LTSN::NeighborIterator &PointerEdgeIt : PointerEdges) { LTSN *NewPointer = TS.createArtificialLayoutType(); NewPointer->Size = PointerSize; TS.moveEdgeSource(MergedScalar, NewPointer, PointerEdgeIt, 0); TS.addInstanceLink(MergedScalar, NewPointer, OffsetExpression{ 0 }); } Nodes.push_back(MergedScalar); } } const auto GetNonScalarPointee = [](LTSN *Pointer, bool AllowRepeats) { revng_assert(not AllowRepeats); LTSN *Pointee = getPointee(Pointer); return Pointee->NonScalar ? Pointee : nullptr; }; LTSN *MergedAggregate = llvm::find_singleton(Pointers, GetNonScalarPointee); revng_log(Log, "Unique aggregate to preserve: " << (MergedAggregate ? std::to_string(MergedAggregate->ID) : "none")); if (not Aggregates.empty()) { if (Log.isEnabled()) { revng_log(Log, "merging Aggregates:"); LoggerIndent MoreMoreIndent{ Log }; for (const LTSN *N : Aggregates) revng_log(Log, N->ID); } TS.mergeNodes(Aggregates); Erased.insert(std::next(Aggregates.begin()), Aggregates.end()); if (MergedAggregate) { LTSN *TheAggregate = Aggregates.front(); if (MergedAggregate->Size < TheAggregate->Size) { // If MergedAggregate's Size is smaller than the others, merging // them would enlarge the NonScalar, which is forbidden. // First, we want all pointers that point to MergedAggregates to // actually start pointing to MergedAggregate. for (LTSN *Pointer : PointersToAggregates) { const auto &[Pointee, PointerTag] = *Pointer->Successors.begin(); revng_assert(Pointee == TheAggregate); auto InverseEdgeIt = Pointee->Predecessors.find({ Pointer, PointerTag }); TS.moveEdgeTarget(Pointee, MergedAggregate, InverseEdgeIt, 0); } // Then we add an instance of the NonScalar MergedAggregate at // offset 0 of TheAggregate TS.addInstanceLink(TheAggregate, MergedAggregate, OffsetExpression{ 0 }); } else { // Otherwise, the size allows to merge TheAggregate directly in // the NonScalar MergedAggregate. TS.mergeNodes({ MergedAggregate, TheAggregate }); Erased.insert(TheAggregate); } } else { MergedAggregate = Aggregates.front(); } } if (MergedAggregate and MergedScalar) { // First, we want all pointers that point to MergedScalar to actually // start pointing to MergedAggregate. for (LTSN *Pointer : PointersToScalars) { const auto &[Pointee, PointerTag] = *Pointer->Successors.begin(); auto InverseEdgeIt = Pointee->Predecessors.find({ Pointer, PointerTag }); TS.moveEdgeTarget(Pointee, MergedAggregate, InverseEdgeIt, 0); } // Second, we want to inject an instance of MergedScalar at offset 0 // inside MergedAggregate. // If MergedAggregate is larger than MergedScalar we're fine. if (MergedAggregate->Size >= MergedScalar->Size) { TS.addInstanceLink(MergedAggregate, MergedScalar, OffsetExpression{ 0 }); } else if (not MergedAggregate->NonScalar) { MergedAggregate->Size = MergedScalar->Size; TS.addInstanceLink(MergedAggregate, MergedScalar, OffsetExpression{ 0 }); } else { revng_abort(); } } } } } return Changed; } } // end namespace dla