mirror of
https://github.com/revng/revng
synced 2026-06-21 14:07:57 +00:00
06733a9f3a
Split the `InlineHelpers` pass into the three phases: - `link-helpers-to-inline` links the missing `revng_inline` helper bodies from the `libtcg-helpers-to-inline-arch` module. - `inline-helpers` inlines, in every function except those tagged `Root` or `Helper`, the calls to `revng_inline` helpers whose critical arguments on the call site are constant. - `delete-helper-bodies` drops from the module the body of every `revng_inline` function, leaving only the declaration. The three passes live in a dedicated `revngInlineHelpers` library (`lib/InlineHelpers/` + `include/revng/InlineHelpers/`), so that libraries which do not depend on `revngFunctionIsolation` can use them without creating cyclic dependencies.
207 lines
6.5 KiB
C++
207 lines
6.5 KiB
C++
//
|
|
// This file is distributed under the MIT License. See LICENSE.md for details.
|
|
//
|
|
|
|
#include <iterator>
|
|
#include <system_error>
|
|
|
|
#include "llvm/ADT/BitVector.h"
|
|
#include "llvm/ADT/SmallVector.h"
|
|
#include "llvm/IR/Instructions.h"
|
|
#include "llvm/Support/CommandLine.h"
|
|
#include "llvm/Support/FileSystem.h"
|
|
#include "llvm/Support/Path.h"
|
|
#include "llvm/Support/raw_ostream.h"
|
|
#include "llvm/Transforms/Utils/Cloning.h"
|
|
|
|
#include "revng/InlineHelpers/InlineHelpers.h"
|
|
#include "revng/Support/CommandLine.h"
|
|
#include "revng/Support/Debug.h"
|
|
#include "revng/Support/IRHelpers.h"
|
|
|
|
using namespace llvm;
|
|
|
|
static Logger Log("inline-helpers");
|
|
|
|
static cl::opt<std::string> DumpBeforeDir("inline-helpers-dump-before-dir",
|
|
cl::desc("Directory in which to "
|
|
"write one `<fn>.ll` file "
|
|
"per Isolated function, "
|
|
"containing the body of "
|
|
"the function right "
|
|
"before inline-helpers "
|
|
"touches it. Created if "
|
|
"absent."),
|
|
cl::init(""),
|
|
cl::cat(MainCategory));
|
|
|
|
static cl::opt<std::string> DumpAfterDir("inline-helpers-dump-after-dir",
|
|
cl::desc("Directory in which to "
|
|
"write one `<fn>.ll` file "
|
|
"per Isolated function, "
|
|
"containing the body of "
|
|
"the function right after "
|
|
"inline-helpers has "
|
|
"finished with it. "
|
|
"Created if absent."),
|
|
cl::init(""),
|
|
cl::cat(MainCategory));
|
|
|
|
// Dump one `<F.name>.ll` file to `Dir`, containing just the body of `F`.
|
|
// Called once per Isolated function per pass invocation, from
|
|
// `InlineHelpers::run(F)`; the user then gets exactly one file per
|
|
// Isolated function, named by it.
|
|
static void dumpFunctionToDir(const Function &F, StringRef Dir) {
|
|
std::error_code EC = sys::fs::create_directories(Dir);
|
|
revng_assert(not EC,
|
|
("inline-helpers: cannot create dump directory: " + EC.message())
|
|
.c_str());
|
|
|
|
SmallString<256> Path(Dir);
|
|
sys::path::append(Path, (F.getName() + ".ll").str());
|
|
|
|
raw_fd_ostream OS(Path, EC, sys::fs::OF_Text);
|
|
revng_assert(not EC,
|
|
("inline-helpers: cannot open dump file: " + EC.message())
|
|
.c_str());
|
|
F.print(OS, nullptr);
|
|
}
|
|
|
|
char InlineHelpersPass::ID = 0;
|
|
|
|
using Register = RegisterPass<InlineHelpersPass>;
|
|
static Register X("inline-helpers", "Inline Helpers Pass", true, true);
|
|
|
|
class InlineHelpers {
|
|
public:
|
|
InlineHelpers() = default;
|
|
|
|
void run(Function *F);
|
|
|
|
private:
|
|
void doInline(CallInst *Call) const;
|
|
bool doInline(Function *F) const;
|
|
CallInst *getCallToInline(Instruction *I) const;
|
|
bool shouldInline(const CallInst *Call) const;
|
|
};
|
|
|
|
bool InlineHelpers::shouldInline(const CallInst *Call) const {
|
|
const Function *Callee = getCalledFunction(Call);
|
|
if (Callee == nullptr)
|
|
return false;
|
|
|
|
if (Callee->getSection() != InlineHelpersSection)
|
|
return false;
|
|
|
|
InliningPolicy P = deserializeInliningPolicy(*Callee);
|
|
const BitVector &Critical = P.CriticalArguments;
|
|
|
|
if (Critical.none()) {
|
|
revng_log(Log, "inline " << Callee->getName() << ": no critical arguments");
|
|
return true;
|
|
}
|
|
|
|
revng_log(Log, "Analyzing arguments of " << Callee->getName());
|
|
LoggerIndent Indent(Log);
|
|
|
|
bool AllConstant = true;
|
|
for (int Index = Critical.find_first(); Index >= 0;
|
|
Index = Critical.find_next(Index)) {
|
|
const bool IsConst = isa<Constant>(Call->getArgOperand(Index));
|
|
if (not IsConst)
|
|
AllConstant = false;
|
|
revng_log(Log,
|
|
"argument " << Index << ": "
|
|
<< (IsConst ? "const" : "NON-CONST"));
|
|
}
|
|
|
|
revng_log(Log, (AllConstant ? "inline" : "skip"));
|
|
return AllConstant;
|
|
}
|
|
|
|
CallInst *InlineHelpers::getCallToInline(Instruction *I) const {
|
|
if (auto *Call = dyn_cast<CallInst>(I)) {
|
|
if (shouldInline(Call)) {
|
|
return Call;
|
|
}
|
|
}
|
|
|
|
return nullptr;
|
|
}
|
|
|
|
void InlineHelpers::doInline(CallInst *Call) const {
|
|
InlineFunctionInfo IFI;
|
|
auto Result = InlineFunction(*Call, IFI, false, nullptr, false);
|
|
revng_assert(Result.isSuccess(), Result.getFailureReason());
|
|
}
|
|
|
|
bool InlineHelpers::doInline(Function *F) const {
|
|
SmallVector<CallInst *, 8> ToInline;
|
|
|
|
for (BasicBlock &BB : *F)
|
|
for (Instruction &I : BB)
|
|
if (auto *Call = getCallToInline(&I))
|
|
ToInline.push_back(Call);
|
|
|
|
for (CallInst *Call : ToInline)
|
|
doInline(Call);
|
|
|
|
return ToInline.size() > 0;
|
|
}
|
|
|
|
static void dropDebugOrPseudoInst(Function *F) {
|
|
SmallVector<Instruction *, 16> ToErase;
|
|
for (BasicBlock &BB : *F) {
|
|
for (Instruction &I : BB) {
|
|
if (I.isDebugOrPseudoInst()) {
|
|
ToErase.push_back(&I);
|
|
}
|
|
}
|
|
}
|
|
|
|
for (Instruction *I : ToErase) {
|
|
I->eraseFromParent();
|
|
}
|
|
}
|
|
|
|
void InlineHelpers::run(Function *F) {
|
|
|
|
if (F->isDeclaration())
|
|
return;
|
|
|
|
revng_log(Log, "Analyzing " << F->getName());
|
|
|
|
// Dump the IR of the function before the inlining takes place
|
|
if (not DumpBeforeDir.empty())
|
|
dumpFunctionToDir(*F, DumpBeforeDir);
|
|
|
|
// `slim-down-helpers-module` already fully inlines helpers, but we might
|
|
// still have wrappers created by `promote-csvs` at runtime that we need to
|
|
// traverse and inline as well.
|
|
while (doInline(F)) {
|
|
}
|
|
dropDebugOrPseudoInst(F);
|
|
|
|
// Dump the IR of the function after inlining has taken place
|
|
if (not DumpAfterDir.empty())
|
|
dumpFunctionToDir(*F, DumpAfterDir);
|
|
}
|
|
|
|
bool InlineHelpersPass::runOnModule(llvm::Module &M) {
|
|
// Inline `revng_inline` helper calls into the `Isolated` functions, where the
|
|
// per-call critical arguments are constant at the call site.
|
|
SmallVector<Function *, 32> Isolated;
|
|
for (Function &F : M)
|
|
if (FunctionTags::Isolated.isTagOf(&F))
|
|
Isolated.push_back(&F);
|
|
|
|
llvm::Task T(Isolated.size(), "Inline helpers");
|
|
for (Function *F : Isolated) {
|
|
T.advance(F->getName());
|
|
InlineHelpers IH;
|
|
IH.run(F);
|
|
}
|
|
|
|
return true;
|
|
}
|