mirror of
https://github.com/revng/revng
synced 2026-06-21 14:07:57 +00:00
28a0fa5b7d
This commit switches the approach with which we run the ABI analyses: we now run them until we reach a fixed point. This enables proper interprocedural propagation of arguments and return values. Basically, we now inject reads before call sites, so that, if a function immediately calls another one, the arguments of the callee are propagated to the caller. This commit also updates the logic with which we propagate function prototypes (and names) to callers. The main advantage of this, is that function wrappers (in particular, PLT entries) now have the same name as the function they wrap.
369 lines
12 KiB
C++
369 lines
12 KiB
C++
//
|
|
// This file is distributed under the MIT License. See LICENSE.md for details.
|
|
//
|
|
|
|
#include "llvm/IR/BasicBlock.h"
|
|
#include "llvm/IR/Function.h"
|
|
#include "llvm/IR/InstIterator.h"
|
|
#include "llvm/IR/Instruction.h"
|
|
#include "llvm/IR/Instructions.h"
|
|
#include "llvm/Support/Casting.h"
|
|
#include "llvm/Support/raw_ostream.h"
|
|
|
|
#include "revng/ABI/RegisterState.h"
|
|
#include "revng/ADT/ZipMapIterator.h"
|
|
#include "revng/EarlyFunctionAnalysis/ABIAnalysis.h"
|
|
#include "revng/EarlyFunctionAnalysis/Common.h"
|
|
#include "revng/Model/Binary.h"
|
|
#include "revng/Support/Assert.h"
|
|
#include "revng/Support/Debug.h"
|
|
#include "revng/Support/IRHelpers.h"
|
|
#include "revng/Support/MetaAddress.h"
|
|
|
|
#include "Analyses.h"
|
|
|
|
using namespace llvm;
|
|
|
|
static Logger<> ABIAnalysesLog("abi-analyses");
|
|
|
|
namespace ABIAnalyses {
|
|
using RegisterState = abi::RegisterState::Values;
|
|
|
|
template void
|
|
ABIAnalyses::ABIAnalysesResults::dump<Logger<true>>(Logger<true> &,
|
|
const char *) const;
|
|
|
|
struct PartialAnalysisResults {
|
|
// Per function analysis
|
|
RegisterStateMap UAOF;
|
|
RegisterStateMap DRAOF;
|
|
|
|
// Per call site analysis
|
|
std::map<std::pair<BasicBlockID, BasicBlock *>, RegisterStateMap> URVOFC;
|
|
std::map<std::pair<BasicBlockID, BasicBlock *>, RegisterStateMap> RAOFC;
|
|
std::map<std::pair<BasicBlockID, BasicBlock *>, RegisterStateMap> DRVOFC;
|
|
|
|
// Per return analysis
|
|
std::map<std::pair<BasicBlockID, BasicBlock *>, RegisterStateMap> URVOF;
|
|
|
|
// Debug methods
|
|
void dump() const debug_function { dump(dbg, ""); }
|
|
|
|
template<typename T>
|
|
void dump(T &Output, const char *Prefix) const;
|
|
};
|
|
|
|
// Print the analysis results
|
|
template<typename T>
|
|
void PartialAnalysisResults::dump(T &Output, const char *Prefix) const {
|
|
Output << Prefix << "UsedArgumentsOfFunction:\n";
|
|
for (auto &[GV, State] : UAOF) {
|
|
Output << Prefix << " " << GV->getName().str() << " = "
|
|
<< abi::RegisterState::getName(State).str() << '\n';
|
|
}
|
|
|
|
Output << Prefix << "DeadRegisterArgumentsOfFunction:\n";
|
|
for (auto &[GV, State] : DRAOF) {
|
|
Output << Prefix << " " << GV->getName().str() << " = "
|
|
<< abi::RegisterState::getName(State).str() << '\n';
|
|
}
|
|
|
|
Output << Prefix << "UsedReturnValuesOfFunctionCall:\n";
|
|
for (auto &[Key, StateMap] : URVOFC) {
|
|
Output << Prefix << " " << getName(Key.second) << '\n';
|
|
for (auto &[GV, State] : StateMap) {
|
|
Output << Prefix << " " << GV->getName().str() << " = "
|
|
<< abi::RegisterState::getName(State).str() << '\n';
|
|
}
|
|
}
|
|
|
|
Output << Prefix << "RegisterArgumentsOfFunctionCall:\n";
|
|
for (auto &[Key, StateMap] : RAOFC) {
|
|
Output << Prefix << " " << getName(Key.second) << '\n';
|
|
for (auto &[GV, State] : StateMap) {
|
|
Output << Prefix << " " << GV->getName().str() << " = "
|
|
<< abi::RegisterState::getName(State).str() << '\n';
|
|
}
|
|
}
|
|
|
|
Output << Prefix << "DeadReturnValuesOfFunctionCall:\n";
|
|
for (auto &[Key, StateMap] : DRVOFC) {
|
|
Output << Prefix << " " << getName(Key.second) << '\n';
|
|
for (auto &[GV, State] : StateMap) {
|
|
Output << Prefix << " " << GV->getName().str() << " = "
|
|
<< abi::RegisterState::getName(State).str() << '\n';
|
|
}
|
|
}
|
|
|
|
Output << Prefix << "UsedReturnValuesOfFunction:\n";
|
|
for (auto &[Key, StateMap] : URVOF) {
|
|
Output << Prefix << " " << Key.second->getName().str() << '\n';
|
|
for (auto &[GV, State] : StateMap) {
|
|
Output << Prefix << " " << GV->getName().str() << " = "
|
|
<< abi::RegisterState::getName(State).str() << '\n';
|
|
}
|
|
}
|
|
}
|
|
|
|
RegisterState combine(RegisterState LH, RegisterState RH) {
|
|
switch (LH) {
|
|
case RegisterState::Yes:
|
|
switch (RH) {
|
|
case RegisterState::Yes:
|
|
case RegisterState::YesOrDead:
|
|
case RegisterState::Maybe:
|
|
return RegisterState::Yes;
|
|
case RegisterState::No:
|
|
case RegisterState::NoOrDead:
|
|
case RegisterState::Dead:
|
|
case RegisterState::Contradiction:
|
|
return RegisterState::Contradiction;
|
|
case RegisterState::Count:
|
|
case RegisterState::Invalid:
|
|
revng_abort();
|
|
}
|
|
break;
|
|
|
|
case RegisterState::YesOrDead:
|
|
switch (RH) {
|
|
case RegisterState::Yes:
|
|
return RegisterState::Yes;
|
|
case RegisterState::Maybe:
|
|
case RegisterState::YesOrDead:
|
|
return RegisterState::YesOrDead;
|
|
case RegisterState::Dead:
|
|
case RegisterState::NoOrDead:
|
|
return RegisterState::Dead;
|
|
case RegisterState::No:
|
|
case RegisterState::Contradiction:
|
|
return RegisterState::Contradiction;
|
|
case RegisterState::Count:
|
|
case RegisterState::Invalid:
|
|
revng_abort();
|
|
}
|
|
break;
|
|
|
|
case RegisterState::No:
|
|
switch (RH) {
|
|
case RegisterState::No:
|
|
case RegisterState::NoOrDead:
|
|
case RegisterState::Maybe:
|
|
return RegisterState::No;
|
|
case RegisterState::Yes:
|
|
case RegisterState::YesOrDead:
|
|
case RegisterState::Dead:
|
|
case RegisterState::Contradiction:
|
|
return RegisterState::Contradiction;
|
|
case RegisterState::Count:
|
|
case RegisterState::Invalid:
|
|
revng_abort();
|
|
}
|
|
break;
|
|
|
|
case RegisterState::NoOrDead:
|
|
switch (RH) {
|
|
case RegisterState::No:
|
|
return RegisterState::No;
|
|
case RegisterState::Maybe:
|
|
case RegisterState::NoOrDead:
|
|
return RegisterState::NoOrDead;
|
|
case RegisterState::Dead:
|
|
case RegisterState::YesOrDead:
|
|
return RegisterState::Dead;
|
|
case RegisterState::Yes:
|
|
case RegisterState::Contradiction:
|
|
return RegisterState::Contradiction;
|
|
case RegisterState::Count:
|
|
case RegisterState::Invalid:
|
|
revng_abort();
|
|
}
|
|
break;
|
|
|
|
case RegisterState::Dead:
|
|
switch (RH) {
|
|
case RegisterState::Dead:
|
|
case RegisterState::Maybe:
|
|
case RegisterState::NoOrDead:
|
|
case RegisterState::YesOrDead:
|
|
return RegisterState::Dead;
|
|
case RegisterState::No:
|
|
case RegisterState::Yes:
|
|
case RegisterState::Contradiction:
|
|
return RegisterState::Contradiction;
|
|
case RegisterState::Count:
|
|
case RegisterState::Invalid:
|
|
revng_abort();
|
|
}
|
|
break;
|
|
|
|
case RegisterState::Maybe:
|
|
return RH;
|
|
|
|
case RegisterState::Contradiction:
|
|
return RegisterState::Contradiction;
|
|
|
|
case RegisterState::Count:
|
|
case RegisterState::Invalid:
|
|
revng_abort();
|
|
}
|
|
}
|
|
|
|
void finalizeReturnValues(ABIAnalysesResults &ABIResults) {
|
|
for (auto &[PC, RSMap] : ABIResults.ReturnValuesRegisters) {
|
|
for (auto &[CSV, RS] : RSMap) {
|
|
if (!ABIResults.FinalReturnValuesRegisters.contains(CSV))
|
|
ABIResults.FinalReturnValuesRegisters[CSV] = RegisterState::Maybe;
|
|
|
|
ABIResults.FinalReturnValuesRegisters
|
|
[CSV] = combine(ABIResults.FinalReturnValuesRegisters[CSV], RS);
|
|
}
|
|
}
|
|
}
|
|
|
|
// Run the ABI analyses on the outlined function F. This function must have all
|
|
// the original function calls replaced with a basic block starting with a call
|
|
// to `precall_hook` followed by a summary of the side effects of the function
|
|
// followed by a call to `postcall_hook` and a basic block terminating
|
|
// instruction.
|
|
ABIAnalysesResults analyzeOutlinedFunction(Function *F,
|
|
const GeneratedCodeBasicInfo &GCBI,
|
|
Function *PreCallSiteHook,
|
|
Function *PostCallSiteHook,
|
|
Function *RetHook) {
|
|
namespace UAOF = UsedArgumentsOfFunction;
|
|
namespace DRAOF = DeadRegisterArgumentsOfFunction;
|
|
namespace RAOFC = RegisterArgumentsOfFunctionCall;
|
|
namespace URVOFC = UsedReturnValuesOfFunctionCall;
|
|
namespace DRVOFC = DeadReturnValuesOfFunctionCall;
|
|
namespace URVOF = UsedReturnValuesOfFunction;
|
|
|
|
ABIAnalysesResults FinalResults;
|
|
PartialAnalysisResults Results;
|
|
|
|
// Initial population of partial results
|
|
// TODO: merge the following analyses in a single one
|
|
Results.UAOF = UAOF::analyze(&F->getEntryBlock(), GCBI);
|
|
Results.DRAOF = DRAOF::analyze(&F->getEntryBlock(), GCBI);
|
|
for (auto &I : instructions(F)) {
|
|
BasicBlock *BB = I.getParent();
|
|
|
|
if (auto *Call = dyn_cast<CallInst>(&I)) {
|
|
BasicBlockID PC;
|
|
if (isCallTo(Call, PreCallSiteHook) || isCallTo(Call, PostCallSiteHook)
|
|
|| isCallTo(Call, RetHook)) {
|
|
PC = BasicBlockID::fromValue(Call->getArgOperand(0));
|
|
revng_assert(PC.isValid());
|
|
}
|
|
|
|
if (isCallTo(Call, PreCallSiteHook)) {
|
|
// Ensure it's the first instruction in the basic block
|
|
revng_assert(&*BB->begin() == &I);
|
|
|
|
Results.RAOFC[{ PC, BB }] = RAOFC::analyze(BB, GCBI);
|
|
|
|
// Register address of the callee
|
|
auto &CallSite = FinalResults.CallSites[PC];
|
|
CallSite.CalleeAddress = MetaAddress::fromValue(Call->getArgOperand(1));
|
|
} else if (isCallTo(Call, PostCallSiteHook)) {
|
|
// Ensure it's the last instruction in the basic block
|
|
revng_assert(&*BB->getTerminator()->getPrevNode() == &I);
|
|
|
|
// TODO: merge the following analyses in a single one
|
|
Results.URVOFC[{ PC, BB }] = URVOFC::analyze(BB, GCBI);
|
|
Results.DRVOFC[{ PC, BB }] = DRVOFC::analyze(BB, GCBI);
|
|
} else if (isCallTo(Call, RetHook)) {
|
|
Results.URVOF[{ PC, BB }] = URVOF::analyze(BB, GCBI);
|
|
}
|
|
}
|
|
}
|
|
|
|
if (ABIAnalysesLog.isEnabled()) {
|
|
ABIAnalysesLog << "Dumping ABIAnalyses results for function "
|
|
<< F->getName() << ":\n";
|
|
Results.dump(ABIAnalysesLog, " ");
|
|
ABIAnalysesLog << DoLog;
|
|
}
|
|
|
|
// Finalize results. Combine UAOF and DRAOF.
|
|
for (auto &[Left, Right] : zipmap_range(Results.UAOF, Results.DRAOF)) {
|
|
auto *CSV = Left == nullptr ? Right->first : Left->first;
|
|
RegisterState LV = Left == nullptr ? RegisterState::Maybe : Left->second;
|
|
RegisterState RV = Right == nullptr ? RegisterState::Maybe : Right->second;
|
|
FinalResults.ArgumentsRegisters[CSV] = combine(LV, RV);
|
|
}
|
|
|
|
// Add RAOFC.
|
|
for (auto &[Key, RSMap] : Results.RAOFC) {
|
|
BasicBlockID PC = Key.first;
|
|
revng_assert(PC.isValid());
|
|
for (auto &[CSV, RS] : RSMap)
|
|
FinalResults.CallSites[PC].ArgumentsRegisters[CSV] = RS;
|
|
}
|
|
|
|
// Combine URVOFC and DRVOFC.
|
|
for (auto &[Key, _] : Results.URVOFC) {
|
|
auto PC = Key.first;
|
|
for (auto &[Left, Right] :
|
|
zipmap_range(Results.URVOFC[Key], Results.DRVOFC[Key])) {
|
|
auto *CSV = Left == nullptr ? Right->first : Left->first;
|
|
RegisterState LV = Left == nullptr ? RegisterState::Maybe : Left->second;
|
|
RegisterState RV = Right == nullptr ? RegisterState::Maybe :
|
|
Right->second;
|
|
FinalResults.CallSites[PC].ReturnValuesRegisters[CSV] = combine(LV, RV);
|
|
}
|
|
}
|
|
|
|
// Add URVOF.
|
|
for (auto &[Key, RSMap] : Results.URVOF) {
|
|
auto PC = Key.first;
|
|
for (auto &[CSV, RS] : RSMap)
|
|
FinalResults.ReturnValuesRegisters[PC][CSV] = RS;
|
|
}
|
|
|
|
return FinalResults;
|
|
}
|
|
|
|
template<typename T>
|
|
void ABIAnalysesResults::dump(T &Output, const char *Prefix) const {
|
|
Output << Prefix << "Arguments:\n";
|
|
for (auto &[GV, State] : ArgumentsRegisters) {
|
|
Output << Prefix << " " << GV->getName().str() << " = "
|
|
<< abi::RegisterState::getName(State).str() << '\n';
|
|
}
|
|
|
|
Output << Prefix << "Call site:\n";
|
|
for (auto &[PC, StateMap] : CallSites) {
|
|
Output << Prefix << " Call in basic block " << PC.toString() << '\n';
|
|
Output << Prefix << " "
|
|
<< " "
|
|
<< "Arguments:\n";
|
|
for (auto &[GV, State] : StateMap.ArgumentsRegisters) {
|
|
Output << Prefix << " " << GV->getName().str() << " = "
|
|
<< abi::RegisterState::getName(State).str() << '\n';
|
|
}
|
|
Output << Prefix << " "
|
|
<< " "
|
|
<< "Return values:\n";
|
|
for (auto &[GV, State] : StateMap.ReturnValuesRegisters) {
|
|
Output << Prefix << " " << GV->getName().str() << " = "
|
|
<< abi::RegisterState::getName(State).str() << '\n';
|
|
}
|
|
}
|
|
|
|
Output << Prefix << "Return values:\n";
|
|
for (auto &[PC, StateMap] : ReturnValuesRegisters) {
|
|
for (auto &[GV, State] : StateMap) {
|
|
Output << Prefix << " " << GV->getName().str() << " = "
|
|
<< abi::RegisterState::getName(State).str() << '\n';
|
|
}
|
|
}
|
|
|
|
Output << Prefix << "Final Return values:\n";
|
|
for (auto &[GV, State] : FinalReturnValuesRegisters) {
|
|
Output << Prefix << " " << GV->getName().str() << " = "
|
|
<< abi::RegisterState::getName(State).str() << '\n';
|
|
}
|
|
}
|
|
|
|
} // namespace ABIAnalyses
|