Files
revng-revng/lib/FunctionCallIdentification/PruneRetSuccessors.cpp
Alessandro Di Federico f68b7866b3 Introduce BasicBlockID
This commit introduces `BasicBlockID` as the unique identifier for a
`efa::BasicBlock` into the CFG. A `BasicBlockID` is defined by a
`MetaAddress` plus an incremental integer. This enables us to have
multiple instances of the same block in a single function, which is
particularly useful when inlining multiple times the same function.

Apart from this, the commit also does the following:

* It drops representing `MetaAddress`es a `structs` in the IR. This created
  several issues related to ABI. We now represent them as strings.

* It defines more functions in `support.h`, instead of defining prototypes
  by hand in `CodeGenerator.cpp` and the like. Specifically, `unknownPC`
  and `raise_exception_helper`. We also introduce a C "constructor" for
  `PlainMetaAddress`.

* It significantly reduces the API of `GeneratedCodeBasicInfo`, which
  was supposed to be put on a diet since a long time.  Specifically,
  many jump target related methods have been moved to free functions in
  `IRHelpers.h`.  Also `GCBI::getSuccessors` has been pushed into its
  only user, `PruneRetSuccessors`, to prevent further usage of a
  deprecated API. In the future, it would be nice to drop it entirely.

* It introduces `efa::BasicBlock::InlinedFrom`.

* Introduce an enum to represent named argument indices for `newpc`.
  This enables us to more effectively manipulate its argument list.

* It improves the verification and error reporting for
  `efa::FunctionMetadata`.

* Update tests.

This commit is preliminary to another piece of work to improve the
generality of inlining beyond the simple "fake function" scenario, for
which the feature was originally conceived.
2023-02-23 14:51:10 +01:00

119 lines
3.2 KiB
C++

/// \file PruneRetSuccessors.cpp
/// \brief Remove successors from return instructions
//
// This file is distributed under the MIT License. See LICENSE.md for details.
//
#include "revng/FunctionCallIdentification/PruneRetSuccessors.h"
#include "revng/Support/Debug.h"
using namespace llvm;
char PruneRetSuccessors::ID = 0;
using Register = RegisterPass<PruneRetSuccessors>;
static Register X("prs", "Prune Ret Successors", true, true);
struct SuccessorsList {
bool AnyPC = false;
bool UnexpectedPC = false;
bool Other = false;
std::set<MetaAddress> Addresses;
bool operator==(const SuccessorsList &Other) const = default;
static SuccessorsList other() {
SuccessorsList Result;
Result.Other = true;
return Result;
}
bool hasSuccessors() const {
return AnyPC or UnexpectedPC or Other or Addresses.size() != 0;
}
void dump() const debug_function { dump(dbg); }
template<typename O>
void dump(O &Output) const {
Output << "AnyPC: " << AnyPC << "\n";
Output << "UnexpectedPC: " << UnexpectedPC << "\n";
Output << "Other: " << Other << "\n";
Output << "Addresses:\n";
for (const MetaAddress &Address : Addresses) {
Output << " ";
Address.dump(Output);
Output << "\n";
}
}
};
static SuccessorsList
getSuccessors(GeneratedCodeBasicInfo &GCBI, BasicBlock *BB) {
bool IsRoot = BB->getParent() == GCBI.root();
SuccessorsList Result;
df_iterator_default_set<BasicBlock *> Visited;
if (IsRoot) {
Visited.insert(GCBI.anyPC());
Visited.insert(GCBI.unexpectedPC());
}
for (BasicBlock *Block : depth_first_ext(BB, Visited)) {
for (BasicBlock *Successor : successors(Block)) {
revng_assert(Successor != GCBI.dispatcher());
MetaAddress Address = getBasicBlockID(Successor).start();
const auto IBDHB = BlockType::IndirectBranchDispatcherHelperBlock;
if (Address.isValid()) {
Visited.insert(Successor);
Result.Addresses.insert(Address);
} else if (IsRoot and Successor == GCBI.anyPC()) {
Result.AnyPC = true;
} else if (IsRoot and Successor == GCBI.unexpectedPC()) {
Result.UnexpectedPC = true;
} else if (getType(Successor) == IBDHB) {
// Ignore
} else {
Result.Other = true;
}
}
}
return Result;
}
bool PruneRetSuccessors::runOnModule(llvm::Module &M) {
auto &GCBI = getAnalysis<GeneratedCodeBasicInfoWrapperPass>().getGCBI();
auto &FCI = getAnalysis<FunctionCallIdentification>();
for (BasicBlock &BB : *GCBI.root()) {
if (not GCBI.isTranslated(&BB)
or BB.getTerminator()->getNumSuccessors() < 2)
continue;
auto Successors = getSuccessors(GCBI, &BB);
if (not Successors.UnexpectedPC or Successors.Other)
continue;
revng_assert(not Successors.AnyPC);
bool AllFallthrough = true;
for (MetaAddress SuccessorMA : Successors.Addresses) {
if (not FCI.isFallthrough(SuccessorMA)) {
AllFallthrough = false;
}
}
if (AllFallthrough) {
Instruction *OldTerminator = BB.getTerminator();
auto *NewTerminator = BranchInst::Create(GCBI.anyPC(), &BB);
NewTerminator->copyMetadata(*OldTerminator);
eraseFromParent(OldTerminator);
}
}
return true;
}