mirror of
https://github.com/revng/revng
synced 2026-06-21 14:07:57 +00:00
Kacper Kołodziej
2445c5e740
This commit changes MakeSegmentRefPass so that it's now a ModulePass and it uses the binary to detect integer constants that represent the address of strings. When it detects address of constant strings, instead of injecting calls to SegmentRef, we now inject calls to cstringLiteral, so that we can later emit them as inline string literals in C. In segmentRef we use integer type meaning address in memory, so we generate segmentRef function with non-pointer type. For cstringLiteral function we need real pointer type of operand. Save MetaAddress, size, offset and original type for every cstringLiteral call in metadata as we do for segmentRef calls. For cstringLiteral "revng.cstring_literal" metadata name is used. StringLiteralPool needs tuple of address, size, offset and type to keep distinct string decorator functions for each string. This tuple is represented by StringLiteralPoolKey struct. Pipe for MakeSegmentRefPass needs to be defined explicitly, because additional wrapper passes are required in MakeSegmentRef: 1. LoadModelWrapperPass 2. LoadBinaryWrapperPass MakeSegmentRefPass requires access to RawBinaryView to detect cstring literals in binary. Fix printed command in MakeSegmentRefPipe This printed command might not work. @ale commented it will be replaced with `revng pipe run-pipe` once we will have it. Update IRHelpers to new revng API Switch String and Namespace arguments in getUniqueString