mirror of
https://github.com/revng/revng
synced 2026-06-21 14:07:57 +00:00
Alessandro Di Federico
f68b7866b3
This commit introduces `BasicBlockID` as the unique identifier for a `efa::BasicBlock` into the CFG. A `BasicBlockID` is defined by a `MetaAddress` plus an incremental integer. This enables us to have multiple instances of the same block in a single function, which is particularly useful when inlining multiple times the same function. Apart from this, the commit also does the following: * It drops representing `MetaAddress`es a `structs` in the IR. This created several issues related to ABI. We now represent them as strings. * It defines more functions in `support.h`, instead of defining prototypes by hand in `CodeGenerator.cpp` and the like. Specifically, `unknownPC` and `raise_exception_helper`. We also introduce a C "constructor" for `PlainMetaAddress`. * It significantly reduces the API of `GeneratedCodeBasicInfo`, which was supposed to be put on a diet since a long time. Specifically, many jump target related methods have been moved to free functions in `IRHelpers.h`. Also `GCBI::getSuccessors` has been pushed into its only user, `PruneRetSuccessors`, to prevent further usage of a deprecated API. In the future, it would be nice to drop it entirely. * It introduces `efa::BasicBlock::InlinedFrom`. * Introduce an enum to represent named argument indices for `newpc`. This enables us to more effectively manipulate its argument list. * It improves the verification and error reporting for `efa::FunctionMetadata`. * Update tests. This commit is preliminary to another piece of work to improve the generality of inlining beyond the simple "fake function" scenario, for which the feature was originally conceived.
96 lines
2.8 KiB
C++
96 lines
2.8 KiB
C++
#pragma once
|
|
|
|
//
|
|
// This file is distributed under the MIT License. See LICENSE.md for details.
|
|
//
|
|
|
|
#include "revng/ADT/SortedVector.h"
|
|
#include "revng/EarlyFunctionAnalysis/CallEdge.h"
|
|
#include "revng/EarlyFunctionAnalysis/FunctionEdge.h"
|
|
#include "revng/EarlyFunctionAnalysis/FunctionEdgeBase.h"
|
|
#include "revng/Model/Identifier.h"
|
|
#include "revng/Model/VerifyHelper.h"
|
|
#include "revng/Support/BasicBlockID.h"
|
|
#include "revng/Support/BasicBlockID/YAMLTraits.h"
|
|
#include "revng/Support/MetaAddress.h"
|
|
|
|
/* TUPLE-TREE-YAML
|
|
name: BasicBlock
|
|
doc: The basic block of a function
|
|
type: struct
|
|
fields:
|
|
- name: ID
|
|
type: BasicBlockID
|
|
- name: End
|
|
doc: |
|
|
End address of the basic block, i.e., the address where the last
|
|
instruction ends
|
|
type: MetaAddress
|
|
- name: InlinedFrom
|
|
type: MetaAddress
|
|
doc: Address of the function this basic block has been inlined from
|
|
- name: Successors
|
|
doc: List of successor edges
|
|
sequence:
|
|
type: SortedVector
|
|
upcastable: true
|
|
elementType: FunctionEdgeBase
|
|
key:
|
|
- ID
|
|
TUPLE-TREE-YAML */
|
|
|
|
#include "revng/EarlyFunctionAnalysis/Generated/Early/BasicBlock.h"
|
|
|
|
class efa::BasicBlock : public efa::generated::BasicBlock {
|
|
public:
|
|
using generated::BasicBlock::BasicBlock;
|
|
|
|
public:
|
|
model::Identifier name() const;
|
|
BasicBlockID nextBlock() const {
|
|
return BasicBlockID(End(), ID().inliningIndex());
|
|
}
|
|
|
|
public:
|
|
bool verify() const debug_function;
|
|
bool verify(bool Assert) const debug_function;
|
|
bool verify(model::VerifyHelper &VH) const;
|
|
void dump() const debug_function;
|
|
};
|
|
|
|
inline model::TypePath getPrototype(const model::Binary &Binary,
|
|
MetaAddress CallerFunctionAddress,
|
|
const efa::BasicBlock &CallerBlock,
|
|
const efa::CallEdge &Edge) {
|
|
model::TypePath Result;
|
|
|
|
MetaAddress Caller = CallerFunctionAddress;
|
|
Caller = CallerBlock.InlinedFrom();
|
|
|
|
auto &CallSitePrototypes = Binary.Functions()
|
|
.at(CallerFunctionAddress)
|
|
.CallSitePrototypes();
|
|
auto It = CallSitePrototypes.find(CallerBlock.ID().start());
|
|
if (It != CallSitePrototypes.end())
|
|
Result = It->Prototype();
|
|
|
|
if (Edge.Type() == efa::FunctionEdgeType::FunctionCall) {
|
|
if (not Edge.DynamicFunction().empty()) {
|
|
// Get the dynamic function prototype
|
|
Result = Binary.ImportedDynamicFunctions()
|
|
.at(Edge.DynamicFunction())
|
|
.Prototype();
|
|
} else if (Edge.Destination().isValid()) {
|
|
// Get the function prototype
|
|
Result = Binary.Functions().at(Edge.Destination().start()).Prototype();
|
|
}
|
|
}
|
|
|
|
if (not Result.isValid())
|
|
Result = Binary.DefaultPrototype();
|
|
|
|
return Result;
|
|
}
|
|
|
|
#include "revng/EarlyFunctionAnalysis/Generated/Late/BasicBlock.h"
|