mirror of
https://github.com/revng/revng
synced 2026-06-21 14:07:57 +00:00
733f5008b3
We introduce a simplification step, which looks for `switch`es that can be reduced to simpler `if` statements. Specifically, the logic is the following: 1) When we identify a `switch` statement composed by a single `case` and a possible default, we transform it into an `if` with the `case` now corresponding to the `then`, and the `default` corresponding to the `else`, if present. 2) When we identify a `switch` statement composed by two `case`s, and no `default` is present, we can promote it to an `if` with `then` `else` branches. Other key details: - The promotion happens only if we can identify at least one of the `case`s that have a single element in the `case` label. If this is not the case, we do not promote one to RHS of the `if` condition. - A new `CompareNode` class, inheriting from `ExprNode`, is created, in order to represent the equality or inequality condition of an `IfNode` instance that is the result of the promotion. This `CompareNode` can represent for the LHS both an `llvm::Value` or the `loop_state_var`, while it embeds the RHS constant which completes the comparison. - We remove `SwitchBreak` AST nodes that may now appear as children of an `if` node promoted from a `switch`. - We introduce in the `CompareNode` the `weaved` concept. Indeed, if a promotion of a weaved `switch` happens, we should avoid the serialization of the instructions leading to the computation of the condition of the original `switch`, because they have been already emitted by the main related dominating `switch`. We also introduce an additional simplification step, which takes care of: - Promoting `!(==)` to `(!=)` and `!(!=)` to `(==)`, if the inner equal/not equal is represented via a `CompareNode`. - Promoting `x == 0` to `!x` and `x != 0` to `x`. To be able to correctly emit (or not) the instructions computing a condition of an `IfNode`, we need to add the `EmittBB` flag, an additional parameter to the `buildGHASTCondition` function, which controls the emission of the statements of a basic block computing a condition. Consequently, the `IfNode` acquires a `IsWeaved` field, which is used to mirror the property having the same name on `SwitchNode`. Being now possible a promotion from a dual `SwitchNode` to an `IfNode`, we need to represent this property on the `IfNode` too.
212 lines
6.7 KiB
C++
212 lines
6.7 KiB
C++
/// \file ASTTree.cpp
|
|
|
|
//
|
|
// Copyright rev.ng Labs Srl. See LICENSE.md for details.
|
|
//
|
|
|
|
#include <cstdlib>
|
|
|
|
#include "llvm/Support/FileSystem.h"
|
|
#include "llvm/Support/raw_os_ostream.h"
|
|
|
|
#include "revng-c/RestructureCFG/ASTNode.h"
|
|
#include "revng-c/RestructureCFG/ASTTree.h"
|
|
#include "revng-c/RestructureCFG/Utils.h"
|
|
|
|
using namespace llvm;
|
|
using ASTNodeMap = std::map<ASTNode *, ASTNode *>;
|
|
using ExprNodeMap = std::map<ExprNode *, ExprNode *>;
|
|
|
|
// Helper to obtain a unique incremental counter (to give name to sequence
|
|
// nodes).
|
|
static int Counter = 1;
|
|
static std::string getID() {
|
|
return std::to_string(Counter++);
|
|
}
|
|
|
|
SwitchBreakNode *ASTTree::addSwitchBreak(SwitchNode *SN) {
|
|
ASTNodeList.emplace_back(new SwitchBreakNode(SN));
|
|
ASTNodeList.back()->setID(getNewID());
|
|
return llvm::cast<SwitchBreakNode>(ASTNodeList.back().get());
|
|
}
|
|
|
|
SequenceNode *ASTTree::addSequenceNode() {
|
|
ASTNodeList.emplace_back(SequenceNode::createEmpty("sequence " + getID()));
|
|
|
|
// Set the Node ID
|
|
ASTNodeList.back()->setID(getNewID());
|
|
|
|
return llvm::cast<SequenceNode>(ASTNodeList.back().get());
|
|
}
|
|
|
|
size_t ASTTree::size() const {
|
|
return ASTNodeList.size();
|
|
}
|
|
|
|
ASTNode *ASTTree::addASTNodeImpl(ast_unique_ptr &&ASTObject) {
|
|
ASTNodeList.emplace_back(std::move(ASTObject));
|
|
ASTNode *ASTNode = ASTNodeList.back().get();
|
|
|
|
// Set the Node ID
|
|
ASTNode->setID(getNewID());
|
|
|
|
return ASTNode;
|
|
}
|
|
|
|
void ASTTree::addASTNode(BasicBlockNode<BasicBlock *> *Node,
|
|
ast_unique_ptr &&ASTObject) {
|
|
ASTNode *ASTNode = addASTNodeImpl(std::move(ASTObject));
|
|
|
|
// Proceed with the new insertion
|
|
bool New = BBASTMap.insert({ Node, ASTNode }).second;
|
|
revng_assert(New);
|
|
New = ASTBBMap.insert({ ASTNode, Node }).second;
|
|
revng_assert(New);
|
|
}
|
|
|
|
ASTNode *ASTTree::addASTNode(ast_unique_ptr &&ASTObject) {
|
|
return addASTNodeImpl(std::move(ASTObject));
|
|
}
|
|
|
|
void ASTTree::removeASTNode(ASTNode *Node) {
|
|
revng_log(CombLogger, "Removing AST node named: " << Node->getName() << "\n");
|
|
|
|
bool Removed = false;
|
|
for (auto It = ASTNodeList.begin(); It != ASTNodeList.end(); It++) {
|
|
if ((*It).get() == Node) {
|
|
ASTNodeList.erase(It);
|
|
Removed = true;
|
|
break;
|
|
}
|
|
}
|
|
revng_assert(Removed);
|
|
}
|
|
|
|
ASTNode *ASTTree::findASTNode(BasicBlockNode<BasicBlock *> *BlockNode) {
|
|
return BBASTMap.at(BlockNode);
|
|
}
|
|
|
|
BasicBlockNode<BasicBlock *> *ASTTree::findCFGNode(ASTNode *ASTNode) {
|
|
auto It = ASTBBMap.find(ASTNode);
|
|
if (It != ASTBBMap.end())
|
|
return It->second;
|
|
// We may return nullptr, since for example continue and break nodes do not
|
|
// have a corresponding CFGNode.
|
|
return nullptr;
|
|
}
|
|
|
|
void ASTTree::setRoot(ASTNode *Root) {
|
|
RootNode = Root;
|
|
}
|
|
|
|
ASTNode *ASTTree::getRoot() const {
|
|
return RootNode;
|
|
}
|
|
|
|
ASTNode *ASTTree::copyASTNodesFrom(ASTTree &OldAST) {
|
|
ASTNodeMap ASTSubstitutionMap{};
|
|
ExprNodeMap CondExprMap{};
|
|
|
|
// Clone each ASTNode in the current AST.
|
|
links_container::difference_type NewNodes = 0;
|
|
for (ASTNode *Old : OldAST.nodes()) {
|
|
ASTNodeList.emplace_back(std::move(Old->Clone()));
|
|
++NewNodes;
|
|
|
|
ASTNode *NewASTNode = ASTNodeList.back().get();
|
|
|
|
// Set the Node ID
|
|
NewASTNode->setID(getNewID());
|
|
|
|
BasicBlockNode<BasicBlock *> *OldCFGNode = OldAST.findCFGNode(Old);
|
|
if (OldCFGNode != nullptr) {
|
|
|
|
// We cannot assume that, when we copy nodes from nested ASTs, in the
|
|
// current AST, we do not have already a corresponding entry in
|
|
// `BBASTMap`. This is due to the fact that if the ASTs corresponding to
|
|
// two cloned collapsed nodes are copied in the same parent AST, it is
|
|
// guaranteed that the second time we clone the AST (which is identical to
|
|
// the first, the correspondence between clone node -> AST is
|
|
// deduplicated) we hit prepopulated entries in `BBASTMap`. For this same
|
|
// reason, we need to use the `insert_or_assign` method instead of
|
|
// `insert` to guarantee that the AST tiling for that portion uses the
|
|
// correct newer nodes.
|
|
BBASTMap.insert_or_assign(OldCFGNode, NewASTNode);
|
|
bool New = ASTBBMap.insert({ NewASTNode, OldCFGNode }).second;
|
|
revng_assert(New);
|
|
}
|
|
ASTSubstitutionMap[Old] = NewASTNode;
|
|
}
|
|
|
|
// Clone the conditional expression nodes.
|
|
for (const expr_unique_ptr &OldExpr : OldAST.expressions()) {
|
|
CondExprList.emplace_back(new AtomicNode(*cast<AtomicNode>(OldExpr.get())),
|
|
expr_destructor());
|
|
ExprNode *NewExpr = CondExprList.back().get();
|
|
CondExprMap[OldExpr.get()] = NewExpr;
|
|
}
|
|
|
|
// Update the AST and BBNode pointers inside the newly created AST nodes,
|
|
// to reflect the changes made. Update also the pointer to the conditional
|
|
// expressions just cloned.
|
|
auto BeginInserted = ASTNodeList.end() - NewNodes;
|
|
auto EndInserted = ASTNodeList.end();
|
|
using MovedIteratorRange = llvm::iterator_range<links_container::iterator>;
|
|
MovedIteratorRange Result = llvm::make_range(BeginInserted, EndInserted);
|
|
for (ast_unique_ptr &NewNode : Result) {
|
|
NewNode->updateASTNodesPointers(ASTSubstitutionMap);
|
|
if (auto *If = llvm::dyn_cast<IfNode>(NewNode.get())) {
|
|
If->updateCondExprPtr(CondExprMap);
|
|
}
|
|
}
|
|
|
|
revng_assert(ASTSubstitutionMap.contains(OldAST.getRoot()));
|
|
return ASTSubstitutionMap[OldAST.getRoot()];
|
|
}
|
|
|
|
void ASTTree::dumpASTOnFile(const std::string &FileName) const {
|
|
std::error_code EC;
|
|
llvm::raw_fd_ostream DotFile(FileName, EC);
|
|
revng_check(not EC, "Could not open file to print AST dot");
|
|
|
|
// Open the `digraph`.
|
|
DotFile << "digraph CFGFunction {\n";
|
|
|
|
// Dump the graph in an iteratively fashion.
|
|
for (const auto &Node : ASTNodeList) {
|
|
Node->dump(DotFile);
|
|
}
|
|
|
|
// For each node in the graph, dump the outgoing edges.
|
|
for (const auto &Node : ASTNodeList) {
|
|
Node->dumpEdge(DotFile);
|
|
|
|
// For each node, if present, dump the edge going to the node in the
|
|
// `Successor` field.
|
|
Node->dumpSuccessor(DotFile);
|
|
}
|
|
|
|
// Conclude the `digraph`.
|
|
DotFile << "}\n";
|
|
}
|
|
|
|
void ASTTree::dumpASTOnFile(const std::string &FunctionName,
|
|
const std::string &FolderName,
|
|
const std::string &FileName) const {
|
|
|
|
const std::string GraphDir = "debug-graphs";
|
|
std::error_code EC = llvm::sys::fs::create_directory(GraphDir);
|
|
revng_check(not EC, "Could not create directory to print AST dot");
|
|
EC = llvm::sys::fs::create_directory(GraphDir + "/" + FunctionName);
|
|
revng_check(not EC, "Could not create directory to print AST dot");
|
|
const std::string PathName = GraphDir + "/" + FunctionName + "/" + FolderName;
|
|
EC = llvm::sys::fs::create_directory(PathName);
|
|
revng_check(not EC, "Could not create directory to print AST dot");
|
|
dumpASTOnFile(PathName + "/" + FileName);
|
|
}
|
|
|
|
ExprNode *ASTTree::addCondExpr(expr_unique_ptr &&Expr) {
|
|
CondExprList.emplace_back(std::move(Expr));
|
|
return CondExprList.back().get();
|
|
}
|