mirror of
https://github.com/revng/revng
synced 2026-06-21 14:07:57 +00:00
ea3cbe4c1b
Type inlining was a feature that allowed type definitions of structs/unions/enums to be printed in C directly inside the definition of another parent struct/union, if the inner type was only used once in the parent type. This kind of reasoning is inherently global: a type definition of the subtype can be inlined in the parent type one only if *globally* the subtype it isn't referred anywhere else. This caused issues with type inlining inside definitions of stack types in the body of functions. Indeed, for a given function, due to type inlining, it was necessary to do global reasoning about what other types could be inlined in the definition of the function's stack frame type. This, in turn, had heavy consequences on invalidation, because any change to any type (even if it wasn't referred in a given function's body) was causing invalidation of all functions' bodies. For this reason it was decided to drop the type inlining feature.
51 lines
1.9 KiB
C++
51 lines
1.9 KiB
C++
//
|
|
// This file is distributed under the MIT License. See LICENSE.md for details.
|
|
//
|
|
|
|
#include "revng/Backend/DecompileToSingleFile.h"
|
|
#include "revng/Backend/DecompileToSingleFilePipe.h"
|
|
#include "revng/HeadersGeneration/Options.h"
|
|
#include "revng/Pipeline/AllRegistries.h"
|
|
#include "revng/Pipeline/RegisterContainerFactory.h"
|
|
#include "revng/Pipes/FileContainer.h"
|
|
#include "revng/Pipes/Kinds.h"
|
|
#include "revng/TypeNames/PTMLCTypeBuilder.h"
|
|
|
|
using namespace revng::kinds;
|
|
|
|
namespace revng::pipes {
|
|
|
|
static pipeline::RegisterDefaultConstructibleContainer<DecompiledFileContainer>
|
|
Reg;
|
|
|
|
using Container = DecompileStringMap;
|
|
void DecompileToSingleFile::run(pipeline::ExecutionContext &EC,
|
|
const Container &DecompiledFunctions,
|
|
DecompiledFileContainer &OutCFile) {
|
|
|
|
llvm::raw_string_ostream Out = OutCFile.asStream();
|
|
|
|
namespace options = revng::options;
|
|
ptml::CTypeBuilder B(Out,
|
|
*getModelFromContext(EC),
|
|
/* EnableTaglessMode = */ false,
|
|
// Disable stack frame inlining because enabling it could
|
|
// break the property that we emit syntactically valid C
|
|
// code, due to the stack frame type definition being
|
|
// duplicated in the global header and in the function's
|
|
// body. In the single file artifact recompilability is
|
|
// still important.
|
|
{ .EnableStackFrameInlining = false });
|
|
|
|
// Make a single C file with an empty set of targets, which means all the
|
|
// functions in DecompiledFunctions
|
|
printSingleCFile(B, DecompiledFunctions, {} /* Targets */);
|
|
Out.flush();
|
|
|
|
EC.commitUniqueTarget(OutCFile);
|
|
}
|
|
|
|
} // end namespace revng::pipes
|
|
|
|
static pipeline::RegisterPipe<revng::pipes::DecompileToSingleFile> Y;
|