mirror of
https://github.com/revng/revng
synced 2026-06-21 14:07:57 +00:00
Alessandro Di Federico
f68b7866b3
This commit introduces `BasicBlockID` as the unique identifier for a `efa::BasicBlock` into the CFG. A `BasicBlockID` is defined by a `MetaAddress` plus an incremental integer. This enables us to have multiple instances of the same block in a single function, which is particularly useful when inlining multiple times the same function. Apart from this, the commit also does the following: * It drops representing `MetaAddress`es a `structs` in the IR. This created several issues related to ABI. We now represent them as strings. * It defines more functions in `support.h`, instead of defining prototypes by hand in `CodeGenerator.cpp` and the like. Specifically, `unknownPC` and `raise_exception_helper`. We also introduce a C "constructor" for `PlainMetaAddress`. * It significantly reduces the API of `GeneratedCodeBasicInfo`, which was supposed to be put on a diet since a long time. Specifically, many jump target related methods have been moved to free functions in `IRHelpers.h`. Also `GCBI::getSuccessors` has been pushed into its only user, `PruneRetSuccessors`, to prevent further usage of a deprecated API. In the future, it would be nice to drop it entirely. * It introduces `efa::BasicBlock::InlinedFrom`. * Introduce an enum to represent named argument indices for `newpc`. This enables us to more effectively manipulate its argument list. * It improves the verification and error reporting for `efa::FunctionMetadata`. * Update tests. This commit is preliminary to another piece of work to improve the generality of inlining beyond the simple "fake function" scenario, for which the feature was originally conceived.
74 lines
2.8 KiB
C++
74 lines
2.8 KiB
C++
/// \file Extraction.cpp
|
|
/// \brief
|
|
|
|
//
|
|
// This file is distributed under the MIT License. See LICENSE.md for details.
|
|
//
|
|
|
|
#include "revng/EarlyFunctionAnalysis/ControlFlowGraph.h"
|
|
#include "revng/EarlyFunctionAnalysis/FunctionEdgeType.h"
|
|
#include "revng/Model/Binary.h"
|
|
#include "revng/Yield/ControlFlow/Configuration.h"
|
|
#include "revng/Yield/ControlFlow/Extraction.h"
|
|
#include "revng/Yield/ControlFlow/FallthroughDetection.h"
|
|
#include "revng/Yield/Function.h"
|
|
#include "revng/Yield/Graph.h"
|
|
|
|
yield::Graph
|
|
yield::cfg::extractFromInternal(const yield::Function &Function,
|
|
const model::Binary &Binary,
|
|
const Configuration &Configuration) {
|
|
const auto &ControlFlowGraph = Function.ControlFlowGraph();
|
|
auto [Result, Table] = efa::buildControlFlowGraph<Graph>(ControlFlowGraph,
|
|
Function.Entry(),
|
|
Binary);
|
|
|
|
if (!Configuration.AddExitNode) {
|
|
auto ExitNodeIterator = Table.find(BasicBlockID::invalid());
|
|
if (ExitNodeIterator != Table.end())
|
|
Result.removeNode(ExitNodeIterator->second);
|
|
}
|
|
|
|
if (Configuration.AddEntryNode) {
|
|
auto EntryIterator = Table.find(BasicBlockID(Function.Entry()));
|
|
revng_assert(EntryIterator != Table.end());
|
|
auto *RootNode = Result.addNode();
|
|
RootNode->Address = BasicBlockID::invalid();
|
|
RootNode->addSuccessor(EntryIterator->second);
|
|
Result.setEntryNode(RootNode);
|
|
}
|
|
|
|
// Colour taken and refused edges.
|
|
for (const auto &BasicBlock : Function.ControlFlowGraph()) {
|
|
auto NodeIterator = Table.find(BasicBlock.ID());
|
|
revng_assert(NodeIterator != Table.end());
|
|
auto &CurrentNode = *NodeIterator->second;
|
|
CurrentNode.NextAddress = BasicBlock.nextBlock();
|
|
|
|
if (BasicBlock.Successors().size() == 2) {
|
|
revng_assert(CurrentNode.successorCount() <= 2);
|
|
if (CurrentNode.successorCount() == 2) {
|
|
auto Front = *CurrentNode.successor_edges_begin();
|
|
auto Back = *std::next(CurrentNode.successor_edges_begin());
|
|
if (Front.Neighbor->Address == BasicBlock.nextBlock()) {
|
|
Front.Label->Type = yield::Graph::EdgeType::Refused;
|
|
Back.Label->Type = yield::Graph::EdgeType::Taken;
|
|
} else if (Back.Neighbor->Address == BasicBlock.nextBlock()) {
|
|
Front.Label->Type = yield::Graph::EdgeType::Taken;
|
|
Back.Label->Type = yield::Graph::EdgeType::Refused;
|
|
}
|
|
} else if (CurrentNode.successorCount() == 1) {
|
|
for (const auto &Successor : BasicBlock.Successors())
|
|
if (FunctionEdgeType::isCall(Successor->Type()))
|
|
continue;
|
|
|
|
auto Edge = *CurrentNode.successor_edges_begin();
|
|
if (Edge.Neighbor->Address == BasicBlock.nextBlock())
|
|
Edge.Label->Type = yield::Graph::EdgeType::Refused;
|
|
}
|
|
}
|
|
}
|
|
|
|
return std::move(Result);
|
|
}
|