From 472f818fe55027abf2b1d1c78ec36aa06eeb86e8 Mon Sep 17 00:00:00 2001 From: Daniel Lemire Date: Wed, 13 Aug 2025 20:40:04 -0400 Subject: [PATCH] trimming repeated code --- include/simdjson/generic/ondemand/parser-inl.h | 6 ------ include/simdjson/generic/ondemand/parser.h | 2 -- 2 files changed, 8 deletions(-) diff --git a/include/simdjson/generic/ondemand/parser-inl.h b/include/simdjson/generic/ondemand/parser-inl.h index 819b0d7ce..69ee41211 100644 --- a/include/simdjson/generic/ondemand/parser-inl.h +++ b/include/simdjson/generic/ondemand/parser-inl.h @@ -144,12 +144,6 @@ inline simdjson_result parser::iterate_many(const uint8_t *buf, return document_stream(*this, buf, len, batch_size, allow_comma_separated); } -inline simdjson_result parser::iterate_many(padded_string_view json, size_t batch_size, bool allow_comma_separated) noexcept { - if(batch_size < MINIMAL_BATCH_SIZE) { batch_size = MINIMAL_BATCH_SIZE; } - if(allow_comma_separated && batch_size < json.length()) { batch_size = json.length(); } - return iterate_many(json.data(), json.length(), batch_size, allow_comma_separated); -} - inline simdjson_result parser::iterate_many(const char *buf, size_t len, size_t batch_size, bool allow_comma_separated) noexcept { // Warning: no check is done on the buffer padding. We trust the user. return iterate_many(reinterpret_cast(buf), len, batch_size, allow_comma_separated); diff --git a/include/simdjson/generic/ondemand/parser.h b/include/simdjson/generic/ondemand/parser.h index 83e3cff40..3b4a2d0ef 100644 --- a/include/simdjson/generic/ondemand/parser.h +++ b/include/simdjson/generic/ondemand/parser.h @@ -267,8 +267,6 @@ public: inline simdjson_result iterate_many(std::string &s, size_t batch_size = DEFAULT_BATCH_SIZE, bool allow_comma_separated = false) noexcept; /** @overload parse_many(const uint8_t *buf, size_t len, size_t batch_size) */ inline simdjson_result iterate_many(const padded_string &s, size_t batch_size = DEFAULT_BATCH_SIZE, bool allow_comma_separated = false) noexcept; - /** @overload parse_many(const uint8_t *buf, size_t len, size_t batch_size) */ - inline simdjson_result iterate_many(padded_string_view s, size_t batch_size = DEFAULT_BATCH_SIZE, bool allow_comma_separated = false) noexcept; /** @private We do not want to allow implicit conversion from C string to std::string. */ simdjson_result iterate_many(const char *buf, size_t batch_size = DEFAULT_BATCH_SIZE) noexcept = delete;