mirror of
https://github.com/simdjson/simdjson
synced 2026-06-08 17:27:07 +00:00
strager
5510089d45
* Rename simdjson_really_inline -> simdjson_inline I want to change the simdjson_really_inline macro to sometimes not force inlining. After that upcoming change, the name simdjson_really_inline will no longer makes sense. Rename simdjson_really_inline to simdjson_inline. This patch should not change semantics; simdjson_inline still forces inlining as before. Some functions still need to be really inlined for ABI reasons. (GCC's -Wpsabi complains otherwise.) Leave those functions marked as simdjson_really_inline. * Improve build times for debug builds simdjson_inline is used for most simdjson functions. It forces inlining. In unoptimized/debug builds, this can lead to a lot of machine code being generated (especially with Address Sanitizer), causing slow compilation. Change simdjson_inline to force inlining only for optimized builds. Sometimes, the programmer might want a slightly-optimized build and want fast compilation (e.g. GCC's -Og mode). Allow simdjson users to define the simdjson_inline macro themselves (e.g. on the command line: -Dsimdjson_inline=inline) in cases where the default behavior is undesired. This patch reduced build times by over 75% for ondemand_object_tests.cpp with GCC 9.4.0 and CMAKE_BUILD_TYPE=Debug on my AMD 5950X: Before: 6.885 6.683 6.971 6.957 6.949 seconds (5 samples) After: 1.492 1.551 1.494 1.490 1.531 seconds (5 samples)
41 lines
1020 B
C++
41 lines
1020 B
C++
#pragma once
|
|
|
|
#ifdef SIMDJSON_COMPETITION_NLOHMANN_JSON
|
|
|
|
#include "partial_tweets.h"
|
|
|
|
namespace partial_tweets {
|
|
|
|
struct nlohmann_json {
|
|
using StringType=std::string;
|
|
|
|
simdjson_inline uint64_t nullable_int(nlohmann::json value) {
|
|
if (value.is_null()) { return 0; }
|
|
return value;
|
|
}
|
|
|
|
bool run(simdjson::padded_string &json, std::vector<tweet<std::string>> &result) {
|
|
auto root = nlohmann::json::parse(json.data(), json.data() + json.size());
|
|
for (auto tweet : root["statuses"]) {
|
|
auto user = tweet["user"];
|
|
result.emplace_back(partial_tweets::tweet<std::string>{
|
|
tweet["created_at"],
|
|
tweet["id"],
|
|
tweet["text"],
|
|
nullable_int(tweet["in_reply_to_status_id"]),
|
|
{ user["id"], user["screen_name"] },
|
|
tweet["retweet_count"],
|
|
tweet["favorite_count"]
|
|
});
|
|
}
|
|
|
|
return true;
|
|
}
|
|
};
|
|
|
|
BENCHMARK_TEMPLATE(partial_tweets, nlohmann_json)->UseManualTime();
|
|
|
|
} // namespace partial_tweets
|
|
|
|
#endif // SIMDJSON_COMPETITION_NLOHMANN_JSON
|