mirror of
https://github.com/simdjson/simdjson
synced 2026-06-08 17:27:07 +00:00
strager
5510089d45
* Rename simdjson_really_inline -> simdjson_inline I want to change the simdjson_really_inline macro to sometimes not force inlining. After that upcoming change, the name simdjson_really_inline will no longer makes sense. Rename simdjson_really_inline to simdjson_inline. This patch should not change semantics; simdjson_inline still forces inlining as before. Some functions still need to be really inlined for ABI reasons. (GCC's -Wpsabi complains otherwise.) Leave those functions marked as simdjson_really_inline. * Improve build times for debug builds simdjson_inline is used for most simdjson functions. It forces inlining. In unoptimized/debug builds, this can lead to a lot of machine code being generated (especially with Address Sanitizer), causing slow compilation. Change simdjson_inline to force inlining only for optimized builds. Sometimes, the programmer might want a slightly-optimized build and want fast compilation (e.g. GCC's -Og mode). Allow simdjson users to define the simdjson_inline macro themselves (e.g. on the command line: -Dsimdjson_inline=inline) in cases where the default behavior is undesired. This patch reduced build times by over 75% for ondemand_object_tests.cpp with GCC 9.4.0 and CMAKE_BUILD_TYPE=Debug on my AMD 5950X: Before: 6.885 6.683 6.971 6.957 6.949 seconds (5 samples) After: 1.492 1.551 1.494 1.490 1.531 seconds (5 samples)
47 lines
1.0 KiB
C++
47 lines
1.0 KiB
C++
|
|
#pragma once
|
|
|
|
#include "json_benchmark/file_runner.h"
|
|
#include "tweet.h"
|
|
#include <vector>
|
|
|
|
namespace partial_tweets {
|
|
|
|
using namespace json_benchmark;
|
|
|
|
template<typename I>
|
|
struct runner : public file_runner<I> {
|
|
std::vector<tweet<typename I::StringType>> result{};
|
|
|
|
bool setup(benchmark::State &state) {
|
|
return this->load_json(state, TWITTER_JSON);
|
|
}
|
|
|
|
bool before_run(benchmark::State &state) {
|
|
if (!file_runner<I>::before_run(state)) { return false; }
|
|
result.clear();
|
|
return true;
|
|
}
|
|
|
|
bool run(benchmark::State &) {
|
|
return this->implementation.run(this->json, result);
|
|
}
|
|
|
|
template<typename R>
|
|
bool diff(benchmark::State &state, runner<R> &reference) {
|
|
return diff_results(state, result, reference.result, diff_flags::NONE);
|
|
}
|
|
|
|
size_t items_per_iteration() {
|
|
return result.size();
|
|
}
|
|
};
|
|
|
|
struct simdjson_dom;
|
|
|
|
template<typename I> simdjson_inline static void partial_tweets(benchmark::State &state) {
|
|
run_json_benchmark<runner<I>, runner<simdjson_dom>>(state);
|
|
}
|
|
|
|
} // namespace partial_tweets
|