From a871d51dfdd42945d107c018c7eee98badbbf397 Mon Sep 17 00:00:00 2001
From: pyth0n1c <87383215+pyth0n1c@users.noreply.github.com>
Date: Tue, 21 Feb 2023 17:24:25 -0800
Subject: [PATCH] Added the path TA to fix issues with the windows TA to S3.
 Added it to the baseline JSON and PY files.

---
 .../modules/validate_args.py                    | 17 +++++++++++++----
 .../test_config_github_actions.json             | 14 ++++++++++++--
 2 files changed, 25 insertions(+), 6 deletions(-)

diff --git a/bin/docker_detection_tester/modules/validate_args.py b/bin/docker_detection_tester/modules/validate_args.py
index 051c2cc3ea..e3ac66f3bd 100644
--- a/bin/docker_detection_tester/modules/validate_args.py
+++ b/bin/docker_detection_tester/modules/validate_args.py
@@ -74,7 +74,11 @@ setup_schema = {
             "default": {
                
                 # The default apps below were taken from the attack_range loadout: https://github.com/splunk/attack_range/blob/develop/attack_range.conf.template
-
+                "Splunk Add-on for CrowdStrike FDR": {
+                    "app_number": 5579,
+                    "app_version": "1.2.0",
+                    "http_path": "https://attack-range-appbinaries.s3.us-west-2.amazonaws.com/Latest/splunk-add-on-for-crowdstrike-fdr_120.tgz"
+                  },
                 "ADD_ON_FOR_LINUX_SYSMON": {
                     "app_number": 6176,
                     "app_version": "1.0.4",
@@ -140,6 +144,11 @@ setup_schema = {
                     "app_version": "8.1.0",
                     "http_path": "https://attack-range-appbinaries.s3.us-west-2.amazonaws.com/Latest/splunk-app-for-stream_810.tgz"
                   },
+                  "SPLUNK_TA_FIX_WINDOWS":{
+                    "app_number": None,
+                    "app_version": None,
+                    "http_path": "https://attack-range-appbinaries.s3.us-west-2.amazonaws.com/Latest/Splunk_TA_fix_windows.tgz"
+                  },
                   "SPLUNK_COMMON_INFORMATION_MODEL": {
                     "app_number": 1621,
                     "app_version": "5.0.1",
@@ -162,8 +171,8 @@ setup_schema = {
                   },
                   "SPLUNK_TA_MICROSOFT_CLOUD_SERVICES": {
                     "app_number": 3110,
-                    "app_version": "4.5.0",
-                    "http_path": "https://attack-range-appbinaries.s3.us-west-2.amazonaws.com/Latest/splunk-add-on-for-microsoft-cloud-services_450.tgz"
+                    "app_version": "4.5.1",
+                    "http_path": "https://attack-range-appbinaries.s3.us-west-2.amazonaws.com/Latest/splunk-add-on-for-microsoft-cloud-services_451.tgz"
                   },
                   "SPLUNK_ADD_ON_FOR_GOOGLE_CLOUD_PLATFORM": {
                     "app_number": 3088,
@@ -367,4 +376,4 @@ def validate(configuration: dict, skip_password_accessibility_check: bool = True
     except Exception as e:
         print("There was an error validation the configuration: [%s]" % (
             str(e)), file=sys.stderr)
-        return None, setup_schema
\ No newline at end of file
+        return None, setup_schema
diff --git a/bin/docker_detection_tester/test_config_github_actions.json b/bin/docker_detection_tester/test_config_github_actions.json
index 2001714718..47d2043d41 100644
--- a/bin/docker_detection_tester/test_config_github_actions.json
+++ b/bin/docker_detection_tester/test_config_github_actions.json
@@ -1,5 +1,10 @@
 {
   "apps": {
+      "Splunk Add-on for CrowdStrike FDR": {
+        "app_number": 5579,
+        "app_version": "1.2.0",
+        "http_path": "https://attack-range-appbinaries.s3.us-west-2.amazonaws.com/Latest/splunk-add-on-for-crowdstrike-fdr_120.tgz"
+      },
       "ADD_ON_FOR_LINUX_SYSMON": {
         "app_number": 6176,
         "app_version": "1.0.4",
@@ -60,6 +65,11 @@
         "app_version": "8.1.0",
         "http_path": "https://attack-range-appbinaries.s3.us-west-2.amazonaws.com/Latest/splunk-app-for-stream_810.tgz"
       },
+      "SPLUNK_TA_FIX_WINDOWS":{
+        "app_number": null,
+        "app_version": null,
+        "http_path": "https://attack-range-appbinaries.s3.us-west-2.amazonaws.com/Latest/Splunk_TA_fix_windows.tgz"
+      },
       "SPLUNK_COMMON_INFORMATION_MODEL": {
         "app_number": 1621,
         "app_version": "5.0.1",
@@ -97,8 +107,8 @@
     },
     "SPLUNK_TA_MICROSOFT_CLOUD_SERVICES": {
         "app_number": 3110,
-        "app_version": "4.5.0",
-        "http_path": "https://attack-range-appbinaries.s3.us-west-2.amazonaws.com/Latest/splunk-add-on-for-microsoft-cloud-services_450.tgz"
+        "app_version": "4.5.1",
+        "http_path": "https://attack-range-appbinaries.s3.us-west-2.amazonaws.com/Latest/splunk-add-on-for-microsoft-cloud-services_451.tgz"
     },
     "SPLUNK_TA_FOR_IIS": {
       "app_number": 3185,