From aef3f08c76ecf24c63a5df9042277ffdec4a0d4e Mon Sep 17 00:00:00 2001 From: Bhavin Patel Date: Thu, 27 Mar 2025 14:09:26 -0700 Subject: [PATCH] fail when ctl test fails --- .github/workflows/unit-testing.yml | 1 - .../application/crushftp_server_side_template_injection.yml | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/unit-testing.yml b/.github/workflows/unit-testing.yml index 3071d016f9..c3fdf39dad 100644 --- a/.github/workflows/unit-testing.yml +++ b/.github/workflows/unit-testing.yml @@ -47,7 +47,6 @@ jobs: git switch new_branch_for_testing contentctl test --disable-tqdm --no-enable-integration-testing --container-settings.num-containers 2 --post-test-behavior never_pause mode:changes --mode.target-branch ${{ github.base_ref }} echo "contentctl test - COMPLETED" - continue-on-error: true # Store test_results/summary.yml and dist/DA-ESS-ContentUpdate-latest.tar.gz to job artifact-test_summary_results.zip - name: store_artifacts diff --git a/detections/application/crushftp_server_side_template_injection.yml b/detections/application/crushftp_server_side_template_injection.yml index 01fc428ed4..73a25b55ae 100644 --- a/detections/application/crushftp_server_side_template_injection.yml +++ b/detections/application/crushftp_server_side_template_injection.yml @@ -57,7 +57,7 @@ rba: score: 64 threat_objects: - field: src_ip - type: ip_address + type: ip_address tags: analytic_story: - CrushFTP Vulnerabilities