diff --git a/bin/automated_detection_testing/ci/detection_testing_batch/modules/github_service.py b/bin/automated_detection_testing/ci/detection_testing_batch/modules/github_service.py index ffedd07ea2..f8ecc0b762 100644 --- a/bin/automated_detection_testing/ci/detection_testing_batch/modules/github_service.py +++ b/bin/automated_detection_testing/ci/detection_testing_batch/modules/github_service.py @@ -147,7 +147,7 @@ class GithubService: summary_file: str = None) -> list[str]: pruned_tests = [] csvlines = [] - + found_error = False for detection in detections_to_prune: if os.path.basename(detection).startswith("ssa") and exclude_ssa: continue @@ -164,6 +164,7 @@ class GithubService: if not os.path.exists(test_filepath): print("Detection [%s] references [%s], but it does not exist" % ( detection, test_filepath)) + found_error = True #raise(Exception("Detection [%s] references [%s], but it does not exist"%(detection, test_filepath))) elif test_filepath_without_security_content in previously_successful_tests: print( @@ -201,7 +202,10 @@ class GithubService: for r in csvlines: writer.writerow(r) - return pruned_tests + if found_error == False: + return pruned_tests + else: + raise(Exception("Error(s) in processing getting detections to test: see output above for specific error information.")) def get_test_files(self, mode: str, folders: list[str], types: list[str], detections_list: Union[list[str], None], diff --git a/detections/endpoint/powershell_loading_dotnet_into_memory_via_reflection_filter.yml b/detections/endpoint/powershell_loading_dotnet_into_memory_via_reflection.yml similarity index 100% rename from detections/endpoint/powershell_loading_dotnet_into_memory_via_reflection_filter.yml rename to detections/endpoint/powershell_loading_dotnet_into_memory_via_reflection.yml diff --git a/tests/endpoint/macos_lolbin.yml b/tests/endpoint/macos_lolbin.test.yml similarity index 100% rename from tests/endpoint/macos_lolbin.yml rename to tests/endpoint/macos_lolbin.test.yml