From eb09e94539094ac3f35ad3864caa0510a108f7e1 Mon Sep 17 00:00:00 2001 From: Jose Enrique Hernandez Date: Wed, 2 Feb 2022 13:15:00 -0500 Subject: [PATCH 1/2] Create pull_request_template.md --- .github/pull_request_template.md | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 0000000000..22cdbf1e40 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,10 @@ +# PR Template for new Detections + +For Authors +1. Make sure that CI/CD [detection-testing and build-and-validate](https://github.com/splunk/security_content/actions) jobs passed ✔️. + +For Reviewers +1. verify CI/CD jobs have passed without errors +3. validate SPL detection logic +4. validate/double check tags, description, how to implement +5. validate name patches `__` From 946d2343b545851637340e85e9395e40a12e55ef Mon Sep 17 00:00:00 2001 From: Michael Haag <5632822+MHaggis@users.noreply.github.com> Date: Wed, 2 Feb 2022 13:03:20 -0700 Subject: [PATCH 2/2] Update pull_request_template.md --- .github/pull_request_template.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 22cdbf1e40..fb03d2ad8e 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,10 +1,10 @@ # PR Template for new Detections -For Authors +For Authors: 1. Make sure that CI/CD [detection-testing and build-and-validate](https://github.com/splunk/security_content/actions) jobs passed ✔️. -For Reviewers -1. verify CI/CD jobs have passed without errors -3. validate SPL detection logic -4. validate/double check tags, description, how to implement -5. validate name patches `__` +For Reviewers: +- [ ] Verify CI/CD jobs have passed without errors. +- [ ] Validate SPL logic. +- [ ] Validate tags, description, and how to implement. +- [ ] Validate name patches `__`