From 31daa0f029184d2619eaee53da2185a11e91f541 Mon Sep 17 00:00:00 2001 From: Jose Enrique Hernandez Date: Wed, 11 May 2022 14:58:44 -0400 Subject: [PATCH] Update pull_request_template.md --- .github/pull_request_template.md | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index d61ff868b3..0c4a016392 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,12 +1,18 @@ # PR Template for new Detections -For Authors: -- [ ] Make sure that CI/CD [detection-testing and build-and-validate](https://github.com/splunk/security_content/actions) jobs passed ✔️. +### Details + +*_what does this PR have in it, screenshots are nice 😄_ + +### Author Checklist -For Reviewers: -- [ ] Verify CI/CD jobs have passed without errors. -- [ ] Validate SPL logic. -- [ ] Validate tags, description, and how to implement. - [ ] Validate name matches `__` -- [ ] Verify references match analytic. -- [ ] Is there an Atomic Test? \ No newline at end of file +- [ ] Make sure that CI/CD [detection-testing and build-and-validate](https://github.com/splunk/security_content/actions) jobs passed ✔️ +- [ ] Is there an Atomic Test? Is GUID on the test file under array: `atomic_test_guid`, [example]()? + + +### Review Checklist + +- [ ] Validated SPL logic. +- [ ] Validated tags, description, and how to implement. +- [ ] Verified references match analytic.