From f11a1e6f827ed7c1bfb18b8318c1f60f2634fc83 Mon Sep 17 00:00:00 2001
From: Sam Brannen <104798+sbrannen@users.noreply.github.com>
Date: Mon, 11 Aug 2025 11:27:10 +0300
Subject: [PATCH] Polish tests

---
 .../client/JdkClientHttpRequestTests.java     | 21 ++++++-------------
 .../RequestMappingHandlerAdapterTests.java    |  2 +-
 2 files changed, 7 insertions(+), 16 deletions(-)

diff --git a/spring-web/src/test/java/org/springframework/http/client/JdkClientHttpRequestTests.java b/spring-web/src/test/java/org/springframework/http/client/JdkClientHttpRequestTests.java
index b48a4d79f25..300af1ea221 100644
--- a/spring-web/src/test/java/org/springframework/http/client/JdkClientHttpRequestTests.java
+++ b/spring-web/src/test/java/org/springframework/http/client/JdkClientHttpRequestTests.java
@@ -28,15 +28,14 @@ import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
 
-import org.junit.jupiter.api.AfterEach;
-import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.AutoClose;
 import org.junit.jupiter.api.Test;
 
 import org.springframework.http.HttpHeaders;
 import org.springframework.http.HttpMethod;
 
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
-import static org.mockito.Mockito.any;
+import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
@@ -47,21 +46,12 @@ class JdkClientHttpRequestTests {
 
 	private final HttpClient client = mock(HttpClient.class);
 
-	private ExecutorService executor;
-
-
-	@BeforeEach
-	void setup() {
-		executor = Executors.newSingleThreadExecutor();
-	}
-
-	@AfterEach
-	void tearDown() {
-		executor.shutdownNow();
-	}
+	@AutoClose("shutdownNow")
+	private final ExecutorService executor = Executors.newSingleThreadExecutor();
 
 
 	@Test
+	@SuppressWarnings("unchecked")
 	void futureCancelledAfterTimeout() {
 		CompletableFuture<HttpResponse<InputStream>> future = new CompletableFuture<>();
 		when(client.sendAsync(any(HttpRequest.class), any(HttpResponse.BodyHandler.class))).thenReturn(future);
@@ -71,6 +61,7 @@ class JdkClientHttpRequestTests {
 	}
 
 	@Test
+	@SuppressWarnings("unchecked")
 	void futureCancelled() {
 		CompletableFuture<HttpResponse<InputStream>> future = new CompletableFuture<>();
 		future.cancel(true);
diff --git a/spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/RequestMappingHandlerAdapterTests.java b/spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/RequestMappingHandlerAdapterTests.java
index f768d641e4c..3e2940181cc 100644
--- a/spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/RequestMappingHandlerAdapterTests.java
+++ b/spring-webmvc/src/test/java/org/springframework/web/servlet/mvc/method/annotation/RequestMappingHandlerAdapterTests.java
@@ -393,7 +393,7 @@ class RequestMappingHandlerAdapterTests {
 	}
 
 
-	private static class SseController {
+	static class SseController {
 
 		public ResponseEntity<?> handle(@RequestParam String q) throws IOException {
 			if (q.equals("sse")) {