mirror of
https://github.com/trailofbits/skills
synced 2026-06-21 14:12:00 +00:00
Jonathan Hefner
debfb29c8e
* Fix `allowed-tools` to use spec-compliant space-delimited strings Per the agentskills.io specification, `allowed-tools` must be a single string of space-delimited patterns, not a YAML list. Converted all 23 SKILL.md files from the `- Item` list format to the correct `"Item1 Item2"` string format. Also updated the frontmatter examples in CLAUDE.md and the workflow-skill-design skill template to match. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Fix remaining allowed-tools format in firebase-apk-scanner and workflow-skill-design docs - Convert firebase-apk-scanner from comma-separated to space-delimited - Update anti-patterns.md and tool-assignment-guide.md examples from YAML lists to space-delimited strings - Remove unnecessary quotes from SKILL.md template placeholder Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Cover commands, new SKILL.md files, and fix template placeholder Extends the previous spec-compliance fixes: * Convert command frontmatter (commands/*.md) — per Claude Code docs, command files use the same frontmatter as skills, so the same space-delimited rule applies. * Convert three SKILL.md files added since the original PR: mutation-testing, trailmark-structural, trailmark-summary. * Fix the placeholder in the workflow-skill-design template. The previous "[minimum tools needed, space-delimited]" was YAML flow-sequence syntax, which parses as a list — the opposite of what the placeholder claims. Replaced with a concrete-looking space-delimited example plus a comment. Zeroize-audit agent files still use `allowed-tools:` in YAML list form. They are intentionally excluded: per the project's own docs (workflow-skill-design references), agents declare tools with `tools:` (not `allowed-tools:`). Fixing those requires changing the field name as well as the format and is out of scope for this PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * zeroize-audit agents: switch allowed-tools to tools Subagents declare their tool allowlist via `tools:` (comma-separated), not `allowed-tools:` — see Claude Code's subagent docs and this repo's own designing-workflow-skills/SKILL.md:47: > Skills use `allowed-tools:` in frontmatter. Agents use `tools:` > in frontmatter. Before this change, the zeroize-audit agents declared their tool list under `allowed-tools:`, which Claude Code does not read for subagents. The field was effectively a no-op; the spawned agents had no tool restriction enforced. Renames the field on all 11 agents to `tools:` and reformats the YAML list as comma-separated to match the documented format and existing agents elsewhere in the repo (e.g. function-analyzer.md, spec-compliance-checker.md). Tool sets are unchanged. Behavior change: tools now actually constrain what each spawned agent can call. The lists are the ones the original author intended. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * skill-improver: convert command allowed-tools to space-delimited The two command files in plugins/skill-improver/commands/ still used the JSON flow-array format (`allowed-tools: ["..."]`), which the rest of this PR converted everywhere else. Convert them to the spec-compliant space-delimited string form for consistency. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Dan Guido <dan@trailofbits.com>
Workflow Skill Design
A Claude Code plugin that teaches design patterns for building workflow-based skills and provides a review agent for auditing existing skills.
Components
Skills
- designing-workflow-skills — Guides the design and structuring of workflow-based Claude Code skills with multi-step phases, decision trees, subagent delegation, and progressive disclosure.
Agents
- workflow-skill-reviewer — Reviews workflow-based skills for structural quality, pattern adherence, tool assignment correctness, and anti-pattern detection. Produces a graded audit report.
What This Plugin Teaches
Five workflow patterns for structuring skills:
| Pattern | Use When |
|---|---|
| Routing | Multiple independent tasks from shared intake |
| Sequential Pipeline | Dependent steps, each feeding the next |
| Linear Progression | Single path, same every time |
| Safety Gate | Destructive/irreversible actions needing confirmation |
| Task-Driven | Complex dependencies with progress tracking |
Plus: anti-pattern detection, tool assignment rules, and progressive disclosure guidance.
Installation
/plugin install trailofbits/skills:workflow-skill-design
Usage
Designing a New Skill
Ask Claude to help design a workflow skill — the skill triggers automatically when the request involves multi-step workflows, phased execution, routing patterns, or skill architecture.
Reviewing an Existing Skill
The workflow-skill-reviewer agent can be spawned to audit any skill:
Review the skill at plugins/my-plugin/skills/my-skill/ for quality issues.
File Structure
plugins/workflow-skill-design/
.claude-plugin/
plugin.json
skills/
designing-workflow-skills/
SKILL.md
references/
workflow-patterns.md
anti-patterns.md
tool-assignment-guide.md
progressive-disclosure-guide.md
workflows/
design-a-workflow-skill.md
review-checklist.md
agents/
workflow-skill-reviewer.md
README.md