From a1b78ce68a1295fe31dbdbe68e9eb6aafdfe385c Mon Sep 17 00:00:00 2001 From: GitHub Copilot Date: Mon, 25 May 2026 17:36:41 -0500 Subject: [PATCH] =?UTF-8?q?review:=20address=20PR=20#550=20review=20feedba?= =?UTF-8?q?ck=20=E2=80=94=20revert=20bot-driven=20changes=20to=20test=20an?= =?UTF-8?q?d=20base=20adapter?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Delete agents_skills.txt and gemini_skills.txt (stale lint outputs) - Remove agents/*.agent.md gitignore guard - README.md: restore original table header, Claude Code row, simplify generate-all comment - docs/authoring.md: re-add Codex deprecated note alongside Copilot info - docs/usage.md: restore removed pr-enhance command - tools/adapters/base.py: remove AskUserQuestion mapping - tools/tests/test_cli_smoke.py: revert TTY skip in codex doctor test --- .gitignore | 3 +-- README.md | 6 +++--- agents_skills.txt | 28 ---------------------------- docs/authoring.md | 2 +- docs/usage.md | 3 ++- gemini_skills.txt | 14 -------------- tools/adapters/base.py | 1 - tools/tests/test_cli_smoke.py | 17 ++++------------- 8 files changed, 11 insertions(+), 63 deletions(-) delete mode 100644 agents_skills.txt delete mode 100644 gemini_skills.txt diff --git a/.gitignore b/.gitignore index 2e8791a..618ff0e 100644 --- a/.gitignore +++ b/.gitignore @@ -50,5 +50,4 @@ commands/**/*.toml /commands/ /agents/ /skills/ -# Guard Gemini output from pollution (generated .agent.md files in root agents/) -agents/*.agent.md + diff --git a/README.md b/README.md index a9456f6..29aacde 100644 --- a/README.md +++ b/README.md @@ -76,9 +76,9 @@ Three-tier model strategy: This marketplace ships to five agentic harnesses from one Markdown source. Each adapter emits harness-native artifacts (not lowest-common-denominator translations): -| Harness | Output path | Notes | +| Harness | Generates | Notes | |---|---|---| -| **Claude Code** | `plugins/` (source-of-truth) | Native `marketplace.json` + per-plugin `plugin.json` | +| **Claude Code** | (source-of-truth) | Native `marketplace.json` + `plugins/` | | **Codex CLI** | `.codex/skills/`, `.codex/agents/` | 8 KB skill cap respected; commands → skills | | **Cursor** | `.cursor-plugin/`, `.cursor/rules/` | Thin marketplace + curated rules; reuses `.claude/` | | **OpenCode** | `.opencode/agents/`, `.opencode/commands/`, `.opencode/skills/` | `permission:` block from `tools:` allowlist; OpenCode-safe skill names | @@ -86,7 +86,7 @@ emits harness-native artifacts (not lowest-common-denominator translations): | **Copilot** | `.copilot/agents/`, `.copilot/skills/` | Markdown agent profiles + SKILL.md skills; model maps to GPT-5 family | ```bash -make generate-all # all 5 generated harnesses (claude-code is source, not generated) +make generate-all # all five make validate # structural checks make garden # drift / dead-link / cap detection ``` diff --git a/agents_skills.txt b/agents_skills.txt deleted file mode 100644 index 9aa92f6..0000000 --- a/agents_skills.txt +++ /dev/null @@ -1,28 +0,0 @@ -aposd -aposd-audit -aposd-critique -brainstorming -dispatching-parallel-agents -enhance-prompt -executing-plans -find-skills -finishing-a-development-branch -gh-cli -git-commit -impeccable -karpathy-guidelines -react-components -receiving-code-review -repo-roast -requesting-code-review -shadcn-ui -stitch-design -stitch-loop -subagent-driven-development -systematic-debugging -test-driven-development -using-git-worktrees -using-superpowers -verification-before-completion -writing-plans -writing-skills diff --git a/docs/authoring.md b/docs/authoring.md index 09168d3..274efda 100644 --- a/docs/authoring.md +++ b/docs/authoring.md @@ -26,7 +26,7 @@ do, and what to avoid, so the work you do for Claude Code translates cleanly eve |---|---|---|---| | `agents/.md` | `name`, `description` | `model`, optional `tools:`, optional `color:` | `tools:` allowlist becomes a per-harness permission block where supported, dropped otherwise. | | `skills//SKILL.md` | `name`, `description` | (none) | Other Anthropic SKILL.md fields work on Claude Code only. | -| `commands/.md` | `description` | `argument-hint:` | Codex converts these to skills; Copilot emits `.copilot/commands//.md` slash-command prompts. | +| `commands/.md` | `description` | `argument-hint:` | Codex converts these to skills (it deprecated `~/.codex/prompts/`). Copilot emits `.copilot/commands//.md` slash-command prompts. | **Description triggers.** Include a recognized phrase: `Use when …`, `Use this skill when …`, `Use PROACTIVELY when …`, `Use after …`, `Trigger when …`, `Auto-loads when …`. The diff --git a/docs/usage.md b/docs/usage.md index f647e3d..08c4885 100644 --- a/docs/usage.md +++ b/docs/usage.md @@ -70,7 +70,8 @@ Claude Code automatically selects and coordinates the appropriate agents based o | Command | Description | | ----------------------------------- | -------------------------- | -| `/comprehensive-review:full-review` | Run the comprehensive review workflow | +| `/comprehensive-review:full-review` | Multi-perspective analysis | +| `/comprehensive-review:pr-enhance` | Enhance pull requests | ### Debugging & Troubleshooting diff --git a/gemini_skills.txt b/gemini_skills.txt deleted file mode 100644 index 7225a0f..0000000 --- a/gemini_skills.txt +++ /dev/null @@ -1,14 +0,0 @@ -brainstorming -dispatching-parallel-agents -executing-plans -finishing-a-development-branch -receiving-code-review -requesting-code-review -subagent-driven-development -systematic-debugging -test-driven-development -using-git-worktrees -using-superpowers -verification-before-completion -writing-plans -writing-skills diff --git a/tools/adapters/base.py b/tools/adapters/base.py index e68985f..a0df045 100644 --- a/tools/adapters/base.py +++ b/tools/adapters/base.py @@ -466,7 +466,6 @@ class HarnessAdapter(ABC): "WebFetch": "fetch", "WebSearch": "search", "TodoWrite": "todo", - "AskUserQuestion": "question", } out = body for camel, replacement in replacements.items(): diff --git a/tools/tests/test_cli_smoke.py b/tools/tests/test_cli_smoke.py index a62e8fb..d99d410 100644 --- a/tools/tests/test_cli_smoke.py +++ b/tools/tests/test_cli_smoke.py @@ -128,19 +128,10 @@ class TestCodexSmoke: a battery of structural checks and surfaces drift in the local install.""" proc = _run(["codex", "doctor"]) # Codex doctor returns 0 on healthy install; warnings are inline but don't fail. - if proc.returncode != 0: - # Some environments (CI containers) cannot provide a TTY; Codex doctor - # emits "stdin is not a terminal" in stderr and returns 1. Treat that as - # an environment limitation and skip the test rather than failing the PR. - if proc.stderr and "stdin is not a terminal" in proc.stderr: - pytest.skip( - f"codex doctor not runnable in non-interactive env: {proc.stderr.strip()}" - ) - # Otherwise, a real failure — surface it. - assert proc.returncode == 0, ( - f"codex doctor failed (rc={proc.returncode}):\n" - f"--- stdout ---\n{proc.stdout[:2000]}\n--- stderr ---\n{proc.stderr}" - ) + assert proc.returncode == 0, ( + f"codex doctor failed (rc={proc.returncode}):\n" + f"--- stdout ---\n{proc.stdout[:2000]}\n--- stderr ---\n{proc.stderr}" + ) @pytest.mark.skipif( not (WORKTREE / ".codex").is_dir(),