mirror of
https://github.com/wshobson/agents
synced 2026-06-21 14:13:58 +00:00
main
10 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
 GitHub Copilot
|
eb22976da8 | review: address code-audit findings — .omo/ artifact, docs drift, YAML quoting, validator helper | ||
|
GitHub Copilot
|
07036e9689 |
feat: copilot harness follows OpenCode install pattern with .copilot/ output
- Generate to .copilot/agents/ and .copilot/skills/ (repo-local, gitignored) - make install-copilot symlinks to ~/.copilot/ for user-level discovery - tools/install_copilot.py + test_install_copilot.py (mirrors install_opencode) - tools/validate_generated.py: validate agents + skills - tools/doc_gardener.py: stale artifact detection for .copilot/ - tools/generate.py: _HARNESS_TARGETS + prune_orphans for .copilot/ - tools/tests/test_adapters.py: TestCopilotAdapter (9 tests) - tools/tests/test_round_trip.py: TestCopilotRoundTrip (3 tests) - tools/tests/test_validate_generated.py: expanded to 8 tests - docs/harnesses.md: install-copilot instructions + Pensyve entry - .gitignore: .copilot/ Closes #553 (follows same install pattern as OpenCode) |
||
|
GitHub Copilot
|
c5bd699089 | feat: add Copilot harness adapter and fix test tooling | ||
|
GitHub Copilot
|
130384b7b3 |
revert: remove --commit flag and Makefile wiring (follow project contribution patterns)
- Keep generation local by default (.copilot) - Revert opt-in --commit behavior that wrote to .github/agents - Retain validator adjustments scoped to .copilot - Clean branch focuses only on adapter ergonomics and validator behavior Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> |
||
|
GitHub Copilot
|
c90f2c379c |
chore: copilot commit-mode support (clean branch)
- Add --commit flag to tools/generate.py and default .copilot output_root - Validate .github/agents in tools/validate_generated.py - Makefile wiring for COMMIT=1 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> |
||
|
Seth Hobson
|
9b6b4c1254 |
Add OpenCode global install support (#555)
* Add OpenCode global install support * Format OpenCode PR updates * Address OpenCode install review feedback * Cover OpenCode skill name length validation * Guard OpenCode stale artifact scan |
||
|
Seth Hobson
|
2d3f6a8527 |
chore: move toolchain to uv-native (no pip, no requirements.txt) (#543)
* chore: move toolchain to uv-native (no pip, no requirements.txt)
The repo previously mixed uv (for plugin-eval) with pip + requirements.txt
(for yt-design-extractor) and raw `python3` invocations in the Makefile and
CI workflows. This makes the toolchain uniformly uv-managed.
## yt-design-extractor
Moved `tools/yt-design-extractor.py` into `tools/yt-design-extractor/` with its
own `pyproject.toml` + `uv.lock`. EasyOCR (and its ~2 GB torch dependency)
becomes an optional extra (`uv sync --extra easyocr`). Deleted
`tools/requirements.txt`.
## Makefile
All targets now route through uv:
- `make install` / `make install-easyocr` / `make deps` / `make check` / `make run*`:
`cd tools/yt-design-extractor && uv run/uv sync`
- `make generate` / `make validate` / `make garden` / `make clean-generated`:
`uv run --project plugins/plugin-eval python tools/...` (reuses plugin-eval's
venv — it already has pyyaml and `extra-paths = ["../.."]` for tools/adapters)
- `make test` / `make smoke-test`: `uv run --project plugins/plugin-eval pytest`
## CI
- `.github/workflows/validate.yml`:
- `multi-harness-generate` swapped from `actions/setup-python@v5` to
`astral-sh/setup-uv@v5` + `uv sync` of plugin-eval before `make generate-all`
- Workflow-level `permissions: contents: read` + `persist-credentials: false`
on every checkout (carrying the security hardening forward consistently)
- `.github/workflows/code-quality.yml`:
- `json-lint` job swapped from `setup-python` to `setup-uv`
- YAML validator now uses `uv run --with pyyaml python` (no pre-step install)
- JSON/TOML validators use `uv run python` (stdlib `json.tool`, `tomllib`)
- Dropped the standalone `pip install pyyaml --quiet` line
## Inline hints
- `plugins/plugin-eval/src/plugin_eval/layers/judge.py`: error message
recommends `uv sync --extra llm` instead of `pip install plugin-eval[llm]`
- `tools/yt-design-extractor/yt-design-extractor.py`: usage docstring and
install hints now reference `make install` / `make install-easyocr` / `uv run`
The pip refs inside plugin-authored commands (deps-audit.md, doc-generate.md,
error-trace.md) describe scanning **user** Python projects — those legitimately
use pip and are out of scope.
Local gates green: make test (385 pass), make garden (0 errors), make validate
clean, ruff + format + ty all pass, markdownlint clean.
* chore: address PR #543 review feedback
- checkmake (Makefile): consolidate the multi-line `.PHONY:` declaration
onto a single line. The previous backslash-continued form was readable
but checkmake couldn't parse it, falsely flagging `validate` and
`clean-generated` as missing from .PHONY. They were already declared —
just invisible to the linter.
Other CodeRabbit feedback declined:
- pyproject.toml dep version constraints (CodeRabbit self-tagged "Low value"):
uv.lock pins exact versions for reproducibility; upper bounds on yt-dlp,
Pillow, etc. would invite stale-pin churn without changing the locked
installation. Tracking upstream aggressively is the right default for a
utility tool.
- SHA-pinning for GitHub Actions (CodeRabbit "Major" but defensible):
Workflow has no write scope (permissions: contents: read on both files),
no secrets are exposed, and the actions involved are first-party Anthropic
(astral-sh, actions/*, DavidAnson). Same policy decision as PR #542 —
blanket SHA pinning is a bigger commitment than this PR's scope warrants.
* chore: pin all GitHub Actions to commit SHAs
Addresses CodeRabbit's Major finding (zizmor `unpinned-uses`). Reverses the
earlier policy decision now that the workflow scope has grown — pins both
workflows consistently in one pass:
- actions/checkout v4 → 34e114876b0b11c390a56381ad16ebd13914f8d5
- actions/setup-node v4 → 49933ea5288caeca8642d1e84afbd3f7d6820020
- actions/upload-artifact v4 → ea165f8d65b6e75b540449e92b4886f43607fa02
- astral-sh/setup-uv v5 → e58605a9b6da7c637471fab8847a5e5a6b8df081
- DavidAnson/markdownlint-cli2-action v18 → eb5ca3ab411449c66620fe7f1b3c9e10547144b0
- oven-sh/setup-bun v2 → 0c5077e51419868618aeaa5fe8019c62421857d6
Each pin keeps the version tag in a trailing comment for human readability
and dependabot/renovate compatibility.
Both workflows YAML-validated locally; functionality unchanged.
|
||
|
Seth Hobson
|
be57c0b2e3 |
feat: multi-harness plugin marketplace (Codex, Cursor, OpenCode, Gemini) (#541)
* feat(adapters): multi-harness framework + harness_portability eval dimension
Turn this Claude Code plugin marketplace into a generic agentic-harness
marketplace. Adapters under tools/adapters/ emit harness-native artifacts
for OpenAI Codex CLI, Cursor, OpenCode, and Gemini CLI from a single
Markdown source. Source-of-truth stays under plugins/ — Claude Code is
unchanged.
Framework (tools/adapters/):
- base.py — PluginSource parser, HarnessAdapter ABC, write/mirror helpers
(path-traversal guard, UTF-8-safe), inline-list + block-list + block-scalar
YAML-ish parser, _utf8_safe_cut, _split_inline_list, _normalize_author
- capabilities.py — per-harness capability matrix, TOOL_NAME_MAPS,
MODEL_ALIASES, resolve_model() with explicit warnings
- codex.py — emits .codex/{skills,agents}/ + AGENTS.md (≤150-line
table-of-contents). Fence-aware body splitter, _utf8_safe_cut for
multibyte safety, _yaml_scalar with reserved-word + special-char quoting.
Skill/command name collision detection (and second-order __cmd fallback).
- cursor.py — emits .cursor-plugin/{plugin,marketplace}.json + curated
.cursor/rules/*.mdc. _validate_mdc_frontmatter handles YAML block scalars
(no false positives on colons in description body). _normalize_author
handles dict, npm-style strings, and author lists.
- opencode.py — transpiles agents to .opencode/agents/<id>.md with
mode:subagent + permission: deny-everything-else block (skill/task always
allowed as base capabilities — Claude's implicit defaults).
- gemini.py — emits native skills/, agents/, and commands/ at extension
root (April 2026 spec). Tool-allowlist remapped via TOOL_NAME_MAPS.
CLI + tooling:
- tools/generate.py — unified `make generate HARNESS=<x> [PLUGIN=<y>]`,
with --clean (containment-guarded; case-insensitive on Darwin/Win32),
--prune (orphan removal across all per-harness output trees), --strict
(warnings fail), per-plugin error aggregation, refuses --clean --plugin
(would silently wipe other plugins' artifacts).
- tools/validate_generated.py — structural validation across all four
harness outputs. Codex 8KB cap → error. _extract_permission_block
correctly handles nested permission keys (column-0 only).
- tools/doc_gardener.py — recurring drift detection per OpenAI harness-
engineering principle. STALE_ARTIFACT (info), DEAD_LINK (error),
MARKETPLACE_ORPHAN (error), SKILL_OVER_CODEX_CAP (warning), grouped
output sorted by severity.
plugin-eval (extends existing framework):
- New harness_portability dimension (6% weight, rebalanced from existing
static sub-scores). Surfaces non-portable patterns with concrete
remediation hints: SKILL_OVER_CODEX_CAP, CLAUDE_TOOL_REFS,
CLAUDE_TOOL_PROSE, AGENT_NAME_COLLISION, BARE_MODEL_ALIAS.
- _CAMEL_TOOL_PATTERN requires Claude-tool context (no false positives
on Rust's `Task` etc.). _TOOL_PROSE_PATTERN case-sensitive on tool
names, case-insensitive on the leading article.
- Findings do NOT also feed anti_pattern_penalty (no double-counting).
Documentation:
- Top-level guides: CODEX.md, CURSOR.md, OPENCODE.md (≤150 lines each,
table-of-contents pattern per OpenAI harness-engineering post)
- docs/harnesses.md — capability matrix, graceful-degradation table,
generated output paths
- docs/authoring.md — portable-content style guide (tools, models,
collision rules, fence-respect)
- docs/round-trip-results.md — real-CLI verification recipes (OpenCode
discovers 193 subagents, Gemini extensions validate passes, Codex
TOMLs all parse)
- CONTRIBUTING.md — new file pointing at docs/authoring.md
- README.md — rewritten for multi-harness (145 lines, was 460)
- CLAUDE.md — trimmed to 60-line table-of-contents
- GEMINI.md — trimmed from 1500 to 500 tokens (3× over budget previously)
Tests: 181 passing (103 plugin-eval + 78 tools/tests). Real-CLI round-trip
verified for OpenCode, Gemini, and Codex (TOML parses).
Replaces tools/generate_gemini_commands.py with the unified CLI.
* refactor(skills): extract detail to references/details.md (~75 skills)
Apply Anthropic's canonical SKILL.md progressive-disclosure pattern across
the marketplace: SKILL.md body becomes a navigation tier (trigger phrasing
+ quick start), detailed templates and worked examples move to
references/details.md (loaded on demand by the agent).
Motivation: OpenAI Codex CLI hard-truncates skills at 8 KB. Before this
change, ~90 skills exceeded that cap and would silently break on Codex.
The progressive-disclosure pattern is also Anthropic's documented
recommendation for token efficiency — Claude Code reads references/ files
on demand when the body navigation says to.
What's extracted, by pattern:
- Pass 1 (## Templates section): 19 skills — full template libraries
moved to references/details.md
- Pass 2 (## Implementation Patterns / ## Advanced Patterns): 13 skills
- Pass 3 (everything between nav-tier and wrap-tier headings): 53 skills
- Conservative re-extraction for 8 skills that got over-reduced — kept
~6-7 KB inline (most of the quick-start tier) plus references/ overflow
What stays inline (SKILL.md navigation tier):
- description: frontmatter (triggering — unchanged for all skills)
- ## When to Use This Skill / ## Core Concepts / ## Quick Start
- ## Best Practices / ## Troubleshooting / ## See Also wrap-ups
- A pointer note ("see references/details.md") so the agent knows where
to look for detail
What goes to references/details.md (detail tier, on-demand load):
- ## Templates (full code template libraries)
- ## Implementation Patterns / ## Advanced Patterns (deep examples)
- Mid-skill walkthroughs that exceed the inline budget
Also in this commit:
- plugins/brand-landingpage description trimmed from 958→543 chars
(preserves trigger phrasing, drops verbose example-quote list)
Net effect:
- SKILL_OVER_CODEX_CAP findings: 90 → 10 (88% reduction)
- All triggers unchanged — discovery behavior identical across harnesses
- 75 new references/details.md files with the extracted content
- Same depth of guidance, loaded progressively
Remaining 10 oversized skills are complex multi-section docs (e.g.
postgresql, code-review-excellence, evaluation-methodology) that need
per-skill manual judgment — flagged by `make garden` for future work.
* chore: bump all plugin versions (multi-harness release)
Patch-bump every local plugin (81) in both .claude-plugin/marketplace.json
entries and each plugins/<name>/.claude-plugin/plugin.json. Minor-bump the
top-level marketplace metadata.version (1.6.0 → 1.7.0) to signal the
multi-harness adapter framework addition.
The external git-subdir entry (qa-orchestra) is unaffected — its version
is governed by its upstream repo.
* fix(opencode): preserve explicit tools:[] + word-boundary subtask match
Addresses two Codex review findings on PR #541.
## P1 — `tools: []` silently upgraded to permissive (privilege escalation)
Before: `_build_permission_block` returned `{}` for any empty list, which
omits the `permission:` block entirely from the emitted agent. An author
who explicitly wrote `tools: []` to lock down an advisory-only agent got
an UNRESTRICTED agent in OpenCode. Affected agent in this tree:
`plugins/arm-cortex-microcontrollers/agents/arm-cortex-expert.md`.
Fix: `_build_permission_block` now takes a `has_tools_field` flag so the
caller can distinguish "tools: key missing" (Claude default permissive)
from "tools: []" (explicit lock-down). The lock-down case emits a
deny-everything block that allows ONLY the base capabilities (skill, task)
that Claude Code always grants implicitly. Verified against the real
arm-cortex-expert agent — now emits read/edit/write/bash/grep/glob/list:
deny, task/skill: allow.
## P2 — `"agent" in cmd.body.lower()` false-positives on substrings
Before: a command body containing `PerformanceReviewAgent` (class name
in a code snippet) or `useragent` triggered `subtask: true`, changing
runtime behavior based on incidental text.
Fix: switch to a compiled word-boundary regex `\b(agent|subagent)s?\b`
(case-insensitive). Tests confirm the substring `PerformanceReviewAgent`
no longer fires, while a real "spawn a subagent" sentence still does.
## Tests
3 new regression tests in tools/tests/test_adapters.py:
- `test_explicit_empty_tools_yields_locked_permission_block` (P1)
- `test_missing_tools_field_yields_no_permission_block` (P1 boundary)
- `test_subtask_inference_word_boundary` (P2)
184 total tests pass (was 181). OpenCode round-trip still discovers all
193 subagents; arm-cortex-expert agent is now properly locked down.
* test: behavioral verification + CI gates for multi-harness pipeline
Adds three layers of automated verification that pure-Python parser tests
miss, plus the CI jobs that turn them into hard gates. Catches the kinds
of issues that previously only surfaced when a real user installed the
marketplace and tried to use it.
## test_real_world.py — real-source structural tests
Runs against the actual `plugins/` tree (not synthetic fixtures). Catches
issues that only appear on real content:
- every marketplace entry resolves to a plugins/<name>/ dir
- every local plugin dir appears in marketplace.json
- marketplace.json version == per-plugin plugin.json version (catches drift)
- every plugin loads via load_plugin() without error
- no plugin name contains `__` (adapter namespace separator)
- every agent has name + description; every skill has a trigger phrase
(same regex plugin_eval's MISSING_TRIGGER check uses)
- no agent name collides with Codex built-ins
- every refactored skill (with `references/details.md`) has:
- meaningful detail content (>=500 B in details.md)
- a pointer to references/ in the SKILL.md body
- a navigation-tier heading preserved (When to Use, Overview, etc.)
- body >= 600 B (not a stub)
- every plugin.json has name + version matching the dir
This test pass found and fixed three real defects before commit:
- ship-mate/skills/scan: description had no trigger phrase ("Use when…")
- reverse-engineering/skills/memory-forensics: nav-tier section lost
during extraction
- reverse-engineering/skills/binary-analysis-patterns: same
All three are now fixed (preserved trigger phrasing, added When-to-Use
sections back to the skills my extraction over-trimmed).
## test_round_trip.py — generate→parse→verify
CI runs this AFTER `make generate-all`. Catches generation-time regressions:
- OpenCode/Codex/Gemini agent counts match source agent count (no skips)
- every Codex SKILL.md under 8 KB (the cap that would silently truncate)
- every Codex agent TOML has required fields + valid sandbox_mode
- every OpenCode agent has mode in {primary,subagent,all} and
provider-prefixed model
- locked agents (source `tools: []`) emit proper deny-everything permission
block with skill/task allow (regression guard for PR-541 P1)
- every Gemini @{path} injection resolves to a real source file
- every Gemini command TOML has prompt + {{args}} placeholder
- every context file (CLAUDE.md, AGENTS.md, GEMINI.md, etc.) within
150-line cap
- Cursor marketplace + per-plugin manifests cover all local plugins
- .cursor/rules/*.mdc only use the 3 documented frontmatter keys
## test_cli_smoke.py — real-CLI subprocess tests
Invokes the actual harness binaries (OpenCode, Gemini, Codex, Claude Code)
against the generated artifacts. Catches CLI-level issues pure-Python
parsing can't see: schema-loader drift, plugin-discovery bugs, version
incompatibilities.
- `opencode agent list` — must succeed AND discover every source agent
(currently 191 + 2 OpenCode built-ins)
- `gemini extensions validate <repo>` — must return success
- `codex doctor` — must report healthy install
- every Codex agent TOML must parse with stdlib `tomllib`
- `claude --version` — sanity check the Claude Code CLI loads
- marketplace.json must have owner + metadata.version for Claude Code's loader
Per-CLI tests skip gracefully when the binary isn't on PATH, so local
devs only exercise what they have installed. CI installs OpenCode +
Gemini and turns those skips into hard gates.
## Makefile + CI
- `make test` — full pytest suite (plugin-eval + tools/tests/)
- `make smoke-test` — generates if needed, then runs real-CLI smoke tests
- `.github/workflows/validate.yml` extended with:
- `tools-tests` job — runs pytest tools/tests/
- `multi-harness-generate` job — `make generate-all && make validate
STRICT=1 && make garden`, uploads generated artifacts on every run
- `cli-smoke-test` job — installs OpenCode + Gemini, runs test_cli_smoke.py
## Test counts
- Before: 184 tests
- After: 386 tests (parameterized real-source tests over all 82 plugins)
- All passing locally on OpenCode 1.15.7 + Gemini 0.42.0 + Codex 0.133.0
+ Claude Code 2.1.148
|
||
|
Mike Henke
|
a935f698dd |
feat: add Gemini CLI extension support (150+ skills via gemini-extension.json + GEMINI.md) (#512)
* chore: add .worktrees/ to .gitignore Isolate git worktrees from version control to keep repository clean. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * feat: add Gemini CLI extension manifest - Declare claude-agents as a Gemini CLI extension - Point to GEMINI.md for bootstrap context - Enable auto-discovery via gemini-cli-extension topic Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * feat: add Gemini CLI bootstrap context - Document 150+ skills ecosystem for Gemini users - Explain differences from Claude Code platform - Provide plugin navigation and skill usage guidance - Link to tool mapping and plugin catalog Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs: Add Gemini CLI tool mapping reference Add comprehensive docs/gemini-tool-mapping.md guide for users migrating from Claude Code to Gemini CLI. Includes: - Core Tools: Direct Equivalents (table format) - Platform-Specific Features: Claude Code Only (slash commands, subagents, model tiers) - Claude Code Specific: MCP Servers (description and migration guidance) - Platform Differences: Behavior & Constraints (context limits, tool availability) - Skill Design Guidelines (DO's and DON'Ts for Gemini compatibility) - Migration Path (step-by-step guide for adapting Claude Code skills) - Common Patterns (side-by-side code examples) - FAQ (troubleshooting and common questions) Document provides practical, self-contained guidance without requiring other docs, though cross-references to GEMINI.md and plugins.md are included. Co-authored-by: GitHub Copilot <noreply@github.com> * fix: Correct syntax errors in code examples - Lines 177-189: Convert Python pseudocode to valid bash for skill examples - Line 347: Remove invalid read_file() function call; use sed for line extraction - Lines 365-372: Replace mixed Python/bash with proper bash conditionals using exit codes All code examples now syntactically valid and follow Gemini CLI bash patterns. Co-authored-by: GitHub Copilot <copilot@github.com> * docs: add Gemini CLI section to README - Explain Gemini CLI extension availability and installation - Link to GEMINI.md for navigation and tool mapping for platform differences - Clarify multi-platform support (Claude Code primary, Gemini CLI skills) * docs: add Gemini CLI plugin discovery guide - List all 79 plugins organized by category with skill names - Include natural-language trigger examples for Gemini auto-activation - Complement GEMINI.md with detailed skill discovery navigation * docs: update GEMINI.md to reference Gemini-optimized plugin guide - Point plugin catalog navigation to gemini-plugin-guide.md for Gemini users - Keep reference to plugins.md as full technical catalog fallback * fix: remove trailing period from reference in GEMINI.md * fix: correct repo URL, extension version, gitignore, and doc references - Point install URL to upstream wshobson/agents (not fork) - Set extension version to 1.0.0 (initial release) - Fix .gitignore: restore .claude entry, add .worktrees/ - Fix broken @./plugins.md references → @./docs/plugins.md in tool-mapping doc * fix: align Gemini extension name with marketplace, fix @./ refs, deduplicate plugin listing, fix pseudo-code, update README plugin count * docs: add per-plugin GEMINI.md for all 79 plugins + generation script Generated programmatically from each plugin's agents/commands/skills frontmatter. Covers all three component types per plugin, providing scoped context for Gemini CLI slash commands and developer workflows inside the repo tree. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * docs: add ADR for Gemini CLI integration strategy Documents the four options considered, why hierarchical GEMINI.md scanning and per-repo splitting were rejected, and the key findings (slash commands are supported in Gemini; install granularity is a hard platform limit). Records pending Phase A work. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat: add Gemini CLI slash commands for all 100 plugin commands Creates commands/<plugin>/<cmd>.toml for each of the 100 Claude Code commands across 50 plugins, mapping /plugin:command to Gemini CLI's TOML command format. Prompts are self-contained (no extension-relative file inclusion) following confirmed patterns from real extension examples. Includes generator script at tools/generate_gemini_commands.py. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * docs: add ADRs for Phase A slash commands and Phase B distribution decision - 2026-05-01-gemini-slash-commands.md: documents TOML format, directory structure, self-contained prompt decision (no extension-relative @{path}), and auto-discovery. Includes primary source citations. - 2026-05-01-per-plugin-gemini-md-distribution.md: documents why per-plugin GEMINI.md files are kept in the repo despite not auto-loading for extension users. Refutes size/security liability claims with verified data. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * docs: add integration planning document Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * refactor: remove per-plugin GEMINI.md files and generator (option C) - Delete all 79 per-plugin GEMINI.md files (plugins/*/GEMINI.md) - Delete per-plugin file generator (tools/generate_plugin_gemini_md.py) - Eliminates false power user workflow benefit (files never auto-loaded) - Keeps TOML slash commands for real discovery mechanism - Single root GEMINI.md with bootstrap context remains Rationale: Per-plugin files were in wrong location for Gemini CLI auto-discovery. Power user benefit was fictional. Slash commands provide real discovery UX. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * docs(adr): update decisions to reflect Option C (removed per-plugin files) ADR Updates: - 2026-04-30-gemini-cli-integration.md: Explain Option C choice, document false power user claim - 2026-05-01-gemini-slash-commands.md: Clarify slash commands are primary power user feature - 2026-05-01-architecture-simplification.md (NEW): Document decision to remove per-plugin files - docs/decisions/README.md: Updated to reflect final decision - Archived: 2026-05-01-per-plugin-gemini-md-distribution.md Rationale: Audit revealed per-plugin GEMINI.md files don't auto-load (were positioned at root, not in .gemini/ subdirectory). False power user benefit justification invalidated the design. Slash commands (which do work) are the real power user feature. Simplified architecture removes 79 files, 1 generator script, keeps all functionality. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: remove false power user claim from GEMINI.md, correct tool mapping doc, fix status claim Critical fixes addressing three document contradictions: 1. GEMINI.md: Remove false auto-loading claim - Line 42 claimed: 'Power users (repo cloned) | Auto-loaded when you cd plugins/<name>/' - Audit + ADRs concluded this was INVALID (files never auto-loaded) - Yet GEMINI.md still published the lie as fact - Replaced with accurate description: slash commands are primary discovery mechanism 2. docs/gemini-tool-mapping.md: Correct slash commands status - Listed slash commands as 'Claude Code only' without noting Gemini TOML support - ADR 1 flagged: 'docs/gemini-tool-mapping.md requires correction (pending)' - Correction never happened - Updated to accurately describe Gemini's custom command support via TOML - Clarified difference: Gemini has extension-specific commands, not global shortcuts 3. docs/decisions/README.md: Fix 'IMPLEMENTED' status claim - Claimed: 'Status: IMPLEMENTED (2026-05-01)' - Reality: All work on feature/gemini-cli-integration, not merged to main - Main branch at |
||
|
bentheautomator
|
5d65aa1063 |
Add YouTube design concept extractor tool (#432)
* feat: add YouTube design concept extractor tool Extracts transcript, metadata, and keyframes from YouTube videos into a structured markdown reference document for agent consumption. Supports interval-based frame capture, scene-change detection, and chapter-aware transcript grouping. https://claude.ai/code/session_01KZxeSK9A2F2oZUoHgxUUBV * feat: add OCR and color palette extraction to yt-design-extractor - Add --ocr flag with Tesseract (fast) or EasyOCR (stylized text) engines - Add --colors flag for dominant color palette extraction via ColorThief - Add --full convenience flag to enable all extraction features - Include OCR text alongside each frame in markdown output - Add Visual Text Index section for searchable on-screen text - Export ocr-results.json and color-palette.json for reuse - Run OCR in parallel with ThreadPoolExecutor for performance https://claude.ai/code/session_01KZxeSK9A2F2oZUoHgxUUBV * feat: add requirements.txt and Makefile for yt-design-extractor - requirements.txt with core and optional dependencies - Makefile with install, deps check, and run targets - Support for make run-full, run-ocr, run-transcript variants - Cross-platform install-ocr target (apt/brew/dnf) https://claude.ai/code/session_01KZxeSK9A2F2oZUoHgxUUBV * chore: move Makefile to project root for easier access Now `make install-full` works from anywhere in the project. https://claude.ai/code/session_01KZxeSK9A2F2oZUoHgxUUBV * fix: make easyocr truly optional, fix install targets - Remove easyocr from install-full (requires PyTorch, causes conflicts) - Add separate install-easyocr target with CPU PyTorch from official index - Update requirements.txt with clear instructions for optional easyocr - Improve make deps output with clearer status messages https://claude.ai/code/session_01KZxeSK9A2F2oZUoHgxUUBV * fix: harden error handling and fix silent failures in yt-design-extractor - Check ffmpeg return codes instead of silently producing 0 frames - Add upfront shutil.which() checks for yt-dlp and ffmpeg - Narrow broad except Exception catches (transcript, OCR, color) - Log OCR errors instead of embedding error strings in output data - Handle subprocess.TimeoutExpired on all subprocess calls - Wrap video processing in try/finally for reliable cleanup - Error on missing easyocr when explicitly requested (no silent fallback) - Fix docstrings: 720p fallback, parallel OCR, chunk duration, deps - Split pytesseract/Pillow imports for clearer missing-dep messages - Add run-transcript to Makefile .PHONY and help target - Fix variable shadowing in round_color (step -> bucket_size) - Handle json.JSONDecodeError from yt-dlp metadata - Format with ruff --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Seth Hobson <wshobson@gmail.com> |