fixes from first review and deleting windowsProcess test helper for now

This commit is contained in:
Mariah Breakey
2016-12-15 09:57:00 -08:00
parent 4411a2adc9
commit 32899ad580
6 changed files with 10 additions and 36 deletions
+1 -2
View File
@@ -5,8 +5,7 @@
#>
Configuration Sample_WindowsProcess_Start
{
param
()
param ()
Import-DSCResource -ModuleName 'PSDscResources'
@@ -34,4 +34,3 @@ Configuration Sample_WindowsProcess_StartUnderUser
To use the sample(s) with credentials, see blog at:
http://blogs.msdn.com/b/powershell/archive/2014/01/31/want-to-secure-credentials-in-windows-powershell-desired-state-configuration.aspx
#>
+1 -2
View File
@@ -6,8 +6,7 @@
#>
Configuration Sample_WindowsProcess_Stop
{
param
()
param ()
Import-DSCResource -ModuleName 'PSDscResources'
@@ -17,6 +17,7 @@ Configuration Sample_WindowsProcess_StopUnderUser
[System.Management.Automation.Credential()]
$Credential = (Get-Credential)
)
Import-DSCResource -ModuleName 'PSDscResources'
Node localhost
@@ -35,5 +36,3 @@ Configuration Sample_WindowsProcess_StopUnderUser
To use the sample(s) with credentials, see blog at:
http://blogs.msdn.com/b/powershell/archive/2014/01/31/want-to-secure-credentials-in-windows-powershell-desired-state-configuration.aspx
#>
+7 -3
View File
@@ -223,6 +223,7 @@ None
* [Install a cab file with the given name from the given path](https://github.com/PowerShell/PSDesResources/blob/master/Examples/Sample_WindowsPackageCab.ps1)
### WindowsProcess
Provides a mechanism to start and stop a Windows process.
#### Requirements
@@ -230,6 +231,7 @@ Provides a mechanism to start and stop a Windows process.
None
#### Parameters
* **[String] Path** _(Key)_: The executable file of the process. This can be defined as either the full path to the file or as the name of the file if it is accessible through the environment path. Relative paths are not supported.
* **[String] Arguments** _(Key)_: A single string containing all the arguments to pass to the process. Pass in an empty string if no arguments are needed.
* **[PSCredential] Credential** _(Write)_: The credential of the user account to run the process under. If this user is from the local system, the StandardOutputPath, StandardInputPath, and WorkingDirectory parameters cannot be provided at the same time.
@@ -240,6 +242,7 @@ None
* **[String] WorkingDirectory** _(Write)_: The file path to the working directory under which to run the file. This property cannot be specified at the same time as Credential when running the process as a local user.
#### Read-Only Properties from Get-TargetResource
* **[UInt64] PagedMemorySize** _(Read)_: The amount of paged memory, in bytes, allocated for the process.
* **[UInt64] NonPagedMemorySize** _(Read)_: The amount of nonpaged memory, in bytes, allocated for the process.
* **[UInt64] VirtualMemorySize** _(Read)_: The amount of virtual memory, in bytes, allocated for the process.
@@ -254,16 +257,17 @@ None
* [Start a process under a user](https://github.com/PowerShell/PSDesResources/blob/master/Examples/Sample_WindowsProcess_StartUnderUser.ps1)
* [Stop a process under a user](https://github.com/PowerShell/PSDesResources/blob/master/Examples/Sample_WindowsProcess_StopUnderUser.ps1)
## Versions
### Unreleased
* WindowsFeature:
* Added Catch to ignore RuntimeException when importing ServerManager module. This solves the issue described [here](https://social.technet.microsoft.com/Forums/en-US/9fc314e1-27bf-4f03-ab78-5e0f7a662b8f/importmodule-servermanager-some-or-all-identity-references-could-not-be-translated?forum=winserverpowershell).
* Updated unit tests.
* Updated unit tests.
* Added WindowsProcess
* CommonTestHelper:
* Added Get-AppVeyorAdministratorCredential
* Added Set-StrictMode -'Latest' and $errorActionPreference -'Stop'
### 2.1.0.0
@@ -1,26 +0,0 @@
$errorActionPreference = 'Stop'
Set-StrictMode -Version 'Latest'
<#
.SYNOPSIS
Stops all instances of the process with the given name.
.PARAMETER ProcessName
The name of the process to stop.
#>
function Stop-ProcessByName
{
[CmdletBinding()]
param
(
[Parameter(Mandatory = $true)]
[String]
$ProcessName
)
Stop-Process -Name $ProcessName -ErrorAction 'SilentlyContinue' -Force
Wait-ScriptBlockReturnTrue -ScriptBlock { return $null -eq (Get-Process -Name $ProcessName -ErrorAction 'SilentlyContinue') } `
-TimeoutSeconds 15
}
Export-ModuleMember -Function Stop-ProcessByName