admin/PowerShell-PSReadLine
1
0
Fork 0
mirror of https://github.com/PowerShell/PSReadLine synced 2026-06-08 12:12:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make tab completion show results whose ListItemText are different by case only (#3456)

Browse Source
This commit is contained in:
Dominik Kaszewski
2022-10-24 11:56:09 -07:00
committed by GitHub
parent c8db4f587a
commit 4bfc4e94d9
1 changed files with 17 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
PSReadLine/Completion.cs
+17 -8
View File
@@ -10,7 +10,6 @@ using System.Diagnostics;
using System.Diagnostics.CodeAnalysis;
using System.Globalization;
using System.Linq;
using System.Runtime.InteropServices;
using System.Management.Automation;
using System.Management.Automation.Runspaces;
using Microsoft.PowerShell.Internal;
@@ -300,17 +299,27 @@ namespace Microsoft.PowerShell
if (start < 0 || start > _singleton._buffer.Length) return null;
if (length < 0 || length > (_singleton._buffer.Length - start)) return null;
// Only filter out duplicates on Windows.
if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && _tabCompletions.CompletionMatches.Count > 1)
if (_tabCompletions.CompletionMatches.Count > 1)
{
// Filter out apparent duplicates
var hashSet = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
// Filter out apparent duplicates -- the 'ListItemText' is exactly the same.
var hashSet = new HashSet<string>();
var matches = _tabCompletions.CompletionMatches;
List<int> indices = null;
foreach (var match in _tabCompletions.CompletionMatches.ToArray())
for (int i = 0; i < matches.Count; i++)
{
if (!hashSet.Add(match.ListItemText))
if (!hashSet.Add(matches[i].ListItemText))
{
_tabCompletions.CompletionMatches.Remove(match);
indices ??= new List<int>();
indices.Add(i);
}
}
if (indices is not null)
{
for (int i = indices.Count - 1; i >= 0; i--)
{
matches.RemoveAt(indices[i]);
}
}
}