admin/PowerShell-PowerShell
1
0
Fork 0
mirror of https://github.com/PowerShell/PowerShell synced 2026-06-08 12:12:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[release/v7.3.2] Fix Start-Job to check the existence of working directory using the PowerShell way (#18917)

Browse Source 
* Fix `Start-Job` to check the existence of working directory using the PowerShell way

* Add a test

* Update

* Fix the test

* Not covering the check of whitespace string for -WorkingDirectory

Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
This commit is contained in:
github-actions[bot]
2023-01-10 14:57:43 -08:00
committed by GitHub
co-authored by Dongbo Wang
parent 4b9eae3c4c
commit 2462a545bb
2 changed files with 16 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/System.Management.Automation/engine/remoting/commands/StartJob.cs
+1 -1
View File
@@ -601,7 +601,7 @@ namespace Microsoft.PowerShell.Commands
ThrowTerminatingError(errorRecord);
}
if (WorkingDirectory != null && !Directory.Exists(WorkingDirectory))
if (WorkingDirectory != null && !InvokeProvider.Item.IsContainer(WorkingDirectory))
{
string message = StringUtil.Format(RemotingErrorIdStrings.StartJobWorkingDirectoryNotFound, WorkingDirectory);
var errorRecord = new ErrorRecord(
test/powershell/engine/Job/Jobs.Tests.ps1
+15 -4
View File
@@ -30,8 +30,8 @@ Describe 'Basic Job Tests' -Tags 'Feature' {
BeforeAll {
$invalidPathTestCases = @(
@{ path = "This is an invalid path"; case = "invalid path"; errorId = "DirectoryNotFoundException,Microsoft.PowerShell.Commands.StartJobCommand"}
@{ path = ""; case = "empty string"; errorId = "ParameterArgumentValidationError,Microsoft.PowerShell.Commands.StartJobCommand"}
@{ path = " "; case = "whitespace string (single space)"; errorId = "ParameterArgumentValidationError,Microsoft.PowerShell.Commands.StartJobCommand"}
##@{ path = ""; case = "empty string"; errorId = "ParameterArgumentValidationError,Microsoft.PowerShell.Commands.StartJobCommand"}
##@{ path = " "; case = "whitespace string (single space)"; errorId = "ParameterArgumentValidationError,Microsoft.PowerShell.Commands.StartJobCommand"}
)
}
@@ -86,6 +86,17 @@ Describe 'Basic Job Tests' -Tags 'Feature' {
$jobOutput | Should -BeExactly $path.ToString()
}
It 'Can specify the working directory with a PSPath' {
try {
Push-Location 'Temp:\'
$job = Start-Job -ScriptBlock { $PWD } -WorkingDirectory $pwd.Path | Wait-Job
$jobOutput = Receive-Job $job
$jobOutput | Should -BeExactly $pwd.Path
} finally {
Pop-Location
}
}
It 'Can use the user specified working directory parameter with quote' -Skip:($IsWindows) {
$path = Join-Path -Path $TestDrive -ChildPath "My ""Dir"
$null = New-Item -ItemType Directory -Path "$path"
@@ -100,9 +111,9 @@ Describe 'Basic Job Tests' -Tags 'Feature' {
}
It 'Throws an error when the working directory parameter is <case>' -TestCases $invalidPathTestCases {
param($path, $case, $expectedErrorId)
param($path, $case, $errorId)
{Start-Job -ScriptBlock { 1 + 1 } -WorkingDirectory $path} | Should -Throw -ErrorId $expectedErrorId
{Start-Job -ScriptBlock { 1 + 1 } -WorkingDirectory $path} | Should -Throw -ErrorId $errorId
}
It 'Verifies that the current working directory is preserved' {