admin/PowerShell-PowerShell
1
0
Fork 0
mirror of https://github.com/PowerShell/PowerShell synced 2026-06-08 12:12:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove over-optimization in NativeCommandProcessor.DequeueProcessOutput

Browse Source
This commit is contained in:
Sergei Vorobev
2016-11-15 17:44:00 -08:00
parent 825352faa3
commit 4868cee9cf
1 changed files with 3 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/System.Management.Automation/engine/NativeCommandProcessor.cs
+3 -14
View File
@@ -606,19 +606,9 @@ namespace System.Management.Automation
{
if (blocking)
{
// If adding was completed and collection is empty,
// there is no need to do a blocking Take().
if (_nativeProcessOutputQueue.IsAddingCompleted)
{
if (_nativeProcessOutputQueue.Count > 0)
{
// This is a common codepath and although it has a duplicated code,
// we are keeping it outside of try {} catch {} to improve the perf
// for the common case.
return _nativeProcessOutputQueue.Take();
}
}
else
// If adding was completed and collection is empty (IsCompleted == true)
// there is no need to do a blocking Take(), we should just return.
if (!_nativeProcessOutputQueue.IsCompleted)
{
try
{
@@ -635,7 +625,6 @@ namespace System.Management.Automation
}
}
// collection is empty
return null;
}
else