admin/PowerShell-PowerShell
1
0
Fork 0
mirror of https://github.com/PowerShell/PowerShell synced 2026-06-08 12:12:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix -Debug to not trigger the ShouldProcess prompt (#26081)

Browse Source
This commit is contained in:
Dongbo Wang
2025-09-23 09:19:39 +05:00
committed by GitHub
parent 7cf2740bdc
commit 506869c157
2 changed files with 45 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/System.Management.Automation/engine/MshCommandRuntime.cs
+5 -7
View File
@@ -2992,21 +2992,19 @@ namespace System.Management.Automation
{
// WhatIf not relevant, it never gets this far in that case
if (Confirm)
return ConfirmImpact.Low;
if (Debug)
{
if (IsConfirmFlagSet) // -Debug -Confirm:$false
return ConfirmImpact.None;
return ConfirmImpact.Low;
}
if (IsConfirmFlagSet) // -Confirm:$false
if (IsConfirmFlagSet)
{
// -Confirm:$false
return ConfirmImpact.None;
}
if (!_isConfirmPreferenceCached)
{
bool defaultUsed = false;
_confirmPreference = Context.GetEnumPreference(SpecialVariables.ConfirmPreferenceVarPath, _confirmPreference, out defaultUsed);
_confirmPreference = Context.GetEnumPreference(SpecialVariables.ConfirmPreferenceVarPath, _confirmPreference, out _);
_isConfirmPreferenceCached = true;
}
test/powershell/Modules/Microsoft.PowerShell.Utility/Write-Debug.Tests.ps1
+40
View File
@@ -34,4 +34,44 @@ Describe "Write-Debug tests" -Tags "CI" {
$out = $p.StandardError.ReadToEnd()
$out | Should -BeNullOrEmpty
}
It "'-Debug' should not trigger 'ShouldProcess'" {
$pwsh = [PowerShell]::Create()
$pwsh.AddScript(@'
function Test-DebugWithConfirm
{
[CmdletBinding(SupportsShouldProcess = $true, ConfirmImpact = 'Low')]
Param ()
PROCESS
{
Write-Debug -Message "Debug_Message1"
If ($PSCmdlet.ShouldProcess('Doing the thing.','Proceed?','Ready to do the thing.'))
{
Write-Output 'success'
}
Write-Debug -Message "Debug_Message2"
}
END {}
}
'@)
$pwsh.Invoke()
$pwsh.Commands.Clear()
$pwsh.Streams.ClearStreams()
try {
$result = $pwsh.AddScript("Test-DebugWithConfirm -Debug").Invoke()
$result.Count | Should -BeExactly 1
$result[0] | Should -BeExactly 'success'
$pwsh.Streams.Error.Count | Should -BeExactly 0
$pwsh.Streams.Debug.Count | Should -BeExactly 2
$pwsh.Streams.Debug[0] | Should -BeExactly 'Debug_Message1'
$pwsh.Streams.Debug[1] | Should -BeExactly 'Debug_Message2'
}
finally {
$pwsh.Dispose()
}
}
}