admin/PowerShell-PowerShell
1
0
Fork 0
mirror of https://github.com/PowerShell/PowerShell synced 2026-06-08 12:12:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve a progress pane performance (#2640)

Browse Source 
* Improve a progress pane performance

Add timer to update a progress pane every 100 ms
This commit is contained in:
iSazonov
2016-11-08 11:21:28 -08:00
committed by Jason Shirk
parent 35b844a756
commit 760a9c2997
1 changed files with 41 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterfaceProgress.cs
+41 -3
View File
@@ -7,6 +7,7 @@ Copyright (c) Microsoft Corporation. All rights reserved.
using System;
using System.Management.Automation;
using Dbg = System.Management.Automation.Diagnostics;
using System.Threading;
namespace Microsoft.PowerShell
@@ -28,6 +29,12 @@ namespace Microsoft.PowerShell
// destroy the data structures representing outstanding progress records
// take down and destroy the progress display
if (_progPaneUpdateTimer != null)
{
// Stop update 'ProgressPane' and destroy timer
_progPaneUpdateTimer.Dispose();
_progPaneUpdateTimer = null;
}
if (_progPane != null)
{
Dbg.Assert(_pendingProgress != null, "How can you have a progress pane and no backing data structure?");
@@ -64,16 +71,44 @@ namespace Microsoft.PowerShell
if (_progPane == null)
{
// This is the first time we've received a progress record. Create a pane to show it, and
// then show it.
// This is the first time we've received a progress record.
// Create a progress pane,
// then show it,
// then create and start timer to update it.
_progPane = new ProgressPane(this);
if (_progPaneUpdateTimer == null && _progPane != null)
{
_progPane.Show(_pendingProgress);
_progPaneUpdateTimer = new Timer( new TimerCallback(ProgressPaneUpdateTimerElapsed), null, UpdateTimerThreshold, Timeout.Infinite);
}
}
_progPane.Show(_pendingProgress);
}
/// <summary>
///
/// TimerCallback for _progPaneUpdateTimer to update 'ProgressPane' and restart the timer.
///
/// </summary>
private
void
ProgressPaneUpdateTimerElapsed(object sender)
{
if (_progPane != null)
{
_progPane.Show(_pendingProgress);
}
if (_progPaneUpdateTimer != null)
{
_progPaneUpdateTimer.Change(UpdateTimerThreshold, Timeout.Infinite);
}
}
private
void
@@ -170,6 +205,9 @@ namespace Microsoft.PowerShell
private ProgressPane _progPane = null;
private PendingProgress _pendingProgress = null;
// The timer update 'ProgressPane' every 'UpdateTimerThreshold' milliseconds
private Timer _progPaneUpdateTimer;
private const int UpdateTimerThreshold = 100;
}
} // namespace