admin/PowerShell-PowerShell
1
0
Fork 0
mirror of https://github.com/PowerShell/PowerShell synced 2026-06-08 12:12:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix Get-Acl -LiteralPath "HKLM:Software\Classes\*" behaviour (#13107)

Browse Source 
* Fix #11566 bug

Add pester test for Get-Acl cmdlet

* Replace -pending parameter with -skip

* Fix test failing in Linux and MacOS
This commit is contained in:
Shri Ram K S
2020-07-31 16:44:45 -07:00
committed by GitHub
parent 4597b41396
commit 9ceee3e52f
2 changed files with 79 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Microsoft.PowerShell.Security/security/AclCommands.cs
+1 -1
View File
@@ -825,7 +825,7 @@ namespace Microsoft.PowerShell.Commands
{
if (_isLiteralPath)
{
pathsToProcess.Add(SessionState.Path.GetUnresolvedProviderPathFromPSPath(p));
pathsToProcess.Add(p);
}
else
{
test/powershell/Modules/Microsoft.PowerShell.Security/AclCmdlets.Tests.ps1
+78 -14
View File
@@ -1,20 +1,84 @@
# Copyright (c) Microsoft Corporation.
# Licensed under the MIT License.
Describe "Acl cmdlets are available and operate properly" -Tag CI {
It "Get-Acl returns an ACL object" -Pending:(!$IsWindows) {
$ACL = Get-Acl $TESTDRIVE
$ACL | Should -BeOfType System.Security.AccessControl.DirectorySecurity
}
It "Set-Acl can set the ACL of a directory" -Pending {
Setup -d testdir
$directory = "$TESTDRIVE/testdir"
$acl = Get-Acl $directory
$accessRule = [System.Security.AccessControl.FileSystemAccessRule]::New("Everyone","FullControl","ContainerInherit,ObjectInherit","None","Allow")
$acl.AddAccessRule($accessRule)
{ $acl | Set-Acl $directory } | Should -Not -Throw
Context "Windows ACL test" {
BeforeAll {
$PSDefaultParameterValues["It:Skip"] = -not $IsWindows
}
$newacl = Get-Acl $directory
$newrule = $newacl.Access | Where-Object { $accessrule.FileSystemRights -eq $_.FileSystemRights -and $accessrule.AccessControlType -eq $_.AccessControlType -and $accessrule.IdentityReference -eq $_.IdentityReference }
$newrule | Should -Not -BeNullOrEmpty
It "Get-Acl returns an ACL DirectorySecurity object" {
$ACL = Get-Acl $TESTDRIVE
$ACL | Should -BeOfType System.Security.AccessControl.DirectorySecurity
}
It "Get-Acl -LiteralPath HKLM:Software\Classes\*" {
$ACL = Get-Acl -LiteralPath HKLM:Software\Classes\*
$ACL | Should -BeOfType System.Security.AccessControl.RegistrySecurity
}
It "Get-Acl -LiteralPath .\Software\Classes\*" {
$currentPath = Get-Location
Set-Location -LiteralPath HKLM:\
$ACL = Get-Acl -LiteralPath .\Software\Classes\*
$ACL | Should -BeOfType System.Security.AccessControl.RegistrySecurity
$currentPath | Set-Location
}
It "Get-Acl -LiteralPath ." {
$currentPath = Get-Location
Set-Location -LiteralPath $TESTDRIVE
$ACL = Get-Acl -LiteralPath .
$ACL | Should -BeOfType System.Security.AccessControl.DirectorySecurity
$currentPath | Set-Location
}
It "Get-Acl -LiteralPath .." {
$currentPath = Get-Location
Set-Location -LiteralPath $TESTDRIVE
$ACL = Get-Acl -LiteralPath ..
$ACL | Should -BeOfType System.Security.AccessControl.DirectorySecurity
$currentPath | Set-Location
}
It "Get-Acl -Path .\Software\Classes\" {
$currentPath = Get-Location
Set-Location -LiteralPath HKLM:\
$ACL = Get-Acl -Path .\Software\Classes\
$ACL | Should -BeOfType System.Security.AccessControl.RegistrySecurity
$currentPath | Set-Location
}
It "Get-Acl -Path ." {
$currentPath = Get-Location
Set-Location -LiteralPath $TESTDRIVE
$ACL = Get-Acl -Path .
$ACL | Should -BeOfType System.Security.AccessControl.DirectorySecurity
$currentPath | Set-Location
}
It "Get-Acl -Path .." {
$currentPath = Get-Location
Set-Location -LiteralPath $TESTDRIVE
$ACL = Get-Acl -Path ..
$ACL | Should -BeOfType System.Security.AccessControl.DirectorySecurity
$currentPath | Set-Location
}
It "Set-Acl can set the ACL of a directory" {
Setup -d testdir
$directory = "$TESTDRIVE/testdir"
$acl = Get-Acl $directory
$accessRule = [System.Security.AccessControl.FileSystemAccessRule]::New("Everyone","FullControl","ContainerInherit,ObjectInherit","None","Allow")
$acl.AddAccessRule($accessRule)
{ $acl | Set-Acl $directory } | Should -Not -Throw
$newacl = Get-Acl $directory
$newrule = $newacl.Access | Where-Object { $accessrule.FileSystemRights -eq $_.FileSystemRights -and $accessrule.AccessControlType -eq $_.AccessControlType -and $accessrule.IdentityReference -eq $_.IdentityReference }
$newrule | Should -Not -BeNullOrEmpty
}
AfterAll {
$PSDefaultParameterValues.Remove("It:Skip")
}
}
}