admin/PowerShell-PowerShell
1
0
Fork 0
mirror of https://github.com/PowerShell/PowerShell synced 2026-06-08 12:12:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Convert InvalidCommandNameCharacters in AnalysisCache to SearchValues<char> for more efficient char searching (#24880)

Browse Source
This commit is contained in:
Armaan Mcleod
2025-01-28 10:33:26 +05:00
committed by GitHub
parent c1abc73def
commit bca20334c7
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/System.Management.Automation/engine/Modules/AnalysisCache.cs
+7 -7
View File
@@ -1,6 +1,7 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.
using System.Buffers;
using System.Collections;
using System.Collections.Concurrent;
using System.Collections.Generic;
@@ -35,11 +36,10 @@ namespace System.Management.Automation
private static readonly ConcurrentDictionary<string, string> s_modulesBeingAnalyzed =
new(concurrencyLevel: 1, capacity: 2, StringComparer.OrdinalIgnoreCase);
internal static readonly char[] InvalidCommandNameCharacters = new[]
{
'#', ',', '(', ')', '{', '}', '[', ']', '&', '/', '\\', '$', '^', ';', ':',
'"', '\'', '<', '>', '|', '?', '@', '`', '*', '%', '+', '=', '~'
};
internal static readonly SearchValues<char> InvalidCommandNameCharacters = SearchValues.Create("#,(){}[]&/\\$^;:\"'<>|?@`*%+=~");
internal static bool ContainsInvalidCommandNameCharacters(ReadOnlySpan<char> text)
=> text.ContainsAny(InvalidCommandNameCharacters);
internal static ConcurrentDictionary<string, CommandTypes> GetExportedCommands(string modulePath, bool testOnly, ExecutionContext context)
{
@@ -345,7 +345,7 @@ namespace System.Management.Automation
{
if (SessionStateUtilities.MatchesAnyWildcardPattern(command, scriptAnalysisPatterns, true))
{
if (command.IndexOfAny(InvalidCommandNameCharacters) < 0)
if (!ContainsInvalidCommandNameCharacters(command))
{
result[command] = CommandTypes.Function;
}
@@ -357,7 +357,7 @@ namespace System.Management.Automation
{
var commandName = pair.Key;
// These are already filtered
if (commandName.IndexOfAny(InvalidCommandNameCharacters) < 0)
if (!ContainsInvalidCommandNameCharacters(commandName))
{
result.AddOrUpdate(commandName, CommandTypes.Alias,
static (_, existingCommandType) => existingCommandType | CommandTypes.Alias);