admin/PowerShell-PowerShell
1
0
Fork 0
mirror of https://github.com/PowerShell/PowerShell synced 2026-06-08 12:12:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use Get-Help approach to find 'about_*.help.txt' files with correct locale for completions (#24194)

Browse Source
This commit is contained in:
MartinGC94
2025-02-27 14:20:43 +05:00
committed by GitHub
parent ca519c92ac
commit bdf04006f2
1 changed files with 22 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
+22 -32
View File
@@ -7752,44 +7752,34 @@ namespace System.Management.Automation
internal static List<CompletionResult> CompleteHelpTopics(CompletionContext context)
{
var results = new List<CompletionResult>();
string userHelpDir = HelpUtils.GetUserHomeHelpSearchPath();
string appHelpDir = Utils.GetApplicationBase(Utils.DefaultPowerShellShellID);
string currentCulture = CultureInfo.CurrentCulture.Name;
//search for help files for the current culture + en-US as fallback
var searchPaths = new string[]
ArrayList helpProviders = context.ExecutionContext.HelpSystem.HelpProviders;
HelpFileHelpProvider helpFileProvider = null;
for (int i = helpProviders.Count - 1; i >= 0; i--)
{
Path.Combine(userHelpDir, currentCulture),
Path.Combine(appHelpDir, currentCulture),
Path.Combine(userHelpDir, "en-US"),
Path.Combine(appHelpDir, "en-US")
}.Distinct();
string wordToComplete = context.WordToComplete + "*";
try
{
var wildcardPattern = WildcardPattern.Get(wordToComplete, WildcardOptions.IgnoreCase);
foreach (var dir in searchPaths)
if (helpProviders[i] is HelpFileHelpProvider provider)
{
var currentDir = new DirectoryInfo(dir);
if (currentDir.Exists)
{
foreach (var file in currentDir.EnumerateFiles("about_*.help.txt"))
{
if (wildcardPattern.IsMatch(file.Name))
{
string topicName = file.Name.Substring(0, file.Name.LastIndexOf(".help.txt"));
results.Add(new CompletionResult(topicName));
}
}
}
helpFileProvider = provider;
break;
}
}
catch (Exception)
if (helpFileProvider is null)
{
return null;
}
List<CompletionResult> results = new();
Collection<string> filesMatched = MUIFileSearcher.SearchFiles($"{context.WordToComplete}*.help.txt", helpFileProvider.GetExtendedSearchPaths());
foreach (string path in filesMatched)
{
string fileName = Path.GetFileName(path);
if (fileName.StartsWith("about_", StringComparison.OrdinalIgnoreCase))
{
string topicName = fileName.Substring(0, fileName.Length - ".help.txt".Length);
results.Add(new CompletionResult(topicName, topicName, CompletionResultType.ParameterValue, topicName));
}
}
return results;
}