Merged PR 30719: Add allowPartiallySucceededBuilds parameter for DownloadPipelineArtifact task

Otherwise we end up treating warnings like failures as this step will then always fail.

.pipelines/templates/linux.yml

@@ -169,6 +169,7 @@ jobs:
     inputs:
       artifact: drop_linux_build_${{ parameters.JobName }}
       path: $(Pipeline.Workspace)/drop_linux_build
+      allowPartiallySucceededBuilds: true
     displayName: Download build
 
   - pwsh: |

.pipelines/templates/mac.yml

@@ -112,6 +112,7 @@ jobs:
     inputs:
       artifact: 'macosBinResults-$(BuildArchitecture)'
       path: '$(Pipeline.Workspace)\Symbols'
+      allowPartiallySucceededBuilds: true
     displayName: Download build
 
   - pwsh: |

tools/releaseBuild/azureDevOps/releasePipeline.yml

@@ -214,6 +214,7 @@ stages:
         runBranch: '$(Build.SourceBranch)'
         artifact: metadata
         path: '$(Pipeline.Workspace)/releasePipeline/metadata'
+        allowPartiallySucceededBuilds: true
 
     - pwsh: |
         Get-ChildItem -Path $(Build.SourcesDirectory)
@@ -258,6 +259,7 @@ stages:
         runBranch: '$(Build.SourceBranch)'
         artifact: metadata
         path: '$(Pipeline.Workspace)/releasePipeline/metadata'
+        allowPartiallySucceededBuilds: true
 
     - pwsh: |
         Import-Module $(Build.SourcesDirectory)\ReleaseTools\AzDO -Force
@@ -469,6 +471,7 @@ stages:
         runBranch: '$(Build.SourceBranch)'
         artifact: metadata
         path: '$(Pipeline.Workspace)/releasePipeline/metadata'
+        allowPartiallySucceededBuilds: true
     - pwsh: |
         Import-Module $(Build.SourcesDirectory)\ReleaseTools\AzDO -Force
         Set-AzDoProjectInfo -ProjectOwner PowerShell-Rel -ProjectName PowerShell
@@ -510,6 +513,7 @@ stages:
         runBranch: '$(Build.SourceBranch)'
         artifact: metadata
         path: '$(Pipeline.Workspace)/releasePipeline/metadata'
+        allowPartiallySucceededBuilds: true
     - pwsh: |
         Import-Module $(Build.SourcesDirectory)\ReleaseTools\AzDO -Force
         Set-AzDoProjectInfo -ProjectOwner PowerShell-Rel -ProjectName PowerShell
@@ -613,6 +617,7 @@ stages:
         runBranch: '$(Build.SourceBranch)'
         artifact: metadata
         path: '$(Pipeline.Workspace)/releasePipeline/metadata'
+        allowPartiallySucceededBuilds: true
 
     - pwsh: |
         Import-Module $(Build.SourcesDirectory)\ReleaseTools\AzDO -Force

tools/releaseBuild/azureDevOps/templates/linux-authenticode-sign.yml

@@ -22,48 +22,56 @@ jobs:
     inputs:
       artifact: pwshLinuxBuild.tar.gz
       path: $(Build.ArtifactStagingDirectory)/linuxTars
+      allowPartiallySucceededBuilds: true
     displayName: Download deb build
 
   - task: DownloadPipelineArtifact@2
     inputs:
       artifact: pwshLinuxBuildMinSize.tar.gz
       path: $(Build.ArtifactStagingDirectory)/linuxTars
+      allowPartiallySucceededBuilds: true
     displayName: Download min-size build
 
   - task: DownloadPipelineArtifact@2
     inputs:
       artifact: pwshLinuxBuildArm32.tar.gz
       path: $(Build.ArtifactStagingDirectory)/linuxTars
+      allowPartiallySucceededBuilds: true
     displayName: Download arm32 build
 
   - task: DownloadPipelineArtifact@2
     inputs:
       artifact: pwshLinuxBuildArm64.tar.gz
       path: $(Build.ArtifactStagingDirectory)/linuxTars
+      allowPartiallySucceededBuilds: true
     displayName: Download arm64 build
 
   - task: DownloadPipelineArtifact@2
     inputs:
       artifact: pwshMarinerBuildAmd64.tar.gz
       path: $(Build.ArtifactStagingDirectory)/linuxTars
+      allowPartiallySucceededBuilds: true
     displayName: Download mariner build
 
   - task: DownloadPipelineArtifact@2
     inputs:
       artifact: pwshMarinerBuildArm64.tar.gz
       path: $(Build.ArtifactStagingDirectory)/linuxTars
+      allowPartiallySucceededBuilds: true
     displayName: Download mariner arm64 build
 
   - task: DownloadPipelineArtifact@2
     inputs:
       artifact: pwshLinuxBuildAlpine.tar.gz
       path: $(Build.ArtifactStagingDirectory)/linuxTars/pwshLinuxBuildAlpine.tar.gz
+      allowPartiallySucceededBuilds: true
     displayName: Download alpine build
 
   - task: DownloadPipelineArtifact@2
     inputs:
       artifact: pwshLinuxBuildFxdependent.tar.gz
       path: $(Build.ArtifactStagingDirectory)/linuxTars/pwshLinuxBuildFxdependent.tar.gz
+      allowPartiallySucceededBuilds: true
     displayName: Download fxdependent build
 
   - pwsh: |

tools/releaseBuild/azureDevOps/templates/linux-packaging.yml

@@ -26,6 +26,7 @@ jobs:
         artifact: authenticode-signed
         path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuild-signed
         pattern: '**/pwshLinuxBuild.tar.gz'
+        allowPartiallySucceededBuilds: true
       displayName: Download deb build
 
   - ${{ if eq(variables.build,'deb') }} :
@@ -34,6 +35,7 @@ jobs:
         artifact: authenticode-signed
         path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuildMinSize-signed
         pattern: '**/pwshLinuxBuildMinSize.tar.gz'
+        allowPartiallySucceededBuilds: true
       displayName: Download min-size build
 
   - ${{ if eq(variables.build,'deb') }} :
@@ -42,6 +44,7 @@ jobs:
         artifact: authenticode-signed
         path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuildArm32-signed
         pattern: '**/pwshLinuxBuildArm32.tar.gz'
+        allowPartiallySucceededBuilds: true
       displayName: Download arm32 build
 
   - ${{ if eq(variables.build,'deb') }} :
@@ -50,6 +53,7 @@ jobs:
         artifact: authenticode-signed
         path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuildArm64-signed
         pattern: '**/pwshLinuxBuildArm64.tar.gz'
+        allowPartiallySucceededBuilds: true
       displayName: Download arm64 build
 
   - ${{ if eq(variables.build,'rpm') }} :
@@ -58,6 +62,7 @@ jobs:
         artifact: authenticode-signed
         path: $(Build.ArtifactStagingDirectory)/pwshMarinerBuildAmd64-signed
         pattern: '**/pwshMarinerBuildAmd64.tar.gz'
+        allowPartiallySucceededBuilds: true
       displayName: Download mariner amd64 build
 
   - ${{ if eq(variables.build,'rpm') }} :
@@ -66,6 +71,7 @@ jobs:
         artifact: authenticode-signed
         path: $(Build.ArtifactStagingDirectory)/pwshMarinerBuildArm64-signed
         pattern: '**/pwshMarinerBuildArm64.tar.gz'
+        allowPartiallySucceededBuilds: true
       displayName: Download mariner arm64 build
 
   - ${{ if eq(variables.build,'alpine') }} :
@@ -74,6 +80,7 @@ jobs:
         artifact: authenticode-signed
         path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuildAlpine-signed
         pattern: '**/pwshLinuxBuildAlpine.tar.gz'
+        allowPartiallySucceededBuilds: true
       displayName: Download alpine build
 
   - ${{ if eq(variables.build,'fxdependent') }} :
@@ -82,6 +89,7 @@ jobs:
         artifact: authenticode-signed
         path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuildFxdependent-signed
         pattern: '**/pwshLinuxBuildFxdependent.tar.gz'
+        allowPartiallySucceededBuilds: true
       displayName: Download fxdependent build
 
   - ${{ if or(eq(variables.build,'deb'), eq(variables.build,'rpm')) }} :
@@ -89,6 +97,7 @@ jobs:
       inputs:
         artifact: pwshLinuxBuild-meta
         path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuild-meta
+        allowPartiallySucceededBuilds: true
       displayName: Download deb build meta
 
   - ${{ if eq(variables.build,'deb') }} :
@@ -96,6 +105,7 @@ jobs:
       inputs:
         artifact: pwshLinuxBuildMinSize-meta
         path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuildMinSize-meta
+        allowPartiallySucceededBuilds: true
       displayName: Download min-size build meta
 
   - ${{ if eq(variables.build,'deb') }} :
@@ -103,6 +113,7 @@ jobs:
       inputs:
         artifact: pwshLinuxBuildArm32-meta
         path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuildArm32-meta
+        allowPartiallySucceededBuilds: true
       displayName: Download arm32 build meta
 
   - ${{ if eq(variables.build,'deb') }} :
@@ -110,6 +121,7 @@ jobs:
       inputs:
         artifact: pwshLinuxBuildArm64-meta
         path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuildArm64-meta
+        allowPartiallySucceededBuilds: true
       displayName: Download arm64 build meta
 
   - ${{ if eq(variables.build,'rpm') }} :
@@ -117,6 +129,7 @@ jobs:
       inputs:
         artifact: pwshMarinerBuildAmd64-meta
         path: $(Build.ArtifactStagingDirectory)/pwshMarinerBuildAmd64-meta
+        allowPartiallySucceededBuilds: true
       displayName: Download mariner x64 build meta
 
   - ${{ if eq(variables.build,'rpm') }} :
@@ -124,6 +137,7 @@ jobs:
       inputs:
         artifact: pwshMarinerBuildArm64-meta
         path: $(Build.ArtifactStagingDirectory)/pwshMarinerBuildArm64-meta
+        allowPartiallySucceededBuilds: true
       displayName: Download mariner arm64 build meta
 
   - ${{ if eq(variables.build,'alpine') }} :
@@ -131,6 +145,7 @@ jobs:
       inputs:
         artifact: pwshLinuxBuildAlpine-meta
         path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuild-meta
+        allowPartiallySucceededBuilds: true
       displayName: Download alpine build meta
 
   - ${{ if eq(variables.build,'fxdependent') }} :
@@ -138,6 +153,7 @@ jobs:
       inputs:
         artifact: pwshLinuxBuildFxdependent-meta
         path: $(Build.ArtifactStagingDirectory)/pwshLinuxBuild-meta
+        allowPartiallySucceededBuilds: true
       displayName: Download fxdependent build meta
 
   - pwsh: |

tools/releaseBuild/azureDevOps/templates/release-BuildJson.yml

@@ -12,6 +12,7 @@ steps:
     runBranch: '$(Build.SourceBranch)'
     artifact: BuildInfoJson
     path: '$(Pipeline.Workspace)/releasePipeline/BuildInfoJson'
+    allowPartiallySucceededBuilds: true
 
 - pwsh: |
     Import-Module '$(Build.SourcesDirectory)/tools/ci.psm1'

tools/releaseBuild/azureDevOps/templates/release-GlobalToolTest.yml

@@ -27,6 +27,7 @@ jobs:
         artifact: finalResults
         patterns: '**/*.nupkg'
         path: '$(Pipeline.Workspace)/releasePipeline/finalResults'
+        allowPartiallySucceededBuilds: true
 
     - pwsh: |
         $dotnetMetadataPath = "$(Build.SourcesDirectory)/DotnetRuntimeMetadata.json"

tools/releaseBuild/azureDevOps/templates/release-MsixBundle.yml

@@ -25,6 +25,7 @@ jobs:
         artifact: finalResults
         patterns: '**/*.msix'
         path: '$(Pipeline.Workspace)\releasePipeline\msix'
+        allowPartiallySucceededBuilds: true
 
     - pwsh: |
         $cmd = Get-Command makeappx.exe -ErrorAction Ignore

tools/releaseBuild/azureDevOps/templates/release-PublishSymbols.yml

@@ -12,6 +12,7 @@ steps:
     itemPattern: |
       **/*
       !**/*signed.zip
+    allowPartiallySucceededBuilds: true
 
 - pwsh: |
     Write-Verbose -Verbose "Enumerating $(Pipeline.Workspace)\results"

tools/releaseBuild/azureDevOps/templates/release-ReleaseToNuGet.yml

@@ -2,7 +2,7 @@ parameters:
   - name: skipPublish
     default: false
     type: boolean
-    
+
 steps:
 - task: DownloadPipelineArtifact@2
   condition: and(eq('${{ parameters.skipPublish }}', 'false'), succeeded())
@@ -16,6 +16,7 @@ steps:
     artifact: finalResults
     patterns: '**/*.nupkg'
     path: '$(Pipeline.Workspace)/releasePipeline/finalResults'
+    allowPartiallySucceededBuilds: true
 
 - task: DownloadPipelineArtifact@2
   condition: and(eq('${{ parameters.skipPublish }}', 'false'), succeeded())
@@ -28,6 +29,7 @@ steps:
     runBranch: '$(Build.SourceBranch)'
     artifact: metadata
     path: '$(Pipeline.Workspace)/releasePipeline/metadata'
+    allowPartiallySucceededBuilds: true
 
 - pwsh: |
     #Exclude all global tool packages. Their names start with 'PowerShell.'

tools/releaseBuild/azureDevOps/templates/release-SDKTests.yml

@@ -26,6 +26,7 @@ jobs:
         artifact: finalResults
         patterns: '**/*.nupkg'
         path: '$(Pipeline.Workspace)/releasePipeline/finalResults'
+        allowPartiallySucceededBuilds: true
 
     - task: DownloadPipelineArtifact@2
       inputs:
@@ -37,6 +38,7 @@ jobs:
         runBranch: '$(Build.SourceBranch)'
         artifact: metadata
         path: '$(Pipeline.Workspace)/releasePipeline/metadata'
+        allowPartiallySucceededBuilds: true
 
     - pwsh:  |
         Import-Module "$(Build.SourcesDirectory)/build.psm1" -Force

tools/releaseBuild/azureDevOps/templates/release-UpdateDepsJson.yml

@@ -24,6 +24,7 @@ jobs:
       artifact: finalResults
       patterns: '**/PowerShell*-win-x64.zip'
       path: '$(Pipeline.Workspace)/releasePipeline/finalResults'
+      allowPartiallySucceededBuilds: true
 
   - task: DownloadPipelineArtifact@2
     inputs:
@@ -35,6 +36,7 @@ jobs:
       runBranch: '$(Build.SourceBranch)'
       artifact: BuildInfoJson
       path: '$(Pipeline.Workspace)/releasePipeline/BuildInfoJson'
+      allowPartiallySucceededBuilds: true
 
   - pwsh: |
       $fileName = (Get-Item "$ENV:PIPELINE_WORKSPACE/releasePipeline/BuildInfoJson/*.json").BaseName

tools/releaseBuild/azureDevOps/templates/release-ValidateFxdPackage.yml

@@ -30,6 +30,7 @@ jobs:
         artifact: finalResults
         patterns: '${{ parameters.packageNamePattern }}'
         path: '$(Pipeline.Workspace)/releasePipeline/finalResults'
+        allowPartiallySucceededBuilds: true
 
     - pwsh: |
         $env:DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1

tools/releaseBuild/azureDevOps/templates/release-ValidatePackageBOM.yml

@@ -24,6 +24,7 @@ steps:
     runBranch: '$(Build.SourceBranch)'
     artifact: finalResults
     path: $(System.ArtifactsDirectory)
+    allowPartiallySucceededBuilds: true
 
 
 - pwsh: |

tools/releaseBuild/azureDevOps/templates/sign-build-file.yml

@@ -10,6 +10,7 @@ steps:
   inputs:
     artifactName: '$(unsignedBuildArtifactContainer)'
     itemPattern: '$(unsignedBuildArtifactName)'
+    allowPartiallySucceededBuilds: true
 
 - pwsh: |
     Get-ChildItem "$(Pipeline.Workspace)\*" -Recurse