admin/PowerShell-PowerShell
1
0
Fork 0
mirror of https://github.com/PowerShell/PowerShell synced 2026-06-08 12:12:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Write proper error messages for Get-Command ' ' (#13564)

Browse Source
This commit is contained in:
Jake
2021-01-10 18:03:05 +05:00
committed by GitHub
parent 7bbe18ea86
commit d3f7ba9f95
2 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/System.Management.Automation/engine/CommandSearcher.cs
+4 -6
View File
@@ -1087,7 +1087,7 @@ namespace System.Management.Automation
string? result = null;
if (_context.EngineSessionState != null &&
_context.EngineSessionState.ProviderCount > 0)
_context.EngineSessionState.ProviderCount > 0 && _commandName.Length != 0)
{
// NTRAID#Windows OS Bugs-1009294-2004/02/04-JeffJon
// This is really slow. Maybe since we are only allowing FS paths right
@@ -1099,7 +1099,9 @@ namespace System.Management.Automation
// Relative Path: ".\command.exe"
// Home Path: "~\command.exe"
// Drive Relative Path: "\Users\User\AppData\Local\Temp\command.exe"
if (_commandName[0] == '.' || _commandName[0] == '~' || _commandName[0] == '\\')
char firstChar = _commandName[0];
if (firstChar == '.' || firstChar == '~' || firstChar == '\\')
{
using (CommandDiscovery.discoveryTracer.TraceScope(
"{0} appears to be a relative path. Trying to resolve relative path",
@@ -1334,10 +1336,6 @@ namespace System.Management.Automation
/// </exception>
internal LookupPathCollection ConstructSearchPatternsFromName(string name, bool commandDiscovery = false)
{
Dbg.Assert(
!string.IsNullOrEmpty(name),
"Caller should verify name");
var result = new LookupPathCollection();
// First check to see if the commandName has an extension, if so
test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Command.Tests.ps1
+9
View File
@@ -178,5 +178,14 @@ Describe "Get-Command" -Tag CI {
$Result | Should -BeOfType [System.Management.Automation.CommandInfo]
}
It "Throws '<expected>' exception if '<Name>' name is used" -TestCases @(
@{ Name = 'space'; Value = ' '; expected = "CommandNotFoundException,Microsoft.PowerShell.Commands.GetCommandCommand" }
@{ Name = 'empty'; Value = ''; expected = "ParameterArgumentValidationError,Microsoft.PowerShell.Commands.GetCommandCommand" }
@{ Name = 'null'; Value = $null; expected = "ParameterArgumentValidationError,Microsoft.PowerShell.Commands.GetCommandCommand" }
) {
param($value, $expected)
{ Get-Command $value -ErrorAction Stop } | Should -Throw -ErrorId $expected
}
}
}