admin/PowerShell-PowerShell
1
0
Fork 0
mirror of https://github.com/PowerShell/PowerShell synced 2026-06-08 12:12:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Feature]Use ParameterSetName instead of _ParameterSetName and rewrite test which used the function class directly

Browse Source
This commit is contained in:
Jonas Andersen
2017-09-19 21:36:46 +02:00
parent 2fcf55eaaf
commit da41f7deb8
2 changed files with 87 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Microsoft.PowerShell.Commands.Management/commands/management/Service.cs
+3 -3
View File
@@ -24,7 +24,7 @@ namespace Microsoft.PowerShell.Commands
/// <summary>
/// This class implements the base for service commands
/// </summary>
public abstract class ServiceBaseCommand : Cmdlet
public abstract class ServiceBaseCommand : PSCmdlet
{
#region Internal
@@ -1601,7 +1601,7 @@ namespace Microsoft.PowerShell.Commands
bool objServiceShouldBeDisposed = false;
try
{
if (_ParameterSetName.Equals("InputObject", StringComparison.OrdinalIgnoreCase) && InputObject != null)
if (this.ParameterSetName.Equals("InputObject", StringComparison.OrdinalIgnoreCase) && InputObject != null)
{
service = InputObject;
Name = service.ServiceName;
@@ -2223,7 +2223,7 @@ namespace Microsoft.PowerShell.Commands
bool objServiceShouldBeDisposed = false;
try
{
if (_ParameterSetName.Equals("InputObject", StringComparison.OrdinalIgnoreCase) && InputObject != null)
if (this.ParameterSetName.Equals("InputObject", StringComparison.OrdinalIgnoreCase) && InputObject != null)
{
service = InputObject;
Name = service.ServiceName;
test/powershell/Modules/Microsoft.PowerShell.Management/Set-Service.Tests.ps1
+84 -29
View File
@@ -53,41 +53,96 @@ Describe "Set/New/Remove-Service cmdlet tests" -Tags "Feature", "RequireAdminOnW
{ & $script } | ShouldBeErrorId $errorid
}
It "Set-Service can change '<parameter>' to '<value>'" -TestCases @(
@{parameter = "Description"; value = "hello"},
@{parameter = "DisplayName"; value = "test spooler"},
@{parameter = "StartupType"; value = "Disabled"},
@{parameter = "Status" ; value = "running" ; expected = "OK"}
) {
param($parameter, $value, $expected)
$currentService = Get-CimInstance -ClassName Win32_Service -Filter "Name='spooler'"
$originalStartupType = (Get-Service -Name spooler).StartType
It "Set-Service can change 'Description' to 'hello'" {
$serviceName = "spooler"
$parameter = "Description"
$value = "hello"
$service = Get-Service $serviceName
$originalServiceDescription = (Get-CimInstance -ClassName Win32_Service -Filter "Name='$serviceName'").$parameter
try {
$setServiceCommand = [Microsoft.PowerShell.Commands.SetServiceCommand]::new()
$setServiceCommand.Name = "Spooler"
$setServiceCommand.$parameter = $value
$setServiceCommand.Invoke()
$updatedService = Get-CimInstance -ClassName Win32_Service -Filter "Name='spooler'"
if ($expected -eq $null) {
$expected = $value
}
if ($parameter -eq "StartupType") {
$updatedService.StartMode | Should Be $expected
}
else {
$updatedService.$parameter | Should Be $expected
$arguments = @{
'Name' = $serviceName
$parameter = $value
}
Set-Service @arguments
(Get-CimInstance -ClassName Win32_Service -Filter "Name='$serviceName'").$parameter | Should BeExactly $value
}
finally {
if ($parameter -eq "StartupType") {
$setServiceCommand.StartupType = $originalStartupType
$arguments = @{
'Name' = $serviceName
$parameter = $originalServiceDescription
}
else {
$setServiceCommand.$parameter = $currentService.$parameter
Set-Service @arguments
(Get-CimInstance -ClassName Win32_Service -Filter "Name='$serviceName'").$parameter | Should BeExactly $originalServiceDescription
}
}
It "Set-Service can change 'DisplayName' to 'test spooler'" {
$serviceName = "spooler"
$parameter = "DisplayName"
$value = "test spooler"
$originalServiceDisplayName = (Get-Service $serviceName).$parameter
try {
$arguments = @{
'Name' = $serviceName
$parameter = $value
}
$setServiceCommand.Invoke()
$updatedService = Get-CimInstance -ClassName Win32_Service -Filter "Name='spooler'"
$updatedService.$parameter | Should Be $currentService.$parameter
Set-Service @arguments
(Get-Service -Name $serviceName).$parameter | Should BeExactly $value
}
finally {
$arguments = @{
'Name' = $serviceName
$parameter = $originalServiceDisplayName
}
Set-Service @arguments
(Get-Service -Name $serviceName).$parameter | Should BeExactly $originalServiceDisplayName
}
}
It "Set-Service can change 'StartupType' to 'Disabled'" {
$serviceName = "spooler"
$parameter = "StartupType"
$value = "Disabled"
$originalServiceStartupType = (Get-Service $serviceName).StartType
try {
$arguments = @{
'Name' = $serviceName
$parameter = $value
}
Set-Service @arguments
(Get-Service -Name $serviceName).StartType | Should BeExactly $value
}
finally {
$arguments = @{
'Name' = $serviceName
$parameter = $originalServiceStartupType
}
Set-Service @arguments
(Get-Service -Name $serviceName).StartType | Should BeExactly $originalServiceStartupType
}
}
It "Set-Service can change 'Status' to 'Running'" {
$serviceName = "spooler"
$parameter = "Status"
$value = "Running"
$originalServiceStatus = (Get-Service $serviceName).$parameter
try {
$arguments = @{
'Name' = $serviceName
$parameter = $value
}
Set-Service @arguments
(Get-Service -Name $serviceName).$parameter | Should BeExactly $value
}
finally {
$arguments = @{
'Name' = $serviceName
$parameter = $originalServiceStatus
}
Set-Service @arguments
(Get-Service -Name $serviceName).$parameter | Should BeExactly $originalServiceStatus
}
}