admin/PowerShell-PowerShell
1
0
Fork 0
mirror of https://github.com/PowerShell/PowerShell synced 2026-06-08 12:12:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reduce string allocations when formatting file system objects. (#8831)

Browse Source 
* Reduce string allocations when formatting file system objects by caching FullName.
* Clear cache FullName when the module changes.
This commit is contained in:
Staffan Gustafsson
2019-02-07 09:23:26 +05:00
committed by Ilya
parent d9be6483f6
commit ec88045fee
1 changed files with 28 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/System.Management.Automation/engine/DataStoreAdapterProvider.cs
+28 -20
View File
@@ -35,6 +35,8 @@ namespace System.Management.Automation
/// </summary>
private SessionState _sessionState;
private string _fullName;
/// <summary>
/// Gets the name of the provider.
/// </summary>
@@ -47,29 +49,34 @@ namespace System.Management.Automation
{
get
{
string result = this.Name;
if (!string.IsNullOrEmpty(this.PSSnapInName))
string GetFullName(string name, string psSnapInName, string moduleName)
{
result =
string.Format(
System.Globalization.CultureInfo.InvariantCulture,
"{0}\\{1}",
this.PSSnapInName,
this.Name);
string result = name;
if (!string.IsNullOrEmpty(psSnapInName))
{
result =
string.Format(
System.Globalization.CultureInfo.InvariantCulture,
"{0}\\{1}",
psSnapInName,
name);
}
// After converting core snapins to load as modules, the providers will have Module property populated
else if (!string.IsNullOrEmpty(moduleName))
{
result =
string.Format(
System.Globalization.CultureInfo.InvariantCulture,
"{0}\\{1}",
moduleName,
name);
}
return result;
}
// After converting core snapins to load as modules, the providers will have Module property populated
else if (!string.IsNullOrEmpty(this.ModuleName))
{
result =
string.Format(
System.Globalization.CultureInfo.InvariantCulture,
"{0}\\{1}",
this.ModuleName,
this.Name);
}
return result;
return _fullName ?? (_fullName = GetFullName(Name, PSSnapInName, ModuleName));
}
}
@@ -136,6 +143,7 @@ namespace System.Management.Automation
internal void SetModule(PSModuleInfo module)
{
Module = module;
_fullName = null;
}
/// <summary>