admin/PowerShell-PowerShell
1
0
Fork 0
mirror of https://github.com/PowerShell/PowerShell synced 2026-06-08 12:12:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Document why PackageVersion is used in PowerShell.Common.props (#12523)

Browse Source 
Co-Authored-By: Nick Guerrera <nicholg@microsoft.com>
This commit is contained in:
xtqqczze
2020-04-30 09:35:54 -07:00
committed by GitHub
co-authored by Nick Guerrera
parent 9e3b34035f
commit ef1c0d7d51
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
PowerShell.Common.props
+4 -4
View File
@@ -56,12 +56,12 @@
<ProductVersion>$(PSCoreFormattedVersion)</ProductVersion>
<!--
We have explicitly assign 'PackageVersion'
because there is a bug: 'PackageVersion' is correctly assigned as 'Version' in 'NuGet.targets'
but then immediately redefined as '1.0.0'.
Tracking Issue https://github.com/dotnet/sdk/issues/1557
We have to explicitly assign 'PackageVersion' here because we're changing 'Version' in a target.
Before any targets have run (during static evaluation), 'Version' will have defaulted to '1.0.0' and PackageVersion will have defaulted to 'Version'.
See https://github.com/dotnet/sdk/issues/1557
-->
<PackageVersion>$(PSCoreBuildVersion)</PackageVersion>
<ApplicationIcon Condition="$(ProductVersion.Contains('preview'))">..\..\assets\Powershell_av_colors.ico</ApplicationIcon>
<ApplicationIcon Condition="!$(ProductVersion.Contains('preview'))">..\..\assets\Powershell_black.ico</ApplicationIcon>