admin/PowerShell-PowerShell
1
0
Fork 0
mirror of https://github.com/PowerShell/PowerShell synced 2026-06-08 12:12:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix progress calculation divide by zero in Copy-Item (#19038)

Browse Source
This commit is contained in:
Aditya Patwardhan
2023-01-27 10:03:19 -08:00
committed by GitHub
parent 5f3100cd95
commit f8cbf90ccb
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/System.Management.Automation/namespaces/FileSystemProvider.cs
+1 -1
View File
@@ -3938,7 +3938,7 @@ namespace Microsoft.PowerShell.Commands
StringUtil.Format(FileSystemProviderStrings.CopyingLocalFileActivity, _copiedFiles, _totalFiles),
StringUtil.Format(FileSystemProviderStrings.CopyingLocalBytesStatus, Utils.DisplayHumanReadableFileSize(_copiedBytes), Utils.DisplayHumanReadableFileSize(_totalBytes), speed)
);
var percentComplete = (int)Math.Min(_copiedBytes * 100 / _totalBytes, 100);
var percentComplete = _totalBytes != 0 ? (int)Math.Min(_copiedBytes * 100 / _totalBytes, 100) : 100;
progress.PercentComplete = percentComplete;
progress.RecordType = ProgressRecordType.Processing;
WriteProgress(progress);
test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1
+6
View File
@@ -317,6 +317,12 @@ Describe "Basic FileSystem Provider Tests" -Tags "CI" {
Remove-Item -Path $testPath -Recurse -Force -ErrorAction SilentlyContinue
}
}
It "Copy-Item can copy 0 byte length file" {
$zeroLengthFile = New-Item -Path (Join-Path $TestDrive "zeroLengthFile.txt") -ItemType File -Force
Copy-Item -Path $zeroLengthFile -Destination "$TestDrive\zeroLengthFile2.txt" -Force
"$TestDrive\zeroLengthFile2.txt" | Should -Exist
}
}
Context "Validate behavior when access is denied" {