admin/RedTeamPentesting-adauth
1
0
Fork 0
mirror of https://github.com/RedTeamPentesting/adauth synced 2026-06-08 12:20:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

x509ext: Remove error returned by SID(...) when extension is not present

Browse Source
This commit is contained in:
Erik Geiser
2025-08-13 13:18:17 +02:00
parent ea51cc58ea
commit 7b7557c201
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
x509ext/sid.go
+3 -3
View File
@@ -53,8 +53,8 @@ func NewNTDSCaSecurityExt(sid string) (ext pkix.Extension, err error) {
return ext, nil
}
// SID retrieves the SID from the szOID_NTDS_CA_SECURITY_EXT extension of the
// certificate if it is present and returns an error otherwise.
// SID retrieves the SID from the szOID_NTDS_CA_SECURITY_EXT extension and an
// empty string with no error when the extension is not present.
func SID(cert *x509.Certificate) (string, error) {
for _, extension := range append(cert.Extensions, cert.ExtraExtensions...) {
if !extension.Id.Equal(NTDSCASecurityExtOID) {
@@ -64,7 +64,7 @@ func SID(cert *x509.Certificate) (string, error) {
return SIDFromExtension(extension)
}
return "", fmt.Errorf("certificate has no NTDS_CA_SECURITY_EXT extension")
return "", nil
}
// SID retrieves the SID from the szOID_NTDS_CA_SECURITY_EXT extension.